Toolbar not displayed correctly after returning from background and switching to regular tabs. |
||||||
Issue descriptionApp Version: 66.0.3359.17 beta iOS Version: 11.2.6, 10.3.3 Device: iPhone8, iPhone7plus URL: any Steps to reproduce: 1. Launch Google Chrome 2. Open techmeme.com 3. Scroll down the page to enter into fullscreen mode 4. Long tap on any link and select Open in incogniro tab 5. Background the app and launch again 6. Enter tab switch and switch to the regular tab opened in step#2 Observed results: Toolbar is overlapped on to the system status bar Expected results: Toolbar should be displayed correctly. Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: NA Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA Bug reproducible on current stable build (App Version, iOS Version): M65 YES Bug reproducible on the current beta channel build (App Version, iOS Version): M66 YES Link to video/image: https://drive.google.com/file/d/1Vs-12_T9p6j5EjIutQgPc6Dknvz2J1w9/view
,
Mar 11 2018
,
Mar 11 2018
,
Mar 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/876ab4691f1840085c80c1ea1340e14474b73042 commit 876ab4691f1840085c80c1ea1340e14474b73042 Author: Kurt Horimoto <kkhorimoto@chromium.org> Date: Tue Mar 13 17:53:19 2018 [iOS] Update for the current FS progress when BVC is shown. BVC only listens for fullscreen progress when it's visible and active. This CL updates BVC for the current fullscreen progress when being shown so that any updates that occur while the BVC is not visible are immediately reflected. Bug: 820174 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id9447065a30c3c8bb627afe7213cb4a623d8c5fb Reviewed-on: https://chromium-review.googlesource.com/958484 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#542846} [modify] https://crrev.com/876ab4691f1840085c80c1ea1340e14474b73042/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/876ab4691f1840085c80c1ea1340e14474b73042/ios/chrome/browser/ui/fullscreen/fullscreen_controller.h [modify] https://crrev.com/876ab4691f1840085c80c1ea1340e14474b73042/ios/chrome/browser/ui/fullscreen/fullscreen_controller_impl.h [modify] https://crrev.com/876ab4691f1840085c80c1ea1340e14474b73042/ios/chrome/browser/ui/fullscreen/fullscreen_controller_impl.mm [modify] https://crrev.com/876ab4691f1840085c80c1ea1340e14474b73042/ios/chrome/browser/ui/fullscreen/test/test_fullscreen_controller.h [modify] https://crrev.com/876ab4691f1840085c80c1ea1340e14474b73042/ios/chrome/browser/ui/fullscreen/test/test_fullscreen_controller.mm
,
Mar 14 2018
Not sure if this is worth merging to M66. The fix is pretty minimal risk.
,
Mar 15 2018
Your change meets the bar and is auto-approved for M66. Please go ahead and merge the CL to branch 3359 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1778430b2aa98c404ef5ba9acc9b47901ff60464 commit 1778430b2aa98c404ef5ba9acc9b47901ff60464 Author: Kurt Horimoto <kkhorimoto@chromium.org> Date: Thu Mar 15 01:09:41 2018 [iOS] Update for the current FS progress when BVC is shown. BVC only listens for fullscreen progress when it's visible and active. This CL updates BVC for the current fullscreen progress when being shown so that any updates that occur while the BVC is not visible are immediately reflected. Bug: 820174 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id9447065a30c3c8bb627afe7213cb4a623d8c5fb Reviewed-on: https://chromium-review.googlesource.com/958484 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#542846}(cherry picked from commit 876ab4691f1840085c80c1ea1340e14474b73042) Reviewed-on: https://chromium-review.googlesource.com/963615 Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#259} Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} [modify] https://crrev.com/1778430b2aa98c404ef5ba9acc9b47901ff60464/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/1778430b2aa98c404ef5ba9acc9b47901ff60464/ios/chrome/browser/ui/fullscreen/fullscreen_controller.h [modify] https://crrev.com/1778430b2aa98c404ef5ba9acc9b47901ff60464/ios/chrome/browser/ui/fullscreen/fullscreen_controller_impl.h [modify] https://crrev.com/1778430b2aa98c404ef5ba9acc9b47901ff60464/ios/chrome/browser/ui/fullscreen/fullscreen_controller_impl.mm [modify] https://crrev.com/1778430b2aa98c404ef5ba9acc9b47901ff60464/ios/chrome/browser/ui/fullscreen/test/test_fullscreen_controller.h [modify] https://crrev.com/1778430b2aa98c404ef5ba9acc9b47901ff60464/ios/chrome/browser/ui/fullscreen/test/test_fullscreen_controller.mm
,
Mar 22 2018
Verified in 66.0.3359.48 beta, iPhone 8 iOS 11.2.6, iPhone 6 iOS 10.3.3 Looks good. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by gambard@chromium.org
, Mar 9 2018Status: Assigned (was: Untriaged)