New issue
Advanced search Search tips

Issue 820161 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Implement Skip UI flow on Desktop

Project Member Reported by anthonyvd@chromium.org, Mar 8 2018

Issue description

^^
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/968ae4dad3ca78c59d5f9d367085f9346c42a103

commit 968ae4dad3ca78c59d5f9d367085f9346c42a103
Author: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Date: Thu Mar 15 16:56:36 2018

[Web Payments] Implement skip UI flow on desktop

Bug:  820161 
Change-Id: I5a458a374890a285daa594b3c2ca72a821d2f93a
Reviewed-on: https://chromium-review.googlesource.com/955891
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543405}
[modify] https://crrev.com/968ae4dad3ca78c59d5f9d367085f9346c42a103/chrome/browser/about_flags.cc
[modify] https://crrev.com/968ae4dad3ca78c59d5f9d367085f9346c42a103/chrome/browser/android/chrome_feature_list.cc
[modify] https://crrev.com/968ae4dad3ca78c59d5f9d367085f9346c42a103/chrome/browser/android/chrome_feature_list.h
[modify] https://crrev.com/968ae4dad3ca78c59d5f9d367085f9346c42a103/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/968ae4dad3ca78c59d5f9d367085f9346c42a103/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/968ae4dad3ca78c59d5f9d367085f9346c42a103/chrome/browser/payments/chrome_payment_request_delegate.cc
[modify] https://crrev.com/968ae4dad3ca78c59d5f9d367085f9346c42a103/chrome/browser/payments/chrome_payment_request_delegate.h
[modify] https://crrev.com/968ae4dad3ca78c59d5f9d367085f9346c42a103/chrome/browser/ui/views/payments/payment_request_dialog_view.cc
[modify] https://crrev.com/968ae4dad3ca78c59d5f9d367085f9346c42a103/chrome/browser/ui/views/payments/payment_request_dialog_view.h
[modify] https://crrev.com/968ae4dad3ca78c59d5f9d367085f9346c42a103/chrome/browser/ui/views/payments/payment_request_payment_app_browsertest.cc
[modify] https://crrev.com/968ae4dad3ca78c59d5f9d367085f9346c42a103/chrome/browser/ui/views/payments/test_chrome_payment_request_delegate.cc
[modify] https://crrev.com/968ae4dad3ca78c59d5f9d367085f9346c42a103/chrome/browser/ui/views/payments/test_chrome_payment_request_delegate.h
[modify] https://crrev.com/968ae4dad3ca78c59d5f9d367085f9346c42a103/components/payments/content/payment_request.cc
[modify] https://crrev.com/968ae4dad3ca78c59d5f9d367085f9346c42a103/components/payments/content/payment_request.h
[modify] https://crrev.com/968ae4dad3ca78c59d5f9d367085f9346c42a103/components/payments/content/payment_request_dialog.h
[modify] https://crrev.com/968ae4dad3ca78c59d5f9d367085f9346c42a103/components/payments/content/payment_request_display_manager.cc
[modify] https://crrev.com/968ae4dad3ca78c59d5f9d367085f9346c42a103/components/payments/core/features.cc
[modify] https://crrev.com/968ae4dad3ca78c59d5f9d367085f9346c42a103/components/payments/core/features.h
[add] https://crrev.com/968ae4dad3ca78c59d5f9d367085f9346c42a103/components/test/data/payments/bobpay.com/app1/app.js
[add] https://crrev.com/968ae4dad3ca78c59d5f9d367085f9346c42a103/components/test/data/payments/bobpay.com/app1/index.html
[add] https://crrev.com/968ae4dad3ca78c59d5f9d367085f9346c42a103/components/test/data/payments/bobpay.com/app1/index.js
[modify] https://crrev.com/968ae4dad3ca78c59d5f9d367085f9346c42a103/components/test/data/payments/bobpay_ui_skip.js
[modify] https://crrev.com/968ae4dad3ca78c59d5f9d367085f9346c42a103/components/test/data/payments/payment_request_bobpay_ui_skip_test.html

Status: Fixed (was: Started)
I remembered we have an issue that sometimes skip UI may not triggered even though it satisfies the condition, https://cs.chromium.org/chromium/src/components/payments/content/payment_request.cc?rcl=48d065f6b4b21a4c06185f114103eb2556acd1eb&l=360

Shall we keep this bug open for that or create another one?

Sign in to add a comment