New issue
Advanced search Search tips

Issue 820157 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

cros flash emits unrelated warning logs

Project Member Reported by ahass...@chromium.org, Mar 8 2018

Issue description

cros flash emits two warning logs that are not really needed to be emitted. 
One is that quick-provision.log does not exists, but cros flash is not using quick-provisioning yet so, it seems unnecessary. Another is unable to get boot_id from device, but we are gonna get this until the device is fully booted, So they are not really warnings until some timeout passes.

$ cros flash 100.127.25.153 veyron_minnie/latest/test
10:40:52: NOTICE: Preparing to update the remote device 100.127.25.153
10:40:52: NOTICE: Using image veyron_minnie/R67-10469.0.2018_03_07_1553-a1/chromiumos_test_image.bin
 [#############################################################################] 100%
10:43:19: NOTICE: Finalizing image.
10:44:27: NOTICE: Update completed.
10:44:29: WARNING: Could not copy /var/log/quick-provision.log from device.
10:45:09: NOTICE: rebooting device...
10:45:20: WARNING: Unable to get new boot_id after reboot from boot_id b2032833-d499-4e7a-ae97-8e470e381eef
10:45:30: WARNING: Unable to get new boot_id after reboot from boot_id b2032833-d499-4e7a-ae97-8e470e381eef
10:45:40: WARNING: Unable to get new boot_id after reboot from boot_id b2032833-d499-4e7a-ae97-8e470e381eef
10:45:50: WARNING: Unable to get new boot_id after reboot from boot_id b2032833-d499-4e7a-ae97-8e470e381eef
10:46:00: WARNING: Unable to get new boot_id after reboot from boot_id b2032833-d499-4e7a-ae97-8e470e381eef
10:46:10: WARNING: Unable to get new boot_id after reboot from boot_id b2032833-d499-4e7a-ae97-8e470e381eef
10:46:17: NOTICE: Verifying that the device has been updated...
10:46:17: NOTICE: Update performed successfully.
10:46:18: NOTICE: cros flash completed successfully.


@davidriley: I think these are related to some of your recent quick-provisioning changes. Would you be kind and clean them up?

 
I need to think about these -- they were added to make provisioning easier to debug since it has been traditionally way too difficult and trying to leave more breadcrumbs.

I'll figure something out.
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/58e473945a9887f5095aa5eaa5502b7967791a6d

commit 58e473945a9887f5095aa5eaa5502b7967791a6d
Author: David Riley <davidriley@chromium.org>
Date: Fri Mar 09 03:28:38 2018

auto_updater: Do not warn if quick-provision.log cannot be copied.

Logfile isn't always available (ie cros flash, legacy paths), so avoid
a spurious warning.

BUG= chromium:820157 
TEST=cros flash

Change-Id: I8b61e4355a8b905e3df456d9d97d8057d1d4df13
Reviewed-on: https://chromium-review.googlesource.com/955961
Commit-Ready: David Riley <davidriley@chromium.org>
Tested-by: David Riley <davidriley@chromium.org>
Reviewed-by: Amin Hassani <ahassani@chromium.org>

[modify] https://crrev.com/58e473945a9887f5095aa5eaa5502b7967791a6d/lib/remote_access.py
[modify] https://crrev.com/58e473945a9887f5095aa5eaa5502b7967791a6d/lib/auto_updater.py

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/a1c318bd028934f74a583c15b9a410e00125ff6c

commit a1c318bd028934f74a583c15b9a410e00125ff6c
Author: David Riley <davidriley@chromium.org>
Date: Fri Mar 09 03:28:39 2018

remote_access: Log reboot checks as DEBUG.

cros flash output was getting confusing with reboot WARNINGs, but the
messages assist provisioning output, so move to DEBUG so just
provisioning logs them.

BUG= chromium:820157 
TEST=cros flash, loadtest.py DS:8080 config.json -t 1 -s 1

Change-Id: I63a80652b551b27fddf868257a3e61a6deb5eb55
Reviewed-on: https://chromium-review.googlesource.com/956482
Commit-Ready: David Riley <davidriley@chromium.org>
Tested-by: David Riley <davidriley@chromium.org>
Reviewed-by: Amin Hassani <ahassani@chromium.org>

[modify] https://crrev.com/a1c318bd028934f74a583c15b9a410e00125ff6c/lib/remote_access.py

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Tested! Done! Thank you.

Sign in to add a comment