SKPs captured with chrome.gpuBenchmarking.printToSkPicture do not have any images |
||||
Issue descriptionSkia has a RecreateSKPs bot that uses skpicture_printer [1] to capture SKPs. We noticed that the captured SKPs no longer have any images. We do not know exactly when this started happening. Manually running chrome.gpuBenchmarking.printToSkPicture also produces SKPs with no images. [1] https://cs.chromium.org/chromium/src/tools/perf/measurements/skpicture_printer.py?q=skpicture_print&sq=package:chromium&l=32
,
Mar 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/95f838f6df160e4acfc83de7aa2f8ee477fa24d0 commit 95f838f6df160e4acfc83de7aa2f8ee477fa24d0 Author: Florin Malita <fmalita@chromium.org> Date: Thu Mar 08 22:39:18 2018 Fix image serialization in gpuBenchmarking.printToSkPicture PrintToSkPicture currently uses a custom image serializer, but there is no corresponding custom deserializer in Skia -> we cannot deserialize these images. The historical reason for using a custom serializer is support for --skip-reencoding-on-skp-capture. This flag was added in https://crrev.com/1710553002, but is no longer used. The simplest fix for image serialization is to remove the custom proc and allow Skia to handle it instead. BUG= 820142 Change-Id: Id19851811e23dd828b5fea7248874740cfda8dea Reviewed-on: https://chromium-review.googlesource.com/956025 Reviewed-by: Antoine Labour <piman@chromium.org> Reviewed-by: Leon Scroggins <scroggo@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#541911} [modify] https://crrev.com/95f838f6df160e4acfc83de7aa2f8ee477fa24d0/content/public/common/content_switches.cc [modify] https://crrev.com/95f838f6df160e4acfc83de7aa2f8ee477fa24d0/content/public/common/content_switches.h [modify] https://crrev.com/95f838f6df160e4acfc83de7aa2f8ee477fa24d0/content/renderer/gpu/gpu_benchmarking_extension.cc
,
Mar 9 2018
,
Mar 9 2018
Will verify after this weekend's RecreateSKPs bot run.
,
Mar 9 2018
Kicked off a task to recreate SKPs here: https://chromium-swarm.appspot.com/task?id=3c23fb2fe73b3810&refresh=10 The task completed and the new SKPs look much better!
,
Jan 16
(6 days ago)
,
Jan 16
(6 days ago)
|
||||
►
Sign in to add a comment |
||||
Comment 1 by fmalita@chromium.org
, Mar 8 2018Status: Started (was: Available)