Send URL along with robot comment input when posting comments |
||
Issue descriptionWhen posting comments to Gerrit, there is a URL field in RobotCommentInput[1]. Currently we're sending on the URL field from the Comment entity in datastore[2], but that field is never set when creating the Comment[3]. Proposed change: Use the URL "https://<tricium-host>/run/<run-id>" this is not specific to the comment and can be constructed when posting the comment, so this could just be added to the createRobotComment function. [1] https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html#robot-comment-info [2] https://cs.chromium.org/chromium/infra/go/src/infra/tricium/appengine/gerrit/gerrit.go?sq=package:chromium&dr=C&l=153 [3] https://cs.chromium.org/chromium/infra/go/src/infra/tricium/appengine/tracker/rpc_worker_done.go?sq=package:chromium&dr=C&l=321
,
Apr 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/0cc73cd4c590418030cd2b078fefaadb9a0bad8c commit 0cc73cd4c590418030cd2b078fefaadb9a0bad8c Author: Quinten Yearsley <qyearsley@chromium.org> Date: Wed Apr 04 23:53:46 2018 Send a run details page URL with robot comments In robot comments in Gerrit, there's already a "robot run link", but it doesn't link to anything because no URL is being added to comments. This would associate a URL with a run and allow Gerrit to make links to details for Tricium runs. Bug: 820118 Change-Id: I7073829a593c301c09164b7e7c234970d0d2e597 Reviewed-on: https://chromium-review.googlesource.com/956527 Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> [modify] https://crrev.com/0cc73cd4c590418030cd2b078fefaadb9a0bad8c/go/src/infra/tricium/appengine/gerrit/gerrit_test.go [modify] https://crrev.com/0cc73cd4c590418030cd2b078fefaadb9a0bad8c/go/src/infra/tricium/appengine/gerrit/gerrit.go
,
Apr 7 2018
Should be fixed with next deploy, I'll re-open after checking later if this doesn't work as expected. |
||
►
Sign in to add a comment |
||
Comment 1 by qyears...@chromium.org
, Mar 8 2018