New issue
Advanced search Search tips

Issue 820106 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 62400



Sign in to add a comment

PDF XFA: Dropdown options popup is too tall for the page

Project Member Reported by hnakashima@chromium.org, Mar 8 2018

Issue description

On an XFA enabled build:

1. Open https://www.canada.ca/content/dam/ircc/migration/ircc/english/pdf/kits/forms/imm5257e.pdf
2. Open the dropdown under "5. Place of birth" "* Country".
3. Scroll down until the bottom of the first page is visible.
Expected: The popup is contained in the page. The scrollbar is fully visible
Actual: Part of the popup is not visible as it's below the page bounds. The scrollbar down arrow is not visible.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98b4cfd82bb6c3eb7830b46795dcd6896cfdef76

commit 98b4cfd82bb6c3eb7830b46795dcd6896cfdef76
Author: Henrique Nakashima <hnakashima@chromium.org>
Date: Tue Mar 20 19:21:06 2018

Rewrite PDFiumEngine::Form_GetPageViewRect.

It did not do what was expected of FFI_GetPageViewRect. To start,
it assumed the page requested was the most visible one, which isn't
always true. Most importantly, it returned the bounds of the page
in screen coordinates, when it should be returning the bounds of the
visible portion of the page in page coordinates.

Bug:  820106 
Change-Id: Ic35b721632d2de68280c28ab7edac3bedbc7b1c2
Reviewed-on: https://chromium-review.googlesource.com/961249
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544480}
[modify] https://crrev.com/98b4cfd82bb6c3eb7830b46795dcd6896cfdef76/pdf/out_of_process_instance.cc
[modify] https://crrev.com/98b4cfd82bb6c3eb7830b46795dcd6896cfdef76/pdf/out_of_process_instance.h
[modify] https://crrev.com/98b4cfd82bb6c3eb7830b46795dcd6896cfdef76/pdf/pdf_engine.h
[modify] https://crrev.com/98b4cfd82bb6c3eb7830b46795dcd6896cfdef76/pdf/pdfium/pdfium_engine.cc
[modify] https://crrev.com/98b4cfd82bb6c3eb7830b46795dcd6896cfdef76/pdf/pdfium/pdfium_engine.h
[modify] https://crrev.com/98b4cfd82bb6c3eb7830b46795dcd6896cfdef76/pdf/preview_mode_client.cc
[modify] https://crrev.com/98b4cfd82bb6c3eb7830b46795dcd6896cfdef76/pdf/preview_mode_client.h

Cc: kkaluri@chromium.org
Labels: Needs-Feedback
Unable to verify this issue on Debian Rodette and Win 10 with chrome Stable #65.0.3325.181, Canary #67.0.3376.1

On navigating to the provided url in comment #0, unable to see the pdf contents 
Attaching the screen-cast for reference.

As per https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/gHcRVfj-JEk currently Google Chrome is not building with XFA enabled

hnakashima@ Could you please help us with chrome #67.0.3377.0 builds with XFA enabled to verify this fix from TE-End


Thank You...
 
820106.png
61.9 KB View Download
Yeah, Chrome is not currently built with XFA even in dev. We're not there yet. The only way to verify is building it.
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 21 2018

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/19a33e4ece99c4bb438d870c52fbc5ed5e80c897

commit 19a33e4ece99c4bb438d870c52fbc5ed5e80c897
Author: Henrique Nakashima <hnakashima@chromium.org>
Date: Wed Mar 21 20:00:47 2018

Rewrite CPDFXFA_DocEnvironment::GetPopupPos.

This is a step to fix XFA combobox popups being rendered outside the
page.

The rest of the fix is in:
https://chromium-review.googlesource.com/c/chromium/src/+/961249

Bug:  chromium:820106 
Change-Id: I51e5667bc08cdb2028c0afafa6e29e929e661c94
Reviewed-on: https://pdfium-review.googlesource.com/28371
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>

[modify] https://crrev.com/19a33e4ece99c4bb438d870c52fbc5ed5e80c897/fpdfsdk/cpdfsdk_formfillenvironment.cpp
[modify] https://crrev.com/19a33e4ece99c4bb438d870c52fbc5ed5e80c897/fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.cpp

Status: Fixed (was: Assigned)
Labels: -Needs-Feedback
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c4462188e9f55e84365c2b7d602e33a9b140519

commit 5c4462188e9f55e84365c2b7d602e33a9b140519
Author: pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Wed Mar 21 22:27:28 2018

Roll src/third_party/pdfium/ 36bbc24e2..19a33e4ec (2 commits)

https://pdfium.googlesource.com/pdfium.git/+log/36bbc24e2d7e..19a33e4ece99

$ git log 36bbc24e2..19a33e4ec --date=short --no-merges --format='%ad %ae %s'
2018-03-21 hnakashima Rewrite CPDFXFA_DocEnvironment::GetPopupPos.
2018-03-21 thestig Add functions to convert various FPDF_ types.

Created with:
  roll-dep src/third_party/pdfium
BUG= chromium:820106 


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Icbc4e87948a22899f2b3ae2102629eb5f9402f34
Reviewed-on: https://chromium-review.googlesource.com/974103
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#544875}
[modify] https://crrev.com/5c4462188e9f55e84365c2b7d602e33a9b140519/DEPS

Sign in to add a comment