New issue
Advanced search Search tips

Issue 820104 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 62400



Sign in to add a comment

PDF XFA: Delete key does not work on text edits

Project Member Reported by hnakashima@chromium.org, Mar 8 2018

Issue description

On an XFA enabled build:

1. Open https://www.canada.ca/content/dam/ircc/migration/ircc/english/pdf/kits/forms/imm5257e.pdf
2. On a text edit, for example, the one under "1. Full name" "* Family name", type "abcdef".
3. Press Left on the keyboard to move the caret between the 'e' and the 'f'.
4. Press Delete on the keyboard.
Expected: 'f' is deleted
Actual: 'e' is deleted
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 25 2018

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/306b9a87090ba4c4cc8453ef04f230620e224fe0

commit 306b9a87090ba4c4cc8453ef04f230620e224fe0
Author: Henrique Nakashima <hnakashima@chromium.org>
Date: Wed Apr 25 17:52:31 2018

Fix behavior of Delete key in XFA edit.

Delete had two issues: it acted as a backspace that did not move
the caret; delete was considered a valid char to insert in the
character buffer.

Bug:  chromium:820104 
Change-Id: I869eedcbf369b9b1df79f16285d991b8e630cd05
Reviewed-on: https://pdfium-review.googlesource.com/31291
Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>

[modify] https://crrev.com/306b9a87090ba4c4cc8453ef04f230620e224fe0/xfa/fwl/cfwl_edit.cpp

Status: Fixed (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d3394e242567301076002e9f38c4b19f89b912d2

commit d3394e242567301076002e9f38c4b19f89b912d2
Author: pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Wed Apr 25 21:28:45 2018

Roll src/third_party/pdfium/ d9da586dd..7132ee359 (9 commits)

https://pdfium.googlesource.com/pdfium.git/+log/d9da586dd3db..7132ee35925f

$ git log d9da586dd..7132ee359 --date=short --no-merges --format='%ad %ae %s'
2018-04-25 thestig Clean up CCodec_FlateScanlineDecoder.
2018-04-25 tsepez Introduce ScopedFPDF types in public/cpp/fpdf_scopers.h
2018-04-25 rharrison Allow failing to build CFXA_FWLTheme if unable to load fonts
2018-04-25 thestig Remove unused PNGEncode() code.
2018-04-25 thestig Roll third_party/googletest/src/ a325ad2db..4bd8c4638 (125 commits)
2018-04-25 thestig Use WindowsPrintMode in more places in place of ints.
2018-04-25 hnakashima Fix behavior of Delete key in XFA edit.
2018-04-25 tsepez Fix slight type inconsistencies discovered with strict FPDF API types.
2018-04-25 thestig Remove CDWriteExt.

Created with:
  roll-dep src/third_party/pdfium
BUG= chromium:835608 , chromium:820104 


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Ib3baadc56b41581755208c483b861b5587ef7953
Reviewed-on: https://chromium-review.googlesource.com/1028661
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#553756}
[modify] https://crrev.com/d3394e242567301076002e9f38c4b19f89b912d2/DEPS

Sign in to add a comment