New issue
Advanced search Search tips

Issue 820097 link

Starred by 1 user
Status: Fixed
Owner:
gambard@chromium.org
Closed: Mar 2018
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task
Q1



Sign in to add a comment

Adaptive Toolbar: Don't display the shadow during side swipe

Project Member Reported by gambard@chromium.org, Mar 8 2018 
The side swipe code is adding a shadow below the snapshot of the toolbar. There is none for the adaptive toolbar, it should be removed.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e19636a93f6ab5f17fe1768a61790decbb52a92

commit 9e19636a93f6ab5f17fe1768a61790decbb52a92
Author: Gauthier Ambard <gambard@chromium.org>
Date: Thu Mar 08 17:10:04 2018

Don't display toolbar shadow in side swipe

This CL removes the toolbar's shadow during the tab side swipe if the
UI refresh is enabled.

Bug:  820097 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I31854412ea50261d3cd0c590e5f1ddd90393ec33
Reviewed-on: https://chromium-review.googlesource.com/955591
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541815}
[modify] https://crrev.com/9e19636a93f6ab5f17fe1768a61790decbb52a92/ios/chrome/browser/ui/side_swipe/card_side_swipe_view.mm

Comment 2 by gambard@chromium.org, Mar 8 2018

NextAction: 2018-03-14
Status: Fixed (was: Assigned)

Comment 3 by monor...@bugs.chromium.org, Mar 14 2018 

The NextAction date has arrived: 2018-03-14

Comment 4 by cmasso@google.com, Mar 14 2018

NextAction: ----
►

Sign in to add a comment