New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 820096 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Number of open tabs is not displayed after opening 10 tabs.

Project Member Reported by srikanthg@chromium.org, Mar 8 2018

Issue description

App Version: 66.0.3359.17 beta
iOS Version: 11.2.6, 10.3.3
Device: iPhones only
URL: na

Steps to reproduce:
  1. Launch Google Chrome
  2. Open 10 or more tabs

Observed results: Observe that tab switcher icon shows … as the tab count.

Expected results: Tab switcher icon should continue showing the number of open tabs.

Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on Chrome Mobile on Android: NA
Bug reproducible on Safari/Firefox: Firefox:NA , Safari: NA
Bug reproducible on current stable build (App Version, iOS Version): M65 NO
Bug reproducible on the current beta channel build (App Version, iOS Version): M66 YES

Link to video/image: https://drive.google.com/file/d/1MuGnkmg60MtMwpBnFiGJqy8nllRz6qav/view 
 
Owner: gambard@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/85d6c9969f24759e63e0adc6a086c15631b8ec6d

commit 85d6c9969f24759e63e0adc6a086c15631b8ec6d
Author: Gauthier Ambard <gambard@chromium.org>
Date: Fri Mar 09 11:45:18 2018

Change toolbar stack view button

This CL changes the toolbar button used to access the stack view.
The button used for the clean toolbar as some specific effects which
don't work on the non-adaptive toolbar.

Bug:  820096 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: If0bdc61050eebd1d4cb3d5230aa828444076649c
Reviewed-on: https://chromium-review.googlesource.com/955573
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542081}
[modify] https://crrev.com/85d6c9969f24759e63e0adc6a086c15631b8ec6d/ios/chrome/browser/ui/toolbar/buttons/toolbar_button_factory.h
[modify] https://crrev.com/85d6c9969f24759e63e0adc6a086c15631b8ec6d/ios/chrome/browser/ui/toolbar/buttons/toolbar_button_factory.mm
[modify] https://crrev.com/85d6c9969f24759e63e0adc6a086c15631b8ec6d/ios/chrome/browser/ui/toolbar/clean/toolbar_view.mm

Labels: Merge-Request-66
Status: Fixed (was: Assigned)
Project Member

Comment 4 by sheriffbot@chromium.org, Mar 10 2018

Labels: -Merge-Request-66 Merge-Approved-66 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M66. Please go ahead and merge the CL to branch 3359 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 13 2018

Labels: -merge-approved-66 merge-merged-3359
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4916cc15d00af316edb6433fb6fe56b0657d256a

commit 4916cc15d00af316edb6433fb6fe56b0657d256a
Author: Gauthier Ambard <gambard@chromium.org>
Date: Tue Mar 13 14:09:33 2018

Change toolbar stack view button

This CL changes the toolbar button used to access the stack view.
The button used for the clean toolbar as some specific effects which
don't work on the non-adaptive toolbar.

Bug:  820096 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: If0bdc61050eebd1d4cb3d5230aa828444076649c
Reviewed-on: https://chromium-review.googlesource.com/955573
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#542081}
Reviewed-on: https://chromium-review.googlesource.com/960035
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/branch-heads/3359@{#192}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[modify] https://crrev.com/4916cc15d00af316edb6433fb6fe56b0657d256a/ios/chrome/browser/ui/toolbar/buttons/toolbar_button_factory.h
[modify] https://crrev.com/4916cc15d00af316edb6433fb6fe56b0657d256a/ios/chrome/browser/ui/toolbar/buttons/toolbar_button_factory.mm
[modify] https://crrev.com/4916cc15d00af316edb6433fb6fe56b0657d256a/ios/chrome/browser/ui/toolbar/clean/toolbar_view.mm

Status: Verified (was: Fixed)
Verified on M67.0.3369.0 Canary on iPhone X iOS 11.2.6, iPhone6+ iOS 11.3 beta #5

Verified on chrome beta version 66.0.3359.30 on iPhone 6s plus 10.3.3 and iPhone 7 11.2.6, following steps mentioned in comment #0. Tab count is displayed.  Looks good.

Comment 8 by pkl@chromium.org, Mar 27 2018

Cc: sczs@chromium.org gambard@chromium.org cma...@chromium.org kkhorimoto@chromium.org pkl@chromium.org stkhapugin@chromium.org
 Issue 825534  has been merged into this issue.

Sign in to add a comment