Issue metadata
Sign in to add a comment
|
Grey patch is displayed at bottom for web pages. |
||||||||||||||||||||
Issue descriptionApp Version: 66.0.3359.17 beta iOS Version: 11.2.6 Device : iPhone X Only Pre-Condition : 1. Enable #slim-navigation-manager from chrome flags Steps to reproduce : 1. Launch chrome. 2. Goto any webpage say : facebook.com. 3. Scroll the screen upwards and downwards. Observed results: Grey patch is displayed at bottom Expected results: Grey patch should not be displayed Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: NA Bug reproducible on Dolphin/Safari/Firefox: Safari : NA Bug reproducible on current stable build (App Version, iOS Version): No in M64 Bug reproducible on the current beta channel build (App Version, iOS Version): No in M65 Link to Video : https://drive.google.com/file/d/1XBvZ7vMh-2tFAuvZM9_tZKp4c2wmsJRW/view?usp=sharing
,
Mar 8 2018
,
Mar 20 2018
,
Mar 20 2018
,
Mar 20 2018
Obviously this is RBS only if we're planning to have the flag on by default in M66.
,
Mar 20 2018
We don't plan to have the flag on by default in M66 stable. It's on for 50% flag in Dev/Canary. Should this still be release blocking?
,
Mar 20 2018
No. In that case, it is not. Thanks.
,
Mar 20 2018
This is reproduced on iPhoneX with 11.3 beta#6 and 11.2.6 on fresh installation of M66.0.3359.30 beta channel build. (without manually enabling any flags). Doesn't look like related to #slim-navigation-manager. lindsayw@ Can you reassign?
,
Mar 20 2018
Eugene and Kurt, Is this potentially related to web or fullscreen instead of slim-manager since with the flag off it still repro's?
,
Mar 20 2018
I don't think we recently had any changes in ios/web which could affect this. Pramod, cold you please bisect good and bad version for this regression.
,
Mar 20 2018
Good Version: 66.0.3357.0 #837639b Bad Version: 66.0.3358.0 #9c9aa3b
,
Mar 20 2018
https://chromium-review.googlesource.com/931466 looks suspicious. Gauthier, could you please take a look.
,
Mar 21 2018
Removing Proj-WKBackForwardList per comment 8.
,
Mar 23 2018
Should be fixed with https://chromium-review.googlesource.com/c/chromium/src/+/977663. Requesting a merge.
,
Mar 23 2018
This bug requires manual review: Less than 21 days to go before AppStore submit on M66 Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 23 2018
+cmasso@ for merge request.
,
Mar 23 2018
Please confirm the fix is verified in canary
,
Mar 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6d5050da5e1f93146ebdcde58ca2cb05d874cc59 commit 6d5050da5e1f93146ebdcde58ca2cb05d874cc59 Author: Gauthier Ambard <gambard@chromium.org> Date: Fri Mar 23 09:45:48 2018 Return the correct height of the bottom toolbar This CL adjusts the function returning the height of the bottom toolbar, returning 0 when the toolbar isn't enabled. Bug: 820066 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I31bd8561c831d447f2a45e5beb72d55ebfff1737 Reviewed-on: https://chromium-review.googlesource.com/977663 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#545394} [modify] https://crrev.com/6d5050da5e1f93146ebdcde58ca2cb05d874cc59/ios/chrome/browser/ui/uikit_ui_util.mm
,
Mar 26 2018
Are more cls coming?
,
Mar 27 2018
No, the CL was landed before the merge request. There was a delay before it was added to the bug, I don't know why.
,
Mar 27 2018
Issue verified Version: Chrome Canary 67.0.3382.0 Device: iPhone X iOS: 11.2.6 No Grey patch displayed at bottom for web pages. https://drive.google.com/open?id=1AFeLm0IjcHjyNCuzA-BhbEG3TP1vnHZe
,
Mar 27 2018
,
Mar 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/593edc0aeec9a825e364ee94a71590e01e71f494 commit 593edc0aeec9a825e364ee94a71590e01e71f494 Author: Gauthier Ambard <gambard@chromium.org> Date: Wed Mar 28 06:46:00 2018 Return the correct height of the bottom toolbar This CL adjusts the function returning the height of the bottom toolbar, returning 0 when the toolbar isn't enabled. Bug: 820066 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I31bd8561c831d447f2a45e5beb72d55ebfff1737 Reviewed-on: https://chromium-review.googlesource.com/977663 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#545394}(cherry picked from commit 6d5050da5e1f93146ebdcde58ca2cb05d874cc59) Reviewed-on: https://chromium-review.googlesource.com/983212 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#481} Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} [modify] https://crrev.com/593edc0aeec9a825e364ee94a71590e01e71f494/ios/chrome/browser/ui/uikit_ui_util.mm
,
Mar 30 2018
Verified in 66.0.3359.71 Beta, iPhone X iOS 11.3. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by pmadalla@chromium.org
, Mar 8 2018