New issue
Advanced search Search tips

Issue 820063 link

Starred by 1 user
Status: Fixed
Owner:
a...@chromium.org
Closed: Mar 2018
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

DCHECK failure when open a js dialog

Project Member Reported by bshe@chromium.org, Mar 8 2018 
What steps will reproduce the problem?
(1) Build a Debug version Chrome for Android
(2) go to this url: https://www.w3schools.com/js/tryit.asp?filename=tryjs_prompt
(3) click "try it" button

What is the expected result?
A native prompt shows up

What happens instead?
Chrome crash due to dcheck error here: 
https://cs.chromium.org/chromium/src/content/browser/frame_host/render_frame_host_impl.cc?rcl=4ab948cd0b097dad8c82103d3d8709a46be27b91&l=207

@avi it looks like you were the last person touched that code. Do you mind to take a look?
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 9 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2060a042c8e7746fea6ec0ae19ffe736e258c208

commit 2060a042c8e7746fea6ec0ae19ffe736e258c208
Author: Avi Drissman <avi@chromium.org>
Date: Fri Mar 09 02:02:47 2018

Drop alert DCHECKs.

These DCHECKs don’t tell us anything other than that we fail to update
the browser-side notion of location when a document writes into an
about:blank document, but we know that.

BUG= 820063 , 718570 

Change-Id: I469d75afaafcd87c98529037a1fbbca155ce806c
Reviewed-on: https://chromium-review.googlesource.com/956282
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541989}
[modify] https://crrev.com/2060a042c8e7746fea6ec0ae19ffe736e258c208/content/browser/frame_host/render_frame_host_impl.cc

Comment 2 by a...@chromium.org, Mar 9 2018

Status: Fixed (was: Available)

Comment 3 by a...@chromium.org, Mar 9 2018 

Do we need a merge to 66?

Comment 4 by bshe@chromium.org, Mar 9 2018 

I am not sure. It is a DCHECK failure, I am not sure how important to support M66 debug build (or any build with DCHECK turned on). My guess would be no.

Comment 5 by a...@chromium.org, Mar 9 2018 

OK. The fix is just removing the DCHECKs so it's super mergeable if it turns out to be needed.
►

Sign in to add a comment