Issue metadata
Sign in to add a comment
|
Network service: Lo-Fi mode needs to stop using the ResourceDispatcherHostDelegate |
||||||||||||||||||||||||||
Issue descriptionLo-Fi mode is computing whether to set its custom headers on resource requests using a specific call from the ResourceDispatcherHostDelegate (DetermineEnabledPreviews). With the network service, ResourceDispatcherHost is going away, so this doesn't work anymore. IIUC Lo-Fi mod correctly, status is determined by page. So, if the main resource is requested with the right header, we could plumb the info at commit time to the renderer process and have the subresources requets made with the right header as well? I think that's more or less what we do, right? For navigations, could LoFi use ContentBrowserClient::NavigationRequestStarted which allows the content embedder to specify custom headers it wants for the navigation? This works for all kinds of navigations (subresources as well). See https://cs.chromium.org/chromium/src/content/public/browser/content_browser_client.h?sq=package:chromium&dr=CSs&l=436. Ideally, this would also allow to remove most if not all of the plumbing for LoFi inside content/.
,
Apr 25 2018
This seems to be linked with the data reduction proxy https://cs.chromium.org/chromium/src/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc?rcl=c455f43c2eb81f1d059de0376793e7e1b6e98b57&l=323 so we may have to figure it out as part of the effort that moves the data reduction proxy to the network service.
,
Apr 26 2018
,
May 2 2018
,
May 2 2018
,
May 21 2018
,
May 22 2018
this is not needed for canary.
,
May 29 2018
,
Jun 22 2018
[jcivelli]: Since you marked this as available, I assume you aren't working on it, so I'm clearing its owner field.
,
Aug 8
ryansturm@, Would your previews migration work cover fix this as well ?
,
Aug 8
|
|||||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||||
Comment 1 by jcivelli@chromium.org
, Apr 25 2018