New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 820060 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 842233
Owner: ----
Closed: Aug 8
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Proj-Servicification

Blocking:
issue 598073



Sign in to add a comment

Network service: Lo-Fi mode needs to stop using the ResourceDispatcherHostDelegate

Project Member Reported by clamy@chromium.org, Mar 8 2018

Issue description

Lo-Fi mode is computing whether to set its custom headers on resource requests using a specific call from the ResourceDispatcherHostDelegate (DetermineEnabledPreviews). With the network service, ResourceDispatcherHost is going away, so this doesn't work anymore.

IIUC Lo-Fi mod correctly, status is determined by page. So, if the main resource is requested with the right header, we could plumb the info at commit time to the renderer process and have the subresources requets made with the right header as well? I think that's more or less what we do, right?

For navigations, could LoFi use 
ContentBrowserClient::NavigationRequestStarted which allows the content embedder to specify custom headers it wants for the navigation? This works for all kinds of navigations (subresources as well). See https://cs.chromium.org/chromium/src/content/public/browser/content_browser_client.h?sq=package:chromium&dr=CSs&l=436.

Ideally, this would also allow to remove most if not all of the plumbing for LoFi inside content/.
 
Owner: jcivelli@chromium.org
This seems to be linked with the data reduction proxy https://cs.chromium.org/chromium/src/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc?rcl=c455f43c2eb81f1d059de0376793e7e1b6e98b57&l=323 so we may have to figure it out as part of the effort that moves the data reduction proxy to the network service.

Comment 3 by bengr@chromium.org, Apr 26 2018

Cc: sclit...@chromium.org
Components: Blink>Previews
Blocking: 598073
Components: Internals>Services>Network
Status: Assigned (was: Untriaged)
Status: Available (was: Assigned)

Comment 7 by dxie@chromium.org, May 22 2018

Labels: OS-Android
this is not needed for canary.

Comment 8 by dxie@chromium.org, May 29 2018

Labels: Hotlist-KnownIssue

Comment 9 by mmenke@chromium.org, Jun 22 2018

Cc: jcivelli@chromium.org
Owner: ----
[jcivelli]:  Since you marked this as available, I assume you aren't working on it, so I'm clearing its owner field.
Cc: ryansturm@chromium.org
ryansturm@,
Would your previews migration work cover fix this as well ?
Mergedinto: 842233
Status: Duplicate (was: Available)
842233 tracks all previews calls in RDHD.

Sign in to add a comment