Export passwords button disabled on selecting view later in share window |
||||||
Issue descriptionApp Version: 66.0.3359.17 Beta iOS Version: 10.3.3, 11.3 beta 4 Device: iPhone and iPad Prerequisite: Mozilla firefox app should be installed in device Steps to reproduce: 1. Launch chrome 2. Save passwords to the chrome 3. Go to settings>> passwords 4. Tap on export passwords 5. Select ‘View later’ Observed results: Notice that export passwords button disabled Expected results: Export passwords button should be enabled after sharing with unsupported apps Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: No Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA Bug reproducible on current stable build (App Version, iOS Version): NA (Feature is new in M66) Bug reproducible on the current beta channel build (App Version, iOS Version): yes on M66 Link to video/image: https://drive.google.com/file/d/1xRmj6djGYKisl4S_ztmetzAXUWoo9WKq/view?usp=sharing
,
Mar 8 2018
,
Mar 19 2018
This occurs because the "View Later" extension fails silently and the completionWithItemsHandler from the UIActivityViewController is not called. The handler is responsible for resetting the export functionality (enable button, etc).
,
Mar 21 2018
,
Mar 21 2018
,
Mar 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cad67bd453e4414431d8db2cd9bdb75ee7a5a5b1 commit cad67bd453e4414431d8db2cd9bdb75ee7a5a5b1 Author: Ioana Pandele <ioanap@chromium.org> Date: Tue Mar 27 17:25:16 2018 Fix export reset when completionWithItemsHandler is not called Re-enable password export when the activity view disappears, instead of when completionWithItemsHandler is called. This has the potential to be a premature re-enabling, if the user decides to background the app launched from the activity view and come back to Chrome’s password settings. Re-triggering the export in this case might cause a conflict between multiple exported files. To mitigate this issue, each exported file is stored in its own uniquely identified folder in tmp/passwords/. If completionWithItemsHandler is called, the file and its folder are removed. For the cases in which the completion handler is not called, the rest of the files are deleted at startup. Bug: 820053 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I5683acfe8483876c0aeb81ce25ba83b24f109676 Reviewed-on: https://chromium-review.googlesource.com/974181 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#546148} [modify] https://crrev.com/cad67bd453e4414431d8db2cd9bdb75ee7a5a5b1/ios/chrome/app/BUILD.gn [modify] https://crrev.com/cad67bd453e4414431d8db2cd9bdb75ee7a5a5b1/ios/chrome/app/DEPS [modify] https://crrev.com/cad67bd453e4414431d8db2cd9bdb75ee7a5a5b1/ios/chrome/app/main_controller.mm [modify] https://crrev.com/cad67bd453e4414431d8db2cd9bdb75ee7a5a5b1/ios/chrome/browser/passwords/BUILD.gn [add] https://crrev.com/cad67bd453e4414431d8db2cd9bdb75ee7a5a5b1/ios/chrome/browser/passwords/passwords_directory_util.h [add] https://crrev.com/cad67bd453e4414431d8db2cd9bdb75ee7a5a5b1/ios/chrome/browser/passwords/passwords_directory_util.mm [add] https://crrev.com/cad67bd453e4414431d8db2cd9bdb75ee7a5a5b1/ios/chrome/browser/passwords/passwords_directory_util_unittest.mm [modify] https://crrev.com/cad67bd453e4414431d8db2cd9bdb75ee7a5a5b1/ios/chrome/browser/ui/settings/BUILD.gn [modify] https://crrev.com/cad67bd453e4414431d8db2cd9bdb75ee7a5a5b1/ios/chrome/browser/ui/settings/password_exporter.h [modify] https://crrev.com/cad67bd453e4414431d8db2cd9bdb75ee7a5a5b1/ios/chrome/browser/ui/settings/password_exporter.mm [modify] https://crrev.com/cad67bd453e4414431d8db2cd9bdb75ee7a5a5b1/ios/chrome/browser/ui/settings/password_exporter_unittest.mm [modify] https://crrev.com/cad67bd453e4414431d8db2cd9bdb75ee7a5a5b1/ios/chrome/browser/ui/settings/passwords_settings_egtest.mm [modify] https://crrev.com/cad67bd453e4414431d8db2cd9bdb75ee7a5a5b1/ios/chrome/browser/ui/settings/save_passwords_collection_view_controller.mm [modify] https://crrev.com/cad67bd453e4414431d8db2cd9bdb75ee7a5a5b1/ios/chrome/browser/ui/settings/save_passwords_collection_view_controller_unittest.mm [modify] https://crrev.com/cad67bd453e4414431d8db2cd9bdb75ee7a5a5b1/ios/chrome/test/app/password_test_util.h [modify] https://crrev.com/cad67bd453e4414431d8db2cd9bdb75ee7a5a5b1/ios/chrome/test/app/password_test_util.mm
,
Mar 28 2018
,
Apr 3 2018
Verified in 67.0.3387.0 Canary, iPhone X iOS 11.3 beta 6, iPad Pro iOS11 Looks good |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by huangml@chromium.org
, Mar 8 2018Status: Assigned (was: Untriaged)