New issue
Advanced search Search tips

Issue 820007 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 19
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

DevTools: tabbing out of input fields should remove existing selection

Reported by rp...@etouch.net, Mar 8 2018

Issue description

Version: 66.0.3359.15 (Official Build)Revision881a66ba7ad1ffe268abd0f9f2eb624e735bca7a-refs/branch-heads/3359@{#75}(32/64-bit)
OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.12.6,10.13.1,10.13.4)

What steps will reproduce the problem?
1. Launch chrome,navigate to NTP and open devtools.
2. Now go to 'Performance' section and click on 'Start performing and reloading page' icon to record some activity
3. Now click on 'Event log',Select to drag text 'Select item for details' to 'Filter' text box in 'console' drawer and press 'Tab' key and 'Shift + Tab' key to move focus back and forward,observe
 
Actual: Focus is not seen in 'Filter' text box after pressing 'Tab' key and 'Shift + Tab' key to move focus
Expected: Focus should be seen in 'Filter' text box after pressing 'Tab' key and 'Shift + Tab' key to move focus

This is regression issue, broken in ‘M 63’ and below is the bisect info :
Good build: 63.0.3223.0  (Revision: 503965).
Bad build: 63.0.3225.0 (Revision: 504540).

You are probably looking for a change made after 504147 (known good), but no later than 504148 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/b0d454706e1003638749bebb2b397f99b113fd80..a57d5aa65194cc780ab7039d97aa33d11c6d6585

Suspect : https://chromium.googlesource.com/chromium/src/+/a57d5aa65194cc780ab7039d97aa33d11c6d6585

From the CL above, assigning the issue to the concern owner 

@luoe- Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note : The above issue is also seen on Stable build #65.0.3325.146,Beta build #65.0.3325.125 and Canary build #67.0.3365.0

Thanks!
 
Actual_video.mp4
702 KB View Download
Expected_video.mp4
497 KB View Download

Comment 1 by l...@chromium.org, May 14 2018

Labels: -Pri-1 Pri-2
Thanks for the report.  Reducing priority since this is minor and has been affecting other TextPrompts before.

Comment 2 by l...@chromium.org, Jun 28 2018

Summary: DevTools: tabbing out of input fields should remove existing selection (was: Regression : Focus is not seen in 'Filter' text box in performance section of devtools.)
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94ccd8c0882834b24c036c7830a068533196098a

commit 94ccd8c0882834b24c036c7830a068533196098a
Author: Erik Luo <luoe@chromium.org>
Date: Fri Oct 19 02:15:40 2018

DevTools: hide TextPrompt selection highlight when unfocused

TextPrompts have contenteditable="plaintext-only", which keep their
text selection after losing focus. This CL hides their text select
highlight when not focused.

Also, live expressions no longer keep their highlight when
losing focus.

Bug:  820007 
Change-Id: I19f1e498c3e3c03ad38f022e3c2e9ebbf0f96d94
Reviewed-on: https://chromium-review.googlesource.com/c/1069334
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601026}
[modify] https://crrev.com/94ccd8c0882834b24c036c7830a068533196098a/third_party/blink/renderer/devtools/front_end/console/ConsolePinPane.js
[modify] https://crrev.com/94ccd8c0882834b24c036c7830a068533196098a/third_party/blink/renderer/devtools/front_end/ui/textPrompt.css

Status: Fixed (was: Assigned)
Labels: TE-Verified-M72 TE-Verified-72.0.3588.0
Update :
Rechecked the above issue on Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.13.1,10.13.6,10.14.1) OS using latest Canary build : 72.0.3588.0 and the issue is Fixed.Hence adding TE Verified Labels.

Kindly refer the attached screen cast.

Thank you..!!
Fixed_video.mov
5.8 MB View Download

Sign in to add a comment