Issue metadata
Sign in to add a comment
|
1.4%-9.3% regression in system_health.memory_desktop at 540802:540943 |
||||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Mar 8 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/12e69552440000
,
Mar 14 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/15df3b76440000
,
Mar 14 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/11d18e3e440000
,
Mar 14 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/118094ee440000
,
Mar 15 2018
📍 Found significant differences after each of 12 commits. https://pinpoint-dot-chromeperf.appspot.com/job/11d18e3e440000 Roll V8 back to 6.6.346. by grt@chromium.org https://chromium.googlesource.com/chromium/src/+/1808b6997fe1e50153125f054a6589863733b5bf [v8 platform] Use V8_DEPRECATED macro for CallOnBackgroundThread(). by gab@chromium.org https://chromium.googlesource.com/v8/v8/+/ce1cc81468c73a3d0a44a0065fbc69f80fa9c429 [builtins] Refactor the StringConstructor builtin by mathias@chromium.org https://chromium.googlesource.com/v8/v8/+/15e207b300bf7f7b70df83e98cbaf8c0d99a7485 [runtime] Move validity cell from PrototypeInfo to Map. by ishell@chromium.org https://chromium.googlesource.com/v8/v8/+/40a3e6dcb9bdb5cb2a7f6e29fa8e4de75e538ef6 [wasm] Turn {WasmDebugInfo} into a proper {Struct}. by mstarzinger@chromium.org https://chromium.googlesource.com/v8/v8/+/67fa841bcb1e43977f24917d4b57be2284c6e8e5 Reland "[parser] Remove pretenuring of closures assigned to properties" by adamk@chromium.org https://chromium.googlesource.com/v8/v8/+/3d7ad2e7e53d3cd6add51512580c054abf7e5805 [parser] don't generate unnecessary ADDs for template strings by caitp@igalia.com https://chromium.googlesource.com/v8/v8/+/b53189e8afa9c535bc2aed36df29aa2696177687 [v8] Do not do rely on hyper-threads for concurrent marking on Mac. by gab@chromium.org https://chromium.googlesource.com/v8/v8/+/226da60f4a6f3b46877282a43d3ef71044bc07aa [DataView] Throw TypeError when buffer is detached by jkummerow@chromium.org https://chromium.googlesource.com/v8/v8/+/4534e8cc47d3dc28d61559ffc927cb660791df5e [turbofan] Only lower to PoisonedLoads when --branch-load-poisoning is on. by jarin@chromium.org https://chromium.googlesource.com/v8/v8/+/a4353d1464f5c546774f1ae08d8eebfa31fde963 [in-place weak refs] Add in-place weak references & migrate one WeakCell to it. by marja@chromium.org https://chromium.googlesource.com/v8/v8/+/07c1e641d9864cb2de9692cf69bccca4b49a6f6a [es2015] Refactor the JSArrayIterator. by bmeurer@chromium.org https://chromium.googlesource.com/v8/v8/+/06ee127b75726f9ee541aab10f6aecfe4d96675a Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Mar 15 2018
Pinpoint points to [in-place weak refs] Add in-place weak references & migrate one WeakCell to it. by marja@chromium.org https://chromium.googlesource.com/v8/v8/+/07c1e641d9864cb2de9692cf69bccca4b49a6f6a
,
Mar 15 2018
Debugging notes: trying to debug this locally with: tools/perf/run_benchmark memory.desktop --story-filter TrivialScrollingPageSharedPageState --pageset-repeat 1 --browser release -v v8 @ my commit (the reland of the blamed commit): commit 88062a2cbc6ece40eeab759df7a4f9b2bde384a1 Author: Marja Hölttä <marja@chromium.org> Date: Mon Mar 5 14:18:51 2018 +0100 Reland [in-place weak refs] Add in-place weak references & migrate one WeakCell to it. memory:chrome:all_processes:reported_by_chrome:v8:effective_size = 6.8 MB v8 @ the previous commit commit f6ed92d6ded6539dd9c4a96c00b35d866a01429d (HEAD) Author: Michael Starzinger <mstarzinger@chromium.org> Date: Mon Mar 5 13:58:35 2018 +0100 [wasm] Turn {WasmCompiledModule} into a proper {Struct}. memory:chrome:all_processes:reported_by_chrome:v8:effective_size = 7.4 MB Based on this, I'm not very convinced that it's my commit... going to have a look at the actual blamed commit next (not the reland).
,
Mar 15 2018
cc jgruber, suspecting the guilty commit is this: commit abcc28ced071faee637d5fd59d06cfdf80d8ea3f Author: jgruber <jgruber@chromium.org> Date: Mon Mar 5 10:08:49 2018 +0100 [builtins] Enable embedded builtins and add testing variants
,
Mar 15 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/168d1dbe440000
,
Mar 15 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/1584240e440000
,
Mar 15 2018
Thanks for investigating, looks like this one is mine.. https://chromeperf.appspot.com/report?sid=37b62eb9e6f3df9a9041de6d1d58852690f2ff9b5c58b75767674405db2b9f04&start_rev=515844&end_rev=543293 shows a 300K code-space regression. Kicking off another bisect there.
,
Mar 15 2018
See also https://crbug.com/819217#c5 for potential reasons this might regress memory.
,
Mar 15 2018
Confirmed locally it's the "[builtins] Enable embedded builtins and add testing variants" commit (before: 6.8M, at that commit: 7.4M).
,
Mar 15 2018
The additional indirections for constants and embedded references increase builtins code size by ~90K. The builtins constants table itself adds another ~4K. My guess is that stack-overflow and other benchmarks with large regressions have multiple isolates and thus these effects are multiplied. I'm looking into ways to decrease code size (e.g. by reducing the # of indirections for external references). And once builtins move off-heap, code-space usage should improve significantly. Keeping this open to verify once that has happened.
,
Mar 15 2018
📍 Found significant differences after each of 19 commits. https://pinpoint-dot-chromeperf.appspot.com/job/1584240e440000 Roll V8 back to 6.6.346. by grt@chromium.org https://chromium.googlesource.com/chromium/src/+/1808b6997fe1e50153125f054a6589863733b5bf [builtins] Remove the ObjectConstructor_ConstructStub builtin. by bmeurer@chromium.org https://chromium.googlesource.com/v8/v8/+/c8f34835af9168ad75c43d79da070fd541106040 [builtins] Remove BooleanConstructor_ConstructStub builtin by mathias@chromium.org https://chromium.googlesource.com/v8/v8/+/df5483caeee99df7df4a84da385a9b70440a19e5 [builtins] Remove BigIntConstructor_ConstructStub builtin by mathias@chromium.org https://chromium.googlesource.com/v8/v8/+/306f2fd5a78ba596ab32e8478c2a0f5833a8b295 [builtins] Remove ArrayBufferConstructor_ConstructStub builtin by mathias@chromium.org https://chromium.googlesource.com/v8/v8/+/f8c688f4c26c8186788026ff26dfb9dffdf3be6e [builtins] Remove DateConstructor_ConstructStub builtin. by bmeurer@chromium.org https://chromium.googlesource.com/v8/v8/+/251f63d82f82f1f67393566e5757a162821b6262 [builtins] Remove SymbolConstructor_ConstructStub builtin by mathias@chromium.org https://chromium.googlesource.com/v8/v8/+/0ffaedf8d55861059d47ddcb037b0117369ae321 [builtins] Remove DataViewConstructor_ConstructStub builtin by mathias@chromium.org https://chromium.googlesource.com/v8/v8/+/fa82d01ed06c59800f23631487927e17f817b415 [x64] Use XOR instruction to zero register in SpeculationPoison by kanghua.yu@intel.com https://chromium.googlesource.com/v8/v8/+/a4b615eba1ae2963b0c5659ca22ba42bf16c09bd [builtins] Refactor the StringConstructor builtin by mathias@chromium.org https://chromium.googlesource.com/v8/v8/+/15e207b300bf7f7b70df83e98cbaf8c0d99a7485 [es2015] Extend the array iterator protector. by bmeurer@chromium.org https://chromium.googlesource.com/v8/v8/+/1525374ff5a564b55b748ad33e6cd0d0ea684006 [builtins] Refactor the NumberConstructor builtin by mathias@chromium.org https://chromium.googlesource.com/v8/v8/+/279085d852cb0c90c19fab73e9b464f354c7d707 [builtins] Refactor the ProxyConstructor builtin by mathias@chromium.org https://chromium.googlesource.com/v8/v8/+/08e168d0ff38f97f8638d25fdd050dda7ae10ca6 [ic] Introduce new IC for storing into array literals. by neis@chromium.org https://chromium.googlesource.com/v8/v8/+/2e2860f74f9c610d5ffb3ee1778d937055d25dea [builtins] Enable embedded builtins and add testing variants by jgruber@chromium.org https://chromium.googlesource.com/v8/v8/+/abcc28ced071faee637d5fd59d06cfdf80d8ea3f [turbofan] Fix bug in Array.p.reduceRight by sigurds@chromium.org https://chromium.googlesource.com/v8/v8/+/d1df563059107761c21d9c587169302644e906de [interpreter] Only create spread-related feedback slots when necessary. by neis@chromium.org https://chromium.googlesource.com/v8/v8/+/cf8cd1c444e7975211915fc77c52fe3c66876f78 [in-place weak refs] Add in-place weak references & migrate one WeakCell to it. by marja@chromium.org https://chromium.googlesource.com/v8/v8/+/07c1e641d9864cb2de9692cf69bccca4b49a6f6a Revert "[in-place weak refs] Add in-place weak references & migrate one WeakCell to it." by sigurds@chromium.org https://chromium.googlesource.com/v8/v8/+/73d6037c2051816fe926ae127aa52e863a800189 Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Mar 16 2018
Above bisect actually completed and points to Jakob's change so there is further confirmation.
,
Mar 16 2018
📍 Found significant differences after each of 25 commits. https://pinpoint-dot-chromeperf.appspot.com/job/168d1dbe440000 Roll V8 back to 6.6.346. by grt@chromium.org https://chromium.googlesource.com/chromium/src/+/1808b6997fe1e50153125f054a6589863733b5bf [builtins] Remove the ObjectConstructor_ConstructStub builtin. by bmeurer@chromium.org https://chromium.googlesource.com/v8/v8/+/c8f34835af9168ad75c43d79da070fd541106040 [builtins] Remove BigIntConstructor_ConstructStub builtin by mathias@chromium.org https://chromium.googlesource.com/v8/v8/+/306f2fd5a78ba596ab32e8478c2a0f5833a8b295 [builtins] Remove ArrayBufferConstructor_ConstructStub builtin by mathias@chromium.org https://chromium.googlesource.com/v8/v8/+/f8c688f4c26c8186788026ff26dfb9dffdf3be6e [builtins] Remove DateConstructor_ConstructStub builtin. by bmeurer@chromium.org https://chromium.googlesource.com/v8/v8/+/251f63d82f82f1f67393566e5757a162821b6262 [builtins] Remove SymbolConstructor_ConstructStub builtin by mathias@chromium.org https://chromium.googlesource.com/v8/v8/+/0ffaedf8d55861059d47ddcb037b0117369ae321 [x64] Use XOR instruction to zero register in SpeculationPoison by kanghua.yu@intel.com https://chromium.googlesource.com/v8/v8/+/a4b615eba1ae2963b0c5659ca22ba42bf16c09bd [builtins] Refactor the StringConstructor builtin by mathias@chromium.org https://chromium.googlesource.com/v8/v8/+/15e207b300bf7f7b70df83e98cbaf8c0d99a7485 [ic] Properly handle kApiGetter case with null prototype. by ishell@chromium.org https://chromium.googlesource.com/v8/v8/+/16a3a4e94643a77ab00df63116191839e18ffed9 [runtime] Move validity cell from PrototypeInfo to Map. by ishell@chromium.org https://chromium.googlesource.com/v8/v8/+/40a3e6dcb9bdb5cb2a7f6e29fa8e4de75e538ef6 [bigint] Expose BigInt on the API by jkummerow@chromium.org https://chromium.googlesource.com/v8/v8/+/ed2e7dc6187b2fe3291be1de5ca3e77e4925d9b8 [wasm] Turn {WasmDebugInfo} into a proper {Struct}. by mstarzinger@chromium.org https://chromium.googlesource.com/v8/v8/+/67fa841bcb1e43977f24917d4b57be2284c6e8e5 [bigint] Fix tie-to-even case in BigInt::ToNumber by jkummerow@chromium.org https://chromium.googlesource.com/v8/v8/+/dcbcf0469dc4e3d94270a88aeed614e102ffcdf1 Add libappindicator3-1 to instrumented libraries by timbrown@chromium.org https://chromium.googlesource.com/chromium/src/third_party/instrumented_libraries/+/b745ddca2c63719167c0f2008ae19e667c5e9952 Update V8 DEPS. by v8-autoroll@chromium.org https://chromium.googlesource.com/v8/v8/+/5b0a1eef238444c4418eaa35ab7ffdb6fc7fbbb8 [tools] Improve filtering of top instance types in heap stats by cbruni@chromium.org https://chromium.googlesource.com/v8/v8/+/07eab906575995683e41943b1de55024baf7ee95 [runtime] Always store the name in a function's ScopeInfo by cbruni@chromium.org https://chromium.googlesource.com/v8/v8/+/01488b9c4f1b4c8e2b66494b24d7e7ff8a826860 Revert "[parsing] inline ArrayLiteral creation for spread calls" by sigurds@chromium.org https://chromium.googlesource.com/v8/v8/+/f48e7349035430ea13dd0ce1ed1e775f6eecabeb Reland "[parsing] inline ArrayLiteral creation for spread calls" by neis@chromium.org https://chromium.googlesource.com/v8/v8/+/82345e9fbfb4f6b0177c19eb476cc6c6babcef82 [builtins] Refactor the NumberConstructor builtin by mathias@chromium.org https://chromium.googlesource.com/v8/v8/+/279085d852cb0c90c19fab73e9b464f354c7d707 [runtime] Add BOILERPLATE_DESCRIPTION_TYPE InstanceType by cbruni@chromium.org https://chromium.googlesource.com/v8/v8/+/1f307ba52fa3a7f820be554f7212b7b302b49b62 Reland "[turbofan] Remove obsolete fast-path" by sigurds@chromium.org https://chromium.googlesource.com/v8/v8/+/b124085f372604d92113c027d79facdda56150ac [ic] Introduce new IC for storing into array literals. by neis@chromium.org https://chromium.googlesource.com/v8/v8/+/2e2860f74f9c610d5ffb3ee1778d937055d25dea [builtins] Enable embedded builtins and add testing variants by jgruber@chromium.org https://chromium.googlesource.com/v8/v8/+/abcc28ced071faee637d5fd59d06cfdf80d8ea3f [es2015] Refactor the JSArrayIterator. by bmeurer@chromium.org https://chromium.googlesource.com/v8/v8/+/06ee127b75726f9ee541aab10f6aecfe4d96675a Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Mar 16 2018
,
Mar 17 2018
📍 Found significant differences after each of 32 commits. https://pinpoint-dot-chromeperf.appspot.com/job/15df3b76440000 Roll V8 back to 6.6.346. by grt@chromium.org https://chromium.googlesource.com/chromium/src/+/1808b6997fe1e50153125f054a6589863733b5bf [builtins] Remove the ObjectConstructor_ConstructStub builtin. by bmeurer@chromium.org https://chromium.googlesource.com/v8/v8/+/c8f34835af9168ad75c43d79da070fd541106040 [builtins] Remove BigIntConstructor_ConstructStub builtin by mathias@chromium.org https://chromium.googlesource.com/v8/v8/+/306f2fd5a78ba596ab32e8478c2a0f5833a8b295 [builtins] Remove ArrayBufferConstructor_ConstructStub builtin by mathias@chromium.org https://chromium.googlesource.com/v8/v8/+/f8c688f4c26c8186788026ff26dfb9dffdf3be6e [builtins] Remove SymbolConstructor_ConstructStub builtin by mathias@chromium.org https://chromium.googlesource.com/v8/v8/+/0ffaedf8d55861059d47ddcb037b0117369ae321 [builtins] Remove DataViewConstructor_ConstructStub builtin by mathias@chromium.org https://chromium.googlesource.com/v8/v8/+/fa82d01ed06c59800f23631487927e17f817b415 [x64] Use XOR instruction to zero register in SpeculationPoison by kanghua.yu@intel.com https://chromium.googlesource.com/v8/v8/+/a4b615eba1ae2963b0c5659ca22ba42bf16c09bd [builtins] Refactor the StringConstructor builtin by mathias@chromium.org https://chromium.googlesource.com/v8/v8/+/15e207b300bf7f7b70df83e98cbaf8c0d99a7485 [ic] Properly handle kApiGetter case with null prototype. by ishell@chromium.org https://chromium.googlesource.com/v8/v8/+/16a3a4e94643a77ab00df63116191839e18ffed9 [runtime] Move validity cell from PrototypeInfo to Map. by ishell@chromium.org https://chromium.googlesource.com/v8/v8/+/40a3e6dcb9bdb5cb2a7f6e29fa8e4de75e538ef6 [bigint] Expose BigInt on the API by jkummerow@chromium.org https://chromium.googlesource.com/v8/v8/+/ed2e7dc6187b2fe3291be1de5ca3e77e4925d9b8 [wasm] Turn {WasmDebugInfo} into a proper {Struct}. by mstarzinger@chromium.org https://chromium.googlesource.com/v8/v8/+/67fa841bcb1e43977f24917d4b57be2284c6e8e5 Adding a few more wasm related OWNERS. by bradnelson@chromium.org https://chromium.googlesource.com/v8/v8/+/54c4c8cea16fa6ec5ccdb8ed329aad3be5b959ef Reland "[parser] Remove pretenuring of closures assigned to properties" by adamk@chromium.org https://chromium.googlesource.com/v8/v8/+/3d7ad2e7e53d3cd6add51512580c054abf7e5805 Add libappindicator3-1 to instrumented libraries by timbrown@chromium.org https://chromium.googlesource.com/chromium/src/third_party/instrumented_libraries/+/b745ddca2c63719167c0f2008ae19e667c5e9952 Update V8 DEPS. by v8-autoroll@chromium.org https://chromium.googlesource.com/v8/v8/+/5b0a1eef238444c4418eaa35ab7ffdb6fc7fbbb8 [tools] Improve filtering of top instance types in heap stats by cbruni@chromium.org https://chromium.googlesource.com/v8/v8/+/07eab906575995683e41943b1de55024baf7ee95 [runtime] Always store the name in a function's ScopeInfo by cbruni@chromium.org https://chromium.googlesource.com/v8/v8/+/01488b9c4f1b4c8e2b66494b24d7e7ff8a826860 Revert "[parsing] inline ArrayLiteral creation for spread calls" by sigurds@chromium.org https://chromium.googlesource.com/v8/v8/+/f48e7349035430ea13dd0ce1ed1e775f6eecabeb Reland "[parsing] inline ArrayLiteral creation for spread calls" by neis@chromium.org https://chromium.googlesource.com/v8/v8/+/82345e9fbfb4f6b0177c19eb476cc6c6babcef82 [cctests] Disable flaky cctest test-heap-profiler/SamplingHeapProfiler by sigurds@chromium.org https://chromium.googlesource.com/v8/v8/+/3ea2d6b06f4d68c60b56b14bece073134a7960cd [builtins] Refactor the NumberConstructor builtin by mathias@chromium.org https://chromium.googlesource.com/v8/v8/+/279085d852cb0c90c19fab73e9b464f354c7d707 [runtime] Add BOILERPLATE_DESCRIPTION_TYPE InstanceType by cbruni@chromium.org https://chromium.googlesource.com/v8/v8/+/1f307ba52fa3a7f820be554f7212b7b302b49b62 Reland "[turbofan] Remove obsolete fast-path" by sigurds@chromium.org https://chromium.googlesource.com/v8/v8/+/b124085f372604d92113c027d79facdda56150ac [ic] Remove pointless macros and obsolete comments. by neis@chromium.org https://chromium.googlesource.com/v8/v8/+/97b3a968a518baf98e93a0f399a579f9128b8e31 [ic] Introduce new IC for storing into array literals. by neis@chromium.org https://chromium.googlesource.com/v8/v8/+/2e2860f74f9c610d5ffb3ee1778d937055d25dea [turbofan] Only lower to PoisonedLoads when --branch-load-poisoning is on. by jarin@chromium.org https://chromium.googlesource.com/v8/v8/+/a4353d1464f5c546774f1ae08d8eebfa31fde963 [builtins] Enable embedded builtins and add testing variants by jgruber@chromium.org https://chromium.googlesource.com/v8/v8/+/abcc28ced071faee637d5fd59d06cfdf80d8ea3f [interpreter] Only create spread-related feedback slots when necessary. by neis@chromium.org https://chromium.googlesource.com/v8/v8/+/cf8cd1c444e7975211915fc77c52fe3c66876f78 [in-place weak refs] Add in-place weak references & migrate one WeakCell to it. by marja@chromium.org https://chromium.googlesource.com/v8/v8/+/07c1e641d9864cb2de9692cf69bccca4b49a6f6a Revert "[in-place weak refs] Add in-place weak references & migrate one WeakCell to it." by sigurds@chromium.org https://chromium.googlesource.com/v8/v8/+/73d6037c2051816fe926ae127aa52e863a800189 [es2015] Refactor the JSArrayIterator. by bmeurer@chromium.org https://chromium.googlesource.com/v8/v8/+/06ee127b75726f9ee541aab10f6aecfe4d96675a Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Mar 19 2018
Issue 823055 has been merged into this issue.
,
Mar 19 2018
,
Mar 21 2018
These have recovered now that off-heap builtins have been removed from the snapshot with https://chromium-review.googlesource.com/964481
,
Mar 28 2018
📍 Found significant differences after each of 6 commits. https://pinpoint-dot-chromeperf.appspot.com/job/118094ee440000 Roll V8 back to 6.6.346. by grt@chromium.org https://chromium.googlesource.com/chromium/src/+/1808b6997fe1e50153125f054a6589863733b5bf Fix crash on tabs without web_contents by dullweber@chromium.org https://chromium.googlesource.com/chromium/src/+/099700409957bc4822cc2f7b74d13549e2c643f1 In QUIC, incrementally calculate newly acked packets. Protected by FLAGS_quic_reloadable_flag_quic_use_incremental_ack_processing2. by fayang@chromium.org https://chromium.googlesource.com/chromium/src/+/c8bcdd6d2fec766108893a112bdb834a8ea0fa84 Media Engagement: better handling of history service callbacks. by mlamouri@chromium.org https://chromium.googlesource.com/chromium/src/+/b1ef86c684a159f85fbece233c5c1f86634b0d9f Roll src/third_party/angle/ b27b03a2c..78e39b3fd (1 commit) by angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com https://chromium.googlesource.com/chromium/src/+/935c4fa64ced533b19cd74126e71cc9c1ea46d1d Revert "🤝 Use Origin class for canonically representing origins." by alexilin@chromium.org https://chromium.googlesource.com/chromium/src/+/e9260b672a7685fb955d3bbaf9aacdd67d0b2191 Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Mar 29 2018
,
Apr 15 2018
Previous job on this bug failed due to https://github.com/catapult-project/catapult/issues/4393, retrying now that it's fixed.
,
Apr 15 2018
📍 Pinpoint job started. https://chromeperf.appspot.com/job/12d35806c40000 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Mar 8 2018