"TrayAccessibilityTestInstance/TrayAccessibilityTest.CheckMenuVisibilityOnDetailMenu/0" is flaky |
||||
Issue description"TrayAccessibilityTestInstance/TrayAccessibilityTest.CheckMenuVisibilityOnDetailMenu/0" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyYAsSBUZsYWtlIlVUcmF5QWNjZXNzaWJpbGl0eVRlc3RJbnN0YW5jZS9UcmF5QWNjZXNzaWJpbGl0eVRlc3QuQ2hlY2tNZW51VmlzaWJpbGl0eU9uRGV0YWlsTWVudS8wDA. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Mar 9 2018
James, looks like you looked at this test recently. https://chromium-review.googlesource.com/c/chromium/src/+/889645
,
Mar 9 2018
Ugh, I hate these accessibility tests. I wonder if this is a race between the test code and session controller, since the help button state depends on session state: https://cs.chromium.org/chromium/src/ash/system/tray/tray_popup_utils.cc?type=cs&sq=package:chromium&l=433 bool TrayPopupUtils::CanOpenWebUISettings() { return Shell::Get()->session_controller()->ShouldEnableSettings(); } Failure is: ../../chrome/browser/chromeos/system/tray_accessibility_browsertest.cc:1681: Failure Value of: IsHelpAvailableOnDetailMenu() Actual: false Expected: true Same as issue 787024 I will disable the test shortly.
,
Mar 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/18fe8f8aa1d79367b57e0639ad930345460ad7fc commit 18fe8f8aa1d79367b57e0639ad930345460ad7fc Author: James Cook <jamescook@chromium.org> Date: Fri Mar 09 01:27:26 2018 cros: Disable flaky TrayAccessibilityTest.CheckMenuVisibilityOnDetailMenu Flakily fails with: ../../chrome/browser/chromeos/system/tray_accessibility_browsertest.cc:1681: Failure Value of: IsHelpAvailableOnDetailMenu() Actual: false Expected: true NOTRY=true TBR=xiyuan@chromium.org Bug: 819987 , 787024 Change-Id: I133007c1411f714f2b7646c0c0d949c577c63037 Reviewed-on: https://chromium-review.googlesource.com/956276 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#541980} [modify] https://crrev.com/18fe8f8aa1d79367b57e0639ad930345460ad7fc/chrome/browser/chromeos/system/tray_accessibility_browsertest.cc
,
Mar 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/78a058bc8c5ae34722e689a269682ff4806a42fa commit 78a058bc8c5ae34722e689a269682ff4806a42fa Author: James Cook <jamescook@chromium.org> Date: Fri Mar 09 21:09:44 2018 Move one TrayAccessibilityTest to ash_unittests TrayAccessibilityTest.CheckMenuVisibilityOnDetailMenu was disabled for flake. The most likely cause is test-only race conditions in sending session state from the browser to ash. It does not need to be a browser test. Move it to ash_unittests to avoid the race conditions and re-enable it. Bug: 819987 Test: ash_unittests Change-Id: Iecf37fbb9d0115c5d1f9299e729fb66d193f7048 Reviewed-on: https://chromium-review.googlesource.com/957308 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#542223} [modify] https://crrev.com/78a058bc8c5ae34722e689a269682ff4806a42fa/ash/system/tray_accessibility.h [modify] https://crrev.com/78a058bc8c5ae34722e689a269682ff4806a42fa/ash/system/tray_accessibility_unittest.cc [modify] https://crrev.com/78a058bc8c5ae34722e689a269682ff4806a42fa/chrome/browser/chromeos/system/tray_accessibility_browsertest.cc
,
Mar 9 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by hongchan@chromium.org
, Mar 8 2018Labels: -Sheriff-Chromium OS-Chrome
Status: Assigned (was: Untriaged)