New issue
Advanced search Search tips

Issue 819947 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Dxtory support

Project Member Reported by q...@chromium.org, Mar 8 2018

Issue description

Chrome Version: (copy from chrome://version) 65.0.3325.146
OS: (e.g. Win7, OSX 10.9.5, etc...) Windows 10

What steps will reproduce the problem?
(1) Chrome used to be able to see Dxtory DirectShow outputs as cameras
(2)  Issue 464855  seemed to have made Dxtory support possible
(3) Now WebRTC doesn't seem to want to recognize them at all

What is the expected result?
WebRTC can use Dxtory DirectShow outputs as virtual cameras

What happens instead?
No camera detected

Please use labels and text to provide additional information.


For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

 
2119567872.log
4.7 KB View Download
Cc: niklase@chromium.org
Owner: braveyao@chromium.org
Status: Assigned (was: Untriaged)
Brave, what's the situation here?
Yes we once made it working. But unfortunately, it's regressed a couple of days later, https://chromium.googlesource.com/chromium/src/+/773aa4541957d8ad7d28990005544e98ee534474. So this feature never works at all.

By adding back the media type, it can work again. On it soon.
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d6df7ba10dd03840e11a60f76af8802e530a07b

commit 8d6df7ba10dd03840e11a60f76af8802e530a07b
Author: braveyao <braveyao@chromium.org>
Date: Wed Mar 21 18:41:18 2018

[video capture windows] MEDIASUBTYPE_RGB32 support for Windows

This CL adds support for MEDIASUBTYPE_RGB32 back in Windows platform.

It's firstly added in cl https://codereview.chromium.org/1036063002.
But a next cl, https://codereview.chromium.org/1039383002, might remove
it due to merge error very soon.

TEST=WebRTC sample with DXTory capturing on Solitaire.

Bug:  819947 
Change-Id: Ifaddb682090f738ecc8879078d8e0426bf3def4c
Reviewed-on: https://chromium-review.googlesource.com/972543
Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Commit-Queue: Weiyong Yao <braveyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544781}
[modify] https://crrev.com/8d6df7ba10dd03840e11a60f76af8802e530a07b/media/capture/video/win/video_capture_device_win.cc

Status: Fixed (was: Assigned)

Comment 5 by q...@chromium.org, Mar 21 2018

Nice. Thanks!

Sign in to add a comment