hterm: ctrl+click on URLs should not respect user-configured word break matches
Reported by
johnl...@gmail.com,
Mar 8 2018
|
||
Issue descriptionUserAgent: Mozilla/5.0 (X11; CrOS x86_64 9765.85.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.140 Safari/537.36 Platform: 61.4.54 (Developer Build - neverware) developer-build chromeover64 Steps to reproduce the problem: 1. Go to the configuration page of Secure Shell. 2. Change word-break-match-* configs to [\s] and [\s]*. 3. Click on a link in Secure Shell. What is the expected behavior? A webpage is opened up with whole link. What went wrong? Only a part of the link text is used to open up a webpage. WebStore page: https://chrome.google.com/webstore/detail/secure-shell/pnhechapfaindjhompbnflcldabbghjo Did this work before? N/A Chrome version: 61.0.3163.140 Channel: n/a OS Version: 9765.85.0 Flash Version: Shockwave Flash 20180206.1 r999 This is an issue I reported in the forum: https://groups.google.com/a/chromium.org/forum/#!topic/chromium-hterm/3zFv7sd_DHI
,
Mar 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/apps/libapps/+/cae9b731c000b274e49cb72a39c6a2897f503109 commit cae9b731c000b274e49cb72a39c6a2897f503109 Author: John Lin <johnlinp@gmail.com> Date: Thu Mar 15 07:10:42 2018 hterm: don't use user-configured word break matches when ctrl-clicking on urls This commit created another function hterm.Screen.expandSelectionByUrl besides hterm.Screen.expandSelection. They are doing the same thing except for the word break matches. The former uses a set of fixed word break matches while the latter uses a user-configured one. BUG= chromium:819946 Change-Id: I8e49414dffb8570b41e1d38e056d2847f91ea398 Reviewed-on: https://chromium-review.googlesource.com/954771 Tested-by: John Lin <johnlinp@gmail.com> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/cae9b731c000b274e49cb72a39c6a2897f503109/hterm/js/hterm_screen_tests.js [modify] https://crrev.com/cae9b731c000b274e49cb72a39c6a2897f503109/hterm/js/hterm_terminal.js [modify] https://crrev.com/cae9b731c000b274e49cb72a39c6a2897f503109/hterm/js/hterm_screen.js
,
Mar 15 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by johnl...@gmail.com
, Mar 8 2018