New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 819933 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

git cl lint false positive for <string>

Project Member Reported by lucmult@chromium.org, Mar 8 2018

Issue description

git cl lint flags too aggressively for <string>.

Some source code has variable name as "string" which flags as it should be including <string>

Example:

third_party/WebKit/Source/core/inspector/InspectorOverlayAgent.cpp:959:  Add #include <string> for string  [build/include_what_you_use] [4]
Done processing third_party/WebKit/Source/core/inspector/InspectorOverlayAgent.cpp

There is no use of std::string on this file.

This is more critical on Blink where we should avoid using std::string. If <string> is added in this case it can lead people to believe that <string> can be used on this file, whereas it should be actually avoided.
 

Comment 1 by noel@chromium.org, Mar 8 2018

Who owns / develops "git cl lint" btw?

Comment 2 by caseq@chromium.org, Mar 11 2018

Components: -Platform>DevTools Infra>CodeAnalysis

Comment 3 by mar...@chromium.org, Mar 12 2018

Google (not Chrome); https://github.com/google/styleguide/tree/gh-pages/cpplint

IIRC Elliot used to import it locally.

Sign in to add a comment