Issue metadata
Sign in to add a comment
|
Select To Speak requires silence before speaking another section |
||||||||||||||||||||||||
Issue descriptionGoogle Chrome 67.0.3363.0 (Official Build) canary (64-bit) Firmware Version Google_Samus.6300.276.0 For now, go to Chrome://flags > Enable Experimental accessibility features to get the latest version of STS. In the future, this step won't be needed. This is only applicable to the new way to invoke STS by highlighting text and then using Search + s. That's because pressing the search key currently silences speech (see bug for 819925 that behavior) Steps to repro: # Select text with the mouse # Press Search + s to start STS # While speech is being read, select some more text with the mouse # Press Search + s Expected: STS starts reading the new selection Actual: speech stops entirely
,
Mar 8 2018
Hi Katie, if the new STS feature of reading selected text with Search + s is now public, please remove the Restrict-View-Google label below to make it public. Thanks!
,
Mar 8 2018
,
Mar 8 2018
,
Mar 8 2018
This is a "coming soon" feature, therefore removing the Google only label.
,
Mar 8 2018
,
Mar 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c3123cb9c6fa0bfe312be77cf0d70fb00bfaa058 commit c3123cb9c6fa0bfe312be77cf0d70fb00bfaa058 Author: Katie D <katie@chromium.org> Date: Thu Mar 08 23:56:43 2018 Fix race condition where speech was canceled after starting. This occured when a user used seach+s to start speech while speech was already in progress. The change makes sure that chrome.tts.stop is called before the 'isSpeaking' callback is fired, to make sure that it doesn't get called late. This may cause a few cancel events to not be logged if the tts engine responds very quickly, but based on some manual testing it appears that events should be fine because the tts engine has some latency. I'm not sure how to write tests for this because it requires a lot of timing and a real TTS engine. Open to suggestions. Works well based on local testing, repeatedly using search+s and search+mouse to to cancel and restart speech. Bug: 819926 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I9b59caa4d69be1c0a8ae14af6c850113ff140360 Reviewed-on: https://chromium-review.googlesource.com/956226 Reviewed-by: David Tseng <dtseng@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#541943} [modify] https://crrev.com/c3123cb9c6fa0bfe312be77cf0d70fb00bfaa058/chrome/browser/resources/chromeos/select_to_speak/select_to_speak.js
,
Mar 9 2018
,
Mar 9 2018
,
Mar 16 2018
Google Chrome 67.0.3369.0 (Official Build) canary (64-bit) Firmware Version Google_Samus.6300.276.0 Flag enabled: #enable-experimental-accessibility-features Able to read four different areas of content one after the other. Verfied.
,
Apr 10 2018
Moving from just having STS label to also having the UI>Accessibility>SelectToSpeak component to make searching easier in the future. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by leberly@chromium.org
, Mar 8 2018