This is a meta bug to track all efforts to implement Find-in-page Web APIs Design docs: Find-in-page servicification: https://goo.gl/JenyGm Default FindBar override API: https://goo.gl/FtjuPu
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0570e6b00d7c938329b8cfd0b0c7c65b80ebcb5d commit 0570e6b00d7c938329b8cfd0b0c7c65b80ebcb5d Author: Rakina Zata Amni <rakina@chromium.org> Date: Fri Mar 16 04:12:04 2018 Refactor Find-in-page methods to WebLocalFrameImplFindInPage.cpp We are refactoring find-in-page related methods out of WebLocalFrameImpl.cpp into WebLocalFrameImplFindInPage.cpp WebLocalFrameImplFindInPage.cpp implements WebLocalFrameImpl.h, but only contains the find-in-page related functions for easier maintanability. Refactor plan doc: https://docs.google.com/document/d/1JQWkQbTpYuxNHseAPbOq4rwtS7eFUISymstxDolQ504/edit?usp=sharing Related: Find-in-page S13n/changing legacy IPC to Mojo: Design doc: https://goo.gl/JenyGm Find-in-page Web API to allow suppressing showing Find Bar: https://github.com/rakina/find-in-page-api Bug: 819919 Change-Id: If8e25262245d3117e67b2a93c1bd1b527d457541 Reviewed-on: https://chromium-review.googlesource.com/956648 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#543617} [modify] https://crrev.com/0570e6b00d7c938329b8cfd0b0c7c65b80ebcb5d/third_party/WebKit/Source/core/DEPS [modify] https://crrev.com/0570e6b00d7c938329b8cfd0b0c7c65b80ebcb5d/third_party/WebKit/Source/core/frame/BUILD.gn [modify] https://crrev.com/0570e6b00d7c938329b8cfd0b0c7c65b80ebcb5d/third_party/WebKit/Source/core/frame/WebLocalFrameImpl.cpp [add] https://crrev.com/0570e6b00d7c938329b8cfd0b0c7c65b80ebcb5d/third_party/WebKit/Source/core/frame/WebLocalFrameImplFindInPage.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7b2753891dae3148d5ea3795668be39018439371 commit 7b2753891dae3148d5ea3795668be39018439371 Author: Rakina Zata Amni <rakina@chromium.org> Date: Wed Apr 25 05:43:24 2018 Introduce find_in_page.h for find-in-page related functions We are moving find-in-page related functions out of web_local_frame_impl_find_in_page.cc to its own class (FindInPage) for easier mojoification and so that we can add new find-in-page related functions more easily. In this CL, we are introducing find_in_page.h. WebLocalFrameImpl still have the find-in-page functions, but TextFinder ownership is moved to the FindInPage class. The functions in web_local_frame_impl_find_in_page.cc are changed to call the FindInPage functions (that are in the same file for smaller CL), and will be removed entirely in the next CLs. Previous CL: crrev.com/c/956648 In the previous CL, we moved find-in-page related functions to a new file, but it's still in the WebLocalFrameImpl class. After more discussions, we decided to do the old plan of refactoring the functions to its own class. Next CLs: Move functions from "web_local_frame_impl_find_in_page.cc" to "find_in_page.cc" Remove find-in-page functions from WebLocalFrame Refactor plan doc: https://goo.gl/CtLsFR Further plans: Mojoification https://goo.gl/JenyGm Find-in-page APIs https://github.com/rakina/find-in-page-api/ Bug: 819919 Change-Id: Icc8da3b321c72f2e7a210d5b350711b673eedfec Reviewed-on: https://chromium-review.googlesource.com/1025242 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Takayoshi Kochi <kochi@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#553459} [modify] https://crrev.com/7b2753891dae3148d5ea3795668be39018439371/third_party/blink/renderer/core/frame/web_local_frame_impl.cc [modify] https://crrev.com/7b2753891dae3148d5ea3795668be39018439371/third_party/blink/renderer/core/frame/web_local_frame_impl.h [modify] https://crrev.com/7b2753891dae3148d5ea3795668be39018439371/third_party/blink/renderer/core/frame/web_local_frame_impl_find_in_page.cc [modify] https://crrev.com/7b2753891dae3148d5ea3795668be39018439371/third_party/blink/renderer/core/page/BUILD.gn [add] https://crrev.com/7b2753891dae3148d5ea3795668be39018439371/third_party/blink/renderer/core/page/find_in_page.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2f66db425ca30a4f58d0a2ac4e7e03f36f1e2dd0 commit 2f66db425ca30a4f58d0a2ac4e7e03f36f1e2dd0 Author: Rakina Zata Amni <rakina@chromium.org> Date: Wed Apr 25 22:48:03 2018 Move functions from web_local_frame_impl_find_in_page.cc to find_in_page.cc We are moving find-in-page related functions out of web_local_frame_impl_find_in_page.cc to its own class (FindInPage) for easier mojoification and so that we can add new find-in-page related functions more easily. In this CL, we are moving functions out of web_local_frame_impl_find_in_page.cc. In the next CL we are going to entirely remove the functions from the WebLocalFrame interface. Previous CLs: crrev.com/c/956648 crrev.com/c/1025242 Next CLs: Remove find-in-page functions from WebLocalFrame Introduce FindInPage mojo interface Bug: 819919 Change-Id: Ia82b5e8f1e08701b014236039d2c6e5e45410222 Reviewed-on: https://chromium-review.googlesource.com/1027013 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by: Takayoshi Kochi <kochi@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#553801} [modify] https://crrev.com/2f66db425ca30a4f58d0a2ac4e7e03f36f1e2dd0/third_party/blink/renderer/core/DEPS [modify] https://crrev.com/2f66db425ca30a4f58d0a2ac4e7e03f36f1e2dd0/third_party/blink/renderer/core/frame/BUILD.gn [rename] https://crrev.com/2f66db425ca30a4f58d0a2ac4e7e03f36f1e2dd0/third_party/blink/renderer/core/frame/find_in_page.cc [rename] https://crrev.com/2f66db425ca30a4f58d0a2ac4e7e03f36f1e2dd0/third_party/blink/renderer/core/frame/find_in_page.h [modify] https://crrev.com/2f66db425ca30a4f58d0a2ac4e7e03f36f1e2dd0/third_party/blink/renderer/core/frame/web_local_frame_impl.cc [modify] https://crrev.com/2f66db425ca30a4f58d0a2ac4e7e03f36f1e2dd0/third_party/blink/renderer/core/page/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/acf4049e2d682fc219d832f7baebdc1061afa8dd commit acf4049e2d682fc219d832f7baebdc1061afa8dd Author: Rakina Zata Amni <rakina@chromium.org> Date: Tue May 08 22:59:33 2018 Add FindInPage mojo interface with ClearActiveFindMatch We are mojoifying browser<->renderer communication of Find-in-page. In this CL, we are introducing the FindInPage mojo interface, which currently only have the ClearActiveFindMatch function in it and its implementation on the browser and renderer side. We are also removing the old IPC messagefor ClearActiveFindMatch and functions related to it. ClearActiveFindMatch is called when the browser side wants to remove the current active match highlighting in a frame. Previous CLs (refactoring): crrev.com/c/956648 crrev.com/c/1025242 crrev.com/c/1027013 Future CLs: Mojoify other find-in-page functions Mojoifying doc: https://goo.gl/JenyGm Bug: 819919 Change-Id: I3ca9835819c6a46fbee0e2bf20a665c0bd0f5d22 Reviewed-on: https://chromium-review.googlesource.com/1027393 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by: Paul Meyer <paulmeyer@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Takayoshi Kochi <kochi@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#556996} [modify] https://crrev.com/acf4049e2d682fc219d832f7baebdc1061afa8dd/content/browser/find_request_manager.cc [modify] https://crrev.com/acf4049e2d682fc219d832f7baebdc1061afa8dd/content/browser/find_request_manager.h [modify] https://crrev.com/acf4049e2d682fc219d832f7baebdc1061afa8dd/content/common/frame_messages.h [modify] https://crrev.com/acf4049e2d682fc219d832f7baebdc1061afa8dd/content/renderer/render_frame_impl.cc [modify] https://crrev.com/acf4049e2d682fc219d832f7baebdc1061afa8dd/content/renderer/render_frame_impl.h [modify] https://crrev.com/acf4049e2d682fc219d832f7baebdc1061afa8dd/third_party/blink/public/mojom/BUILD.gn [add] https://crrev.com/acf4049e2d682fc219d832f7baebdc1061afa8dd/third_party/blink/public/mojom/frame/OWNERS [add] https://crrev.com/acf4049e2d682fc219d832f7baebdc1061afa8dd/third_party/blink/public/mojom/frame/find_in_page.mojom [modify] https://crrev.com/acf4049e2d682fc219d832f7baebdc1061afa8dd/third_party/blink/public/web/web_local_frame.h [modify] https://crrev.com/acf4049e2d682fc219d832f7baebdc1061afa8dd/third_party/blink/renderer/core/frame/find_in_page.cc [modify] https://crrev.com/acf4049e2d682fc219d832f7baebdc1061afa8dd/third_party/blink/renderer/core/frame/find_in_page.h [modify] https://crrev.com/acf4049e2d682fc219d832f7baebdc1061afa8dd/third_party/blink/renderer/core/frame/web_local_frame_impl.cc [modify] https://crrev.com/acf4049e2d682fc219d832f7baebdc1061afa8dd/third_party/blink/renderer/core/frame/web_local_frame_impl.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/174ef718eaf904b8f149cc4667c2a8ab5b4ca9b9 commit 174ef718eaf904b8f149cc4667c2a8ab5b4ca9b9 Author: Rakina Zata Amni <rakina@chromium.org> Date: Mon May 14 12:45:20 2018 Mojoify FindInPage::FindMatchRects We are mojoifying browser<->renderer communication of Find-in-page. In this CL, we are converting the FindMatchRects function to mojo. Mojoifying doc: https://goo.gl/JenyGm Previous CL: Add FindInPage mojo interface with ClearActiveFindMatch crrev.com/c/1027393 Future CLs: Mojoify other find-in-page functions Bug: 819919 Change-Id: I63dd966ac8008460dce796e2c2405df353416fd0 Reviewed-on: https://chromium-review.googlesource.com/1049770 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#558272} [modify] https://crrev.com/174ef718eaf904b8f149cc4667c2a8ab5b4ca9b9/content/browser/find_request_manager.cc [modify] https://crrev.com/174ef718eaf904b8f149cc4667c2a8ab5b4ca9b9/content/browser/find_request_manager.h [modify] https://crrev.com/174ef718eaf904b8f149cc4667c2a8ab5b4ca9b9/content/browser/frame_host/render_frame_host_impl.cc [modify] https://crrev.com/174ef718eaf904b8f149cc4667c2a8ab5b4ca9b9/content/browser/frame_host/render_frame_host_impl.h [modify] https://crrev.com/174ef718eaf904b8f149cc4667c2a8ab5b4ca9b9/content/browser/web_contents/web_contents_impl.cc [modify] https://crrev.com/174ef718eaf904b8f149cc4667c2a8ab5b4ca9b9/content/browser/web_contents/web_contents_impl.h [modify] https://crrev.com/174ef718eaf904b8f149cc4667c2a8ab5b4ca9b9/content/common/frame_messages.h [modify] https://crrev.com/174ef718eaf904b8f149cc4667c2a8ab5b4ca9b9/content/renderer/render_frame_impl.cc [modify] https://crrev.com/174ef718eaf904b8f149cc4667c2a8ab5b4ca9b9/content/renderer/render_frame_impl.h [modify] https://crrev.com/174ef718eaf904b8f149cc4667c2a8ab5b4ca9b9/third_party/blink/public/mojom/frame/find_in_page.mojom [modify] https://crrev.com/174ef718eaf904b8f149cc4667c2a8ab5b4ca9b9/third_party/blink/public/web/web_local_frame.h [modify] https://crrev.com/174ef718eaf904b8f149cc4667c2a8ab5b4ca9b9/third_party/blink/renderer/core/BUILD.gn [modify] https://crrev.com/174ef718eaf904b8f149cc4667c2a8ab5b4ca9b9/third_party/blink/renderer/core/editing/finder/text_finder.cc [modify] https://crrev.com/174ef718eaf904b8f149cc4667c2a8ab5b4ca9b9/third_party/blink/renderer/core/editing/finder/text_finder.h [modify] https://crrev.com/174ef718eaf904b8f149cc4667c2a8ab5b4ca9b9/third_party/blink/renderer/core/editing/finder/text_finder_test.cc [modify] https://crrev.com/174ef718eaf904b8f149cc4667c2a8ab5b4ca9b9/third_party/blink/renderer/core/exported/web_frame_test.cc [modify] https://crrev.com/174ef718eaf904b8f149cc4667c2a8ab5b4ca9b9/third_party/blink/renderer/core/frame/find_in_page.cc [modify] https://crrev.com/174ef718eaf904b8f149cc4667c2a8ab5b4ca9b9/third_party/blink/renderer/core/frame/find_in_page.h [add] https://crrev.com/174ef718eaf904b8f149cc4667c2a8ab5b4ca9b9/third_party/blink/renderer/core/frame/find_in_page_test.cc [modify] https://crrev.com/174ef718eaf904b8f149cc4667c2a8ab5b4ca9b9/third_party/blink/renderer/core/frame/web_local_frame_impl.cc [modify] https://crrev.com/174ef718eaf904b8f149cc4667c2a8ab5b4ca9b9/third_party/blink/renderer/core/frame/web_local_frame_impl.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/da99726ec3945bed11ccbb6e5e115164e864af0e commit da99726ec3945bed11ccbb6e5e115164e864af0e Author: Rakina Zata Amni <rakina@chromium.org> Date: Mon May 14 15:59:36 2018 Mojoify FindInPage::GetNearestFindResult We are mojoifying browser<->renderer communication of Find-in-page. In this CL, we are converting the GetNearestFindResult function to mojo. Mojoifying doc: https://goo.gl/JenyGm Previous CLs: Mojoify FindInPage::FindMatchRects (parent of this CL) crrev.com/c/1049770 Add FindInPage mojo interface with ClearActiveFindMatch crrev.com/c/1027393 Future CLs: Mojoify other find-in-page functions Bug: 819919 Change-Id: Id4852ed3902128594f3a29f7aa55d80d7f1f9a06 Reviewed-on: https://chromium-review.googlesource.com/1051143 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#558329} [modify] https://crrev.com/da99726ec3945bed11ccbb6e5e115164e864af0e/content/browser/find_request_manager.cc [modify] https://crrev.com/da99726ec3945bed11ccbb6e5e115164e864af0e/content/browser/find_request_manager.h [modify] https://crrev.com/da99726ec3945bed11ccbb6e5e115164e864af0e/content/browser/web_contents/web_contents_impl.cc [modify] https://crrev.com/da99726ec3945bed11ccbb6e5e115164e864af0e/content/browser/web_contents/web_contents_impl.h [modify] https://crrev.com/da99726ec3945bed11ccbb6e5e115164e864af0e/content/common/frame_messages.h [modify] https://crrev.com/da99726ec3945bed11ccbb6e5e115164e864af0e/content/renderer/render_frame_impl.cc [modify] https://crrev.com/da99726ec3945bed11ccbb6e5e115164e864af0e/content/renderer/render_frame_impl.h [modify] https://crrev.com/da99726ec3945bed11ccbb6e5e115164e864af0e/third_party/blink/public/mojom/frame/find_in_page.mojom [modify] https://crrev.com/da99726ec3945bed11ccbb6e5e115164e864af0e/third_party/blink/public/web/web_local_frame.h [modify] https://crrev.com/da99726ec3945bed11ccbb6e5e115164e864af0e/third_party/blink/renderer/core/frame/find_in_page.cc [modify] https://crrev.com/da99726ec3945bed11ccbb6e5e115164e864af0e/third_party/blink/renderer/core/frame/find_in_page.h [modify] https://crrev.com/da99726ec3945bed11ccbb6e5e115164e864af0e/third_party/blink/renderer/core/frame/web_local_frame_impl.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/57bec36fc896c8050d3a2d20c1327591b38f13a0 commit 57bec36fc896c8050d3a2d20c1327591b38f13a0 Author: Rakina Zata Amni <rakina@chromium.org> Date: Tue May 22 06:05:10 2018 Mojoify FindInPage::ActivateNearestFindResult We are mojoifying browser<->renderer communication of Find-in-page. In this CL, we are converting the GetNearestFindResult function to mojo. Mojoifying doc: https://goo.gl/JenyGm Previous CLs: Mojoify FindInPage::GetNearestFindResult (parent of this CL) crrev.com/c/1051143 Mojoify FindInPage::FindMatchRects crrev.com/c/1049770 Add FindInPage mojo interface with ClearActiveFindMatch crrev.com/c/1027393 Future CLs: Mojoify other find-in-page functions Bug: 819919 Change-Id: I8f2d0bfcf6642dc43d7f5ab5e80ce6614e006647 Reviewed-on: https://chromium-review.googlesource.com/1051525 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#560494} [modify] https://crrev.com/57bec36fc896c8050d3a2d20c1327591b38f13a0/content/browser/find_request_manager.cc [modify] https://crrev.com/57bec36fc896c8050d3a2d20c1327591b38f13a0/content/browser/find_request_manager.h [modify] https://crrev.com/57bec36fc896c8050d3a2d20c1327591b38f13a0/content/common/frame_messages.h [modify] https://crrev.com/57bec36fc896c8050d3a2d20c1327591b38f13a0/content/renderer/render_frame_impl.cc [modify] https://crrev.com/57bec36fc896c8050d3a2d20c1327591b38f13a0/content/renderer/render_frame_impl.h [modify] https://crrev.com/57bec36fc896c8050d3a2d20c1327591b38f13a0/third_party/blink/public/mojom/frame/find_in_page.mojom [modify] https://crrev.com/57bec36fc896c8050d3a2d20c1327591b38f13a0/third_party/blink/public/web/web_local_frame.h [modify] https://crrev.com/57bec36fc896c8050d3a2d20c1327591b38f13a0/third_party/blink/renderer/core/editing/finder/text_finder.cc [modify] https://crrev.com/57bec36fc896c8050d3a2d20c1327591b38f13a0/third_party/blink/renderer/core/editing/finder/text_finder.h [modify] https://crrev.com/57bec36fc896c8050d3a2d20c1327591b38f13a0/third_party/blink/renderer/core/exported/web_frame_test.cc [modify] https://crrev.com/57bec36fc896c8050d3a2d20c1327591b38f13a0/third_party/blink/renderer/core/frame/find_in_page.cc [modify] https://crrev.com/57bec36fc896c8050d3a2d20c1327591b38f13a0/third_party/blink/renderer/core/frame/find_in_page.h [modify] https://crrev.com/57bec36fc896c8050d3a2d20c1327591b38f13a0/third_party/blink/renderer/core/frame/web_local_frame_impl.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8ebb380eaa05dce29283707df86679f5768f2c85 commit 8ebb380eaa05dce29283707df86679f5768f2c85 Author: Rakina Zata Amni <rakina@chromium.org> Date: Tue May 22 09:02:45 2018 Move plugin_find_handler_ from RenderFrameImpl to FindInPage Currently, RenderFrameImpl has a pointer to a PepperPluginInstanceImpl plugin_find_handler_, and Find-in-page requests such as Find or StopFinding that can be handled by a plugin will be forwarded to the plugin if possible. Since we are going to mojoify Find-in-page functions and remove them from RenderFrameImpl, we are moving plugin_find_handler_ to FindInPage. Mojoifying doc: https://goo.gl/JenyGm Bug: 819919 Change-Id: Ife0f336b82aa1f26243b4d14dc8f0cd906de7c3e Reviewed-on: https://chromium-review.googlesource.com/1056772 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#560518} [modify] https://crrev.com/8ebb380eaa05dce29283707df86679f5768f2c85/content/renderer/pepper/pepper_plugin_instance_impl.cc [modify] https://crrev.com/8ebb380eaa05dce29283707df86679f5768f2c85/content/renderer/render_frame_impl.cc [modify] https://crrev.com/8ebb380eaa05dce29283707df86679f5768f2c85/content/renderer/render_frame_impl.h [modify] https://crrev.com/8ebb380eaa05dce29283707df86679f5768f2c85/third_party/blink/public/web/web_local_frame.h [modify] https://crrev.com/8ebb380eaa05dce29283707df86679f5768f2c85/third_party/blink/public/web/web_plugin_container.h [modify] https://crrev.com/8ebb380eaa05dce29283707df86679f5768f2c85/third_party/blink/renderer/core/exported/web_frame_test.cc [modify] https://crrev.com/8ebb380eaa05dce29283707df86679f5768f2c85/third_party/blink/renderer/core/exported/web_plugin_container_impl.cc [modify] https://crrev.com/8ebb380eaa05dce29283707df86679f5768f2c85/third_party/blink/renderer/core/exported/web_plugin_container_impl.h [modify] https://crrev.com/8ebb380eaa05dce29283707df86679f5768f2c85/third_party/blink/renderer/core/frame/find_in_page.cc [modify] https://crrev.com/8ebb380eaa05dce29283707df86679f5768f2c85/third_party/blink/renderer/core/frame/find_in_page.h [modify] https://crrev.com/8ebb380eaa05dce29283707df86679f5768f2c85/third_party/blink/renderer/core/frame/find_in_page_test.cc [modify] https://crrev.com/8ebb380eaa05dce29283707df86679f5768f2c85/third_party/blink/renderer/core/frame/web_local_frame_impl.cc [modify] https://crrev.com/8ebb380eaa05dce29283707df86679f5768f2c85/third_party/blink/renderer/core/frame/web_local_frame_impl.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0ac91e13c4ee1096afd1f2ba4b81c2e837719190 commit 0ac91e13c4ee1096afd1f2ba4b81c2e837719190 Author: Rakina Zata Amni <rakina@chromium.org> Date: Thu May 24 11:46:57 2018 Mojoify FindInPage::StopFinding We are mojoifying browser<->renderer communication of Find-in-page. In this CL, we are converting the StopFinding function to mojo. Mojoifying doc: https://goo.gl/JenyGm Previous CLs: Mojoify FindInPage::ActivateNearestFindResult crrev.com/c/1051525 Mojoify FindInPage::GetNearestFindResult crrev.com/c/1051143 Mojoify FindInPage::FindMatchRects crrev.com/c/1049770 Add FindInPage mojo interface with ClearActiveFindMatch crrev.com/c/1027393 Future CLs: Mojoify FindInPage::Find Find-in-page APIs Bug: 819919 Change-Id: I00ba17b6e13d839ee4dbee9597e9f6ac0ea990e6 Reviewed-on: https://chromium-review.googlesource.com/1058731 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#561466} [modify] https://crrev.com/0ac91e13c4ee1096afd1f2ba4b81c2e837719190/content/browser/find_request_manager.cc [modify] https://crrev.com/0ac91e13c4ee1096afd1f2ba4b81c2e837719190/content/public/common/stop_find_action.h [modify] https://crrev.com/0ac91e13c4ee1096afd1f2ba4b81c2e837719190/content/renderer/render_frame_impl.cc [modify] https://crrev.com/0ac91e13c4ee1096afd1f2ba4b81c2e837719190/content/renderer/render_frame_impl.h [modify] https://crrev.com/0ac91e13c4ee1096afd1f2ba4b81c2e837719190/content/shell/test_runner/test_runner_for_specific_view.cc [modify] https://crrev.com/0ac91e13c4ee1096afd1f2ba4b81c2e837719190/third_party/blink/public/mojom/frame/find_in_page.mojom [modify] https://crrev.com/0ac91e13c4ee1096afd1f2ba4b81c2e837719190/third_party/blink/public/web/web_local_frame.h [modify] https://crrev.com/0ac91e13c4ee1096afd1f2ba4b81c2e837719190/third_party/blink/renderer/core/exported/web_frame_test.cc [modify] https://crrev.com/0ac91e13c4ee1096afd1f2ba4b81c2e837719190/third_party/blink/renderer/core/frame/find_in_page.cc [modify] https://crrev.com/0ac91e13c4ee1096afd1f2ba4b81c2e837719190/third_party/blink/renderer/core/frame/find_in_page.h [modify] https://crrev.com/0ac91e13c4ee1096afd1f2ba4b81c2e837719190/third_party/blink/renderer/core/frame/web_local_frame_impl.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/736a25cc4c9bf72d50b7f54c41dc00bf51255908 commit 736a25cc4c9bf72d50b7f54c41dc00bf51255908 Author: Rakina Zata Amni <rakina@chromium.org> Date: Fri Jul 06 08:17:25 2018 Rebind find_in_page_ pointer in RFH after error After a renderer crash, a reused RFH might still have a disconnected find_in_page_ pointer. This CL rebinds the RFH to the new renderer if that happens. Bug: 819919 Change-Id: Iaec9fdc5eec4a46cc5e81dd98a5492d090d8c12b Reviewed-on: https://chromium-review.googlesource.com/1075951 Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#572919} [modify] https://crrev.com/736a25cc4c9bf72d50b7f54c41dc00bf51255908/content/browser/frame_host/render_frame_host_impl.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/724f3efedd1a62dbb842c1a6f4ca3df0c7a3d57f commit 724f3efedd1a62dbb842c1a6f4ca3df0c7a3d57f Author: Rakina Zata Amni <rakina@chromium.org> Date: Mon Jul 23 03:19:46 2018 Introduce FindInPageClient, with SetNumberOfMatches and SetActiveMatch FindInPageClient is a per-frame client for FindInPage. FindRequestManager has a map of frame -> FindInPageClient. FindInPageClient manages per-frame number of matches, and also updates the global number of matches and the current active match rect and ordinal. In this CL, we are changing ActivateNearestFindResult to call methods on FindInPageClient instead of calling a callback. SetNumberOfMatches is called to update the corresponding frame's number of find-in-page matches and also update the total number of matches in a tab. SetActiveMatch updates the tab's active match rect and ordinal. When we mojoify FindInPage::Find, we'll use FindInPageClient to receive the find replies and remove FindRequestManager::OnFindReply. Mojoifying doc: https://goo.gl/JenyGm Previous CLs: Mojoify FindInPage::StopFinding crrev.com/c/1058731 (other CLs linked in the CL above) Bug: 819919 Change-Id: I25a6d81037655801db1b1337f335073f11aa7862 Reviewed-on: https://chromium-review.googlesource.com/1080568 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#577106} [modify] https://crrev.com/724f3efedd1a62dbb842c1a6f4ca3df0c7a3d57f/content/browser/BUILD.gn [add] https://crrev.com/724f3efedd1a62dbb842c1a6f4ca3df0c7a3d57f/content/browser/find_in_page_client.cc [add] https://crrev.com/724f3efedd1a62dbb842c1a6f4ca3df0c7a3d57f/content/browser/find_in_page_client.h [modify] https://crrev.com/724f3efedd1a62dbb842c1a6f4ca3df0c7a3d57f/content/browser/find_request_manager.cc [modify] https://crrev.com/724f3efedd1a62dbb842c1a6f4ca3df0c7a3d57f/content/browser/find_request_manager.h [modify] https://crrev.com/724f3efedd1a62dbb842c1a6f4ca3df0c7a3d57f/third_party/blink/public/mojom/frame/find_in_page.mojom [modify] https://crrev.com/724f3efedd1a62dbb842c1a6f4ca3df0c7a3d57f/third_party/blink/renderer/core/frame/find_in_page.cc [modify] https://crrev.com/724f3efedd1a62dbb842c1a6f4ca3df0c7a3d57f/third_party/blink/renderer/core/frame/find_in_page.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/97d82f88ff773400ba13df5357364e8f928f46fe commit 97d82f88ff773400ba13df5357364e8f928f46fe Author: Rakina Zata Amni <rakina@chromium.org> Date: Mon Jul 23 05:58:33 2018 Move ReportFindInPage{MatchCount,Selection} to FindInPage This CL moves ReportFindInPageMatchCount and ReportFindInPageSelection from RenderFrameImpl to FindInPage. This is done in preparation of mojoifying FindInPage::Find. ReportFindInPage{MatchCount,Selection} sends FindReply frame host messages through IPC for calls to the Find method. After mojoification, these functions will instead call SetNumberOfMatches/SetActiveMatch on FindInPageClient. We are moving them now to make the CL for the mojoification smaller/simpler. Mojoifying doc: https://goo.gl/JenyGm Previous CLs: Introduce FindInPageClient with SetNumberOfMatches and SetActiveMatch crrev.com/c/1080568 Mojoify FindInPage::StopFinding crrev.com/c/1058731 (other CLs linked in the CL above) Bug: 819919 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I2841d2841a44d1473d4118215cd7dd0f238ca001 Reviewed-on: https://chromium-review.googlesource.com/1097237 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#577112} [modify] https://crrev.com/97d82f88ff773400ba13df5357364e8f928f46fe/content/renderer/pepper/pepper_plugin_instance_impl.cc [modify] https://crrev.com/97d82f88ff773400ba13df5357364e8f928f46fe/content/renderer/render_frame_impl.cc [modify] https://crrev.com/97d82f88ff773400ba13df5357364e8f928f46fe/content/renderer/render_frame_impl.h [modify] https://crrev.com/97d82f88ff773400ba13df5357364e8f928f46fe/third_party/blink/public/web/web_local_frame.h [modify] https://crrev.com/97d82f88ff773400ba13df5357364e8f928f46fe/third_party/blink/public/web/web_local_frame_client.h [modify] https://crrev.com/97d82f88ff773400ba13df5357364e8f928f46fe/third_party/blink/renderer/core/editing/finder/text_finder.cc [modify] https://crrev.com/97d82f88ff773400ba13df5357364e8f928f46fe/third_party/blink/renderer/core/exported/web_frame_test.cc [modify] https://crrev.com/97d82f88ff773400ba13df5357364e8f928f46fe/third_party/blink/renderer/core/frame/find_in_page.cc [modify] https://crrev.com/97d82f88ff773400ba13df5357364e8f928f46fe/third_party/blink/renderer/core/frame/web_local_frame_impl.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fef811c5128c4c69d5cb45ba64ce33320d4067b0 commit fef811c5128c4c69d5cb45ba64ce33320d4067b0 Author: Rakina Zata Amni <rakina@chromium.org> Date: Tue Aug 14 05:45:12 2018 Mojoify FindInPage::Find We are mojoifying browser<->renderer communication of Find-in-page. In this CL, we are converting the Find function to mojo. Find replies are now separated into two functions, one to update the number of found matches (SetNumberOfMatches) and the other is to update which match is active right now (SetActiveMatch). This is the final function to be mojoified for FindInPage. Mojoifying doc: https://goo.gl/JenyGm Bug: 819919 Change-Id: I990160f973b29d7620214d7d58a16ece033adf3f Reviewed-on: https://chromium-review.googlesource.com/1086950 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#582841} [modify] https://crrev.com/fef811c5128c4c69d5cb45ba64ce33320d4067b0/content/browser/find_in_page_client.cc [modify] https://crrev.com/fef811c5128c4c69d5cb45ba64ce33320d4067b0/content/browser/find_in_page_client.h [modify] https://crrev.com/fef811c5128c4c69d5cb45ba64ce33320d4067b0/content/browser/find_request_manager.cc [modify] https://crrev.com/fef811c5128c4c69d5cb45ba64ce33320d4067b0/content/browser/find_request_manager.h [modify] https://crrev.com/fef811c5128c4c69d5cb45ba64ce33320d4067b0/content/browser/web_contents/web_contents_impl.cc [modify] https://crrev.com/fef811c5128c4c69d5cb45ba64ce33320d4067b0/content/browser/web_contents/web_contents_impl.h [modify] https://crrev.com/fef811c5128c4c69d5cb45ba64ce33320d4067b0/content/common/frame_messages.h [modify] https://crrev.com/fef811c5128c4c69d5cb45ba64ce33320d4067b0/content/renderer/render_frame_impl.cc [modify] https://crrev.com/fef811c5128c4c69d5cb45ba64ce33320d4067b0/content/renderer/render_frame_impl.h [modify] https://crrev.com/fef811c5128c4c69d5cb45ba64ce33320d4067b0/content/renderer/render_frame_impl_browsertest.cc [modify] https://crrev.com/fef811c5128c4c69d5cb45ba64ce33320d4067b0/third_party/blink/public/mojom/frame/find_in_page.mojom [modify] https://crrev.com/fef811c5128c4c69d5cb45ba64ce33320d4067b0/third_party/blink/public/web/web_local_frame.h [modify] https://crrev.com/fef811c5128c4c69d5cb45ba64ce33320d4067b0/third_party/blink/public/web/web_local_frame_client.h [modify] https://crrev.com/fef811c5128c4c69d5cb45ba64ce33320d4067b0/third_party/blink/renderer/core/exported/web_frame_test.cc [modify] https://crrev.com/fef811c5128c4c69d5cb45ba64ce33320d4067b0/third_party/blink/renderer/core/frame/find_in_page.cc [modify] https://crrev.com/fef811c5128c4c69d5cb45ba64ce33320d4067b0/third_party/blink/renderer/core/frame/find_in_page.h [modify] https://crrev.com/fef811c5128c4c69d5cb45ba64ce33320d4067b0/third_party/blink/renderer/core/frame/web_local_frame_impl.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fc0e1eac05c54aa7897be6763229cee418ed4557 commit fc0e1eac05c54aa7897be6763229cee418ed4557 Author: Makoto Shimazu <shimazu@chromium.org> Date: Tue Aug 14 08:12:52 2018 Revert "Mojoify FindInPage::Find" This reverts commit fef811c5128c4c69d5cb45ba64ce33320d4067b0. Reason for revert: SaveType/SavePageOriginalVsSavedComparisonTest.Style becomes flaky and findit suggested this is the culprit. Let me revert this speculatively and see if it'll be fixed. Original change's description: > Mojoify FindInPage::Find > > We are mojoifying browser<->renderer communication of Find-in-page. > In this CL, we are converting the Find function to mojo. Find replies > are now separated into two functions, one to update the number of > found matches (SetNumberOfMatches) and the other is to update which > match is active right now (SetActiveMatch). > > This is the final function to be mojoified for FindInPage. > Mojoifying doc: https://goo.gl/JenyGm > > Bug: 819919 > Change-Id: I990160f973b29d7620214d7d58a16ece033adf3f > Reviewed-on: https://chromium-review.googlesource.com/1086950 > Commit-Queue: Rakina Zata Amni <rakina@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#582841} TBR=dcheng@chromium.org,yosin@chromium.org,alexmos@chromium.org,rakina@chromium.org Change-Id: I0c48b0aed588049147f8cc49addaf1686fa67621 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 819919, 873965 Reviewed-on: https://chromium-review.googlesource.com/1173892 Reviewed-by: Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#582862} [modify] https://crrev.com/fc0e1eac05c54aa7897be6763229cee418ed4557/content/browser/find_in_page_client.cc [modify] https://crrev.com/fc0e1eac05c54aa7897be6763229cee418ed4557/content/browser/find_in_page_client.h [modify] https://crrev.com/fc0e1eac05c54aa7897be6763229cee418ed4557/content/browser/find_request_manager.cc [modify] https://crrev.com/fc0e1eac05c54aa7897be6763229cee418ed4557/content/browser/find_request_manager.h [modify] https://crrev.com/fc0e1eac05c54aa7897be6763229cee418ed4557/content/browser/web_contents/web_contents_impl.cc [modify] https://crrev.com/fc0e1eac05c54aa7897be6763229cee418ed4557/content/browser/web_contents/web_contents_impl.h [modify] https://crrev.com/fc0e1eac05c54aa7897be6763229cee418ed4557/content/common/frame_messages.h [modify] https://crrev.com/fc0e1eac05c54aa7897be6763229cee418ed4557/content/renderer/render_frame_impl.cc [modify] https://crrev.com/fc0e1eac05c54aa7897be6763229cee418ed4557/content/renderer/render_frame_impl.h [modify] https://crrev.com/fc0e1eac05c54aa7897be6763229cee418ed4557/content/renderer/render_frame_impl_browsertest.cc [modify] https://crrev.com/fc0e1eac05c54aa7897be6763229cee418ed4557/third_party/blink/public/mojom/frame/find_in_page.mojom [modify] https://crrev.com/fc0e1eac05c54aa7897be6763229cee418ed4557/third_party/blink/public/web/web_local_frame.h [modify] https://crrev.com/fc0e1eac05c54aa7897be6763229cee418ed4557/third_party/blink/public/web/web_local_frame_client.h [modify] https://crrev.com/fc0e1eac05c54aa7897be6763229cee418ed4557/third_party/blink/renderer/core/exported/web_frame_test.cc [modify] https://crrev.com/fc0e1eac05c54aa7897be6763229cee418ed4557/third_party/blink/renderer/core/frame/find_in_page.cc [modify] https://crrev.com/fc0e1eac05c54aa7897be6763229cee418ed4557/third_party/blink/renderer/core/frame/find_in_page.h [modify] https://crrev.com/fc0e1eac05c54aa7897be6763229cee418ed4557/third_party/blink/renderer/core/frame/web_local_frame_impl.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2ac5750560906b7b98e9c72178a088a2ce0c2404 commit 2ac5750560906b7b98e9c72178a088a2ce0c2404 Author: Rakina Zata Amni <rakina@chromium.org> Date: Thu Aug 16 01:44:45 2018 Reland "Mojoify FindInPage::Find" This reverts commit fc0e1eac05c54aa7897be6763229cee418ed4557 and adds a new function FindRequestManager::ShouldIgnoreReply. Previously the original CL wrongly removed a check to ignore stale Find replies (first part of FindRequestManager::OnFindReply). This makes some tests like FindInPageTest.CtrlEnter and SavePageOriginalVsSavedComparisonTest to become flaky. They fail when the stale replies arrives when the test hasn't ended yet. I returned the check in the form of a new function, FindRequestManager::ShouldIgnoreReply which is called by FindInPageClient::SetNumberOfMatches and FindInPageClient::SetActiveMatch. I've confirmed locally that the tests aren't flaky anymore by running them 50+ times. TBR=dcheng@chromium.org,yosin@chromium.org Bug: 819919 Change-Id: I4482a5961854ce7b3477623f204fa93c0bd79a0c Reviewed-on: https://chromium-review.googlesource.com/1174207 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by: Rakina Zata Amni <rakina@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#583489} [modify] https://crrev.com/2ac5750560906b7b98e9c72178a088a2ce0c2404/content/browser/find_in_page_client.cc [modify] https://crrev.com/2ac5750560906b7b98e9c72178a088a2ce0c2404/content/browser/find_in_page_client.h [modify] https://crrev.com/2ac5750560906b7b98e9c72178a088a2ce0c2404/content/browser/find_request_manager.cc [modify] https://crrev.com/2ac5750560906b7b98e9c72178a088a2ce0c2404/content/browser/find_request_manager.h [modify] https://crrev.com/2ac5750560906b7b98e9c72178a088a2ce0c2404/content/browser/web_contents/web_contents_impl.cc [modify] https://crrev.com/2ac5750560906b7b98e9c72178a088a2ce0c2404/content/browser/web_contents/web_contents_impl.h [modify] https://crrev.com/2ac5750560906b7b98e9c72178a088a2ce0c2404/content/common/frame_messages.h [modify] https://crrev.com/2ac5750560906b7b98e9c72178a088a2ce0c2404/content/renderer/render_frame_impl.cc [modify] https://crrev.com/2ac5750560906b7b98e9c72178a088a2ce0c2404/content/renderer/render_frame_impl.h [modify] https://crrev.com/2ac5750560906b7b98e9c72178a088a2ce0c2404/content/renderer/render_frame_impl_browsertest.cc [modify] https://crrev.com/2ac5750560906b7b98e9c72178a088a2ce0c2404/third_party/blink/public/mojom/frame/find_in_page.mojom [modify] https://crrev.com/2ac5750560906b7b98e9c72178a088a2ce0c2404/third_party/blink/public/web/web_local_frame.h [modify] https://crrev.com/2ac5750560906b7b98e9c72178a088a2ce0c2404/third_party/blink/public/web/web_local_frame_client.h [modify] https://crrev.com/2ac5750560906b7b98e9c72178a088a2ce0c2404/third_party/blink/renderer/core/exported/web_frame_test.cc [modify] https://crrev.com/2ac5750560906b7b98e9c72178a088a2ce0c2404/third_party/blink/renderer/core/frame/find_in_page.cc [modify] https://crrev.com/2ac5750560906b7b98e9c72178a088a2ce0c2404/third_party/blink/renderer/core/frame/find_in_page.h [modify] https://crrev.com/2ac5750560906b7b98e9c72178a088a2ce0c2404/third_party/blink/renderer/core/frame/web_local_frame_impl.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/95e734f7948caa8985ade3a2b66e0960b035b330 commit 95e734f7948caa8985ade3a2b66e0960b035b330 Author: Rakina Zata Amni <rakina@chromium.org> Date: Thu Aug 16 05:14:00 2018 Remove word_start and medial_capital_as_word_start from WebFindOptions The options |word_start| and |medial_capital_as_word_start| are never really used in the browser's find-in-page (the only usage of it is in a layout test). This CL removes the options and corresponding code and test. Bug: 819919 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I19d9edc19096a59d7204b42def9ed99a93af8860 Reviewed-on: https://chromium-review.googlesource.com/1175645 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#583545} [modify] https://crrev.com/95e734f7948caa8985ade3a2b66e0960b035b330/content/browser/find_request_manager.cc [modify] https://crrev.com/95e734f7948caa8985ade3a2b66e0960b035b330/content/shell/test_runner/test_runner_for_specific_view.cc [modify] https://crrev.com/95e734f7948caa8985ade3a2b66e0960b035b330/third_party/WebKit/LayoutTests/editing/text-iterator/findString-expected.txt [modify] https://crrev.com/95e734f7948caa8985ade3a2b66e0960b035b330/third_party/WebKit/LayoutTests/editing/text-iterator/findString.html [modify] https://crrev.com/95e734f7948caa8985ade3a2b66e0960b035b330/third_party/blink/public/mojom/frame/find_in_page.mojom [modify] https://crrev.com/95e734f7948caa8985ade3a2b66e0960b035b330/third_party/blink/public/web/web_find_options.h [modify] https://crrev.com/95e734f7948caa8985ade3a2b66e0960b035b330/third_party/blink/renderer/core/editing/finder/find_options.h [modify] https://crrev.com/95e734f7948caa8985ade3a2b66e0960b035b330/third_party/blink/renderer/core/editing/finder/text_finder.cc [modify] https://crrev.com/95e734f7948caa8985ade3a2b66e0960b035b330/third_party/blink/renderer/core/editing/iterators/search_buffer.cc [modify] https://crrev.com/95e734f7948caa8985ade3a2b66e0960b035b330/third_party/blink/renderer/core/editing/iterators/search_buffer.h [modify] https://crrev.com/95e734f7948caa8985ade3a2b66e0960b035b330/third_party/blink/renderer/core/frame/find_in_page.cc [modify] https://crrev.com/95e734f7948caa8985ade3a2b66e0960b035b330/third_party/blink/renderer/core/frame/local_dom_window.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/03eb8f0572af600e0004316d78a92bc8aeb7dfa9 commit 03eb8f0572af600e0004316d78a92bc8aeb7dfa9 Author: Rakina Zata Amni <rakina@chromium.org> Date: Thu Aug 16 23:25:19 2018 Remove WebLocalFrame::ReportFindInPage{MatchCount,Selection} WebLocalFrame::ReportFindInPageMatchCount and ReportFindInPageSelection are only called by plugin code. This CL changes the plugin code to call those functions on FindInPage directly and removes the functions. Bug: 819919 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I5df288ac6ce934ec0f6b27b47c17025005a73bad Reviewed-on: https://chromium-review.googlesource.com/1176898 Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#583877} [modify] https://crrev.com/03eb8f0572af600e0004316d78a92bc8aeb7dfa9/content/renderer/pepper/pepper_plugin_instance_impl.cc [modify] https://crrev.com/03eb8f0572af600e0004316d78a92bc8aeb7dfa9/third_party/blink/public/web/web_local_frame.h [modify] https://crrev.com/03eb8f0572af600e0004316d78a92bc8aeb7dfa9/third_party/blink/public/web/web_plugin_container.h [modify] https://crrev.com/03eb8f0572af600e0004316d78a92bc8aeb7dfa9/third_party/blink/renderer/core/editing/finder/text_finder.cc [modify] https://crrev.com/03eb8f0572af600e0004316d78a92bc8aeb7dfa9/third_party/blink/renderer/core/exported/web_plugin_container_impl.cc [modify] https://crrev.com/03eb8f0572af600e0004316d78a92bc8aeb7dfa9/third_party/blink/renderer/core/exported/web_plugin_container_impl.h [modify] https://crrev.com/03eb8f0572af600e0004316d78a92bc8aeb7dfa9/third_party/blink/renderer/core/frame/find_in_page.cc [modify] https://crrev.com/03eb8f0572af600e0004316d78a92bc8aeb7dfa9/third_party/blink/renderer/core/frame/web_local_frame_impl.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/77b7a4f04f24d19c86d357c3f3170525b912d8aa commit 77b7a4f04f24d19c86d357c3f3170525b912d8aa Author: Rakina Zata Amni <rakina@chromium.org> Date: Tue Aug 28 16:40:55 2018 Set FocusedFrame on RFH's associated WebContents in FindRequestManager Currently we call on the RFH's associated WebContents' focused WebContents instead. Bug: 819919,876890 Change-Id: Ia97f60cb524322fe3f2566ffa8f6ba86eeddcf90 Reviewed-on: https://chromium-review.googlesource.com/1192665 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#586742} [modify] https://crrev.com/77b7a4f04f24d19c86d357c3f3170525b912d8aa/content/browser/find_request_manager.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3f77dff94c7113d430fd06965b0da34a2d626a29 commit 3f77dff94c7113d430fd06965b0da34a2d626a29 Author: Rakina Zata Amni <rakina@chromium.org> Date: Sat Sep 08 16:19:43 2018 Remove WebFindOptions in browser process This CL removes usage of WebFindOptions in browser process, in favor of FindOptions, defined in find_in_page.mojom Bug: 819919 Change-Id: Iee85e1a277a225765dc5bb9f990b5bb5854efa04 Reviewed-on: https://chromium-review.googlesource.com/1184594 Reviewed-by: Fady Samuel <fsamuel@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Bo <boliu@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#589783} [modify] https://crrev.com/3f77dff94c7113d430fd06965b0da34a2d626a29/android_webview/browser/DEPS [modify] https://crrev.com/3f77dff94c7113d430fd06965b0da34a2d626a29/android_webview/browser/find_helper.cc [modify] https://crrev.com/3f77dff94c7113d430fd06965b0da34a2d626a29/chrome/browser/chrome_find_request_manager_browsertest.cc [modify] https://crrev.com/3f77dff94c7113d430fd06965b0da34a2d626a29/chrome/browser/ui/find_bar/find_tab_helper.cc [modify] https://crrev.com/3f77dff94c7113d430fd06965b0da34a2d626a29/content/browser/download/mhtml_generation_browsertest.cc [modify] https://crrev.com/3f77dff94c7113d430fd06965b0da34a2d626a29/content/browser/find_request_manager.cc [modify] https://crrev.com/3f77dff94c7113d430fd06965b0da34a2d626a29/content/browser/find_request_manager.h [modify] https://crrev.com/3f77dff94c7113d430fd06965b0da34a2d626a29/content/browser/find_request_manager_browsertest.cc [modify] https://crrev.com/3f77dff94c7113d430fd06965b0da34a2d626a29/content/browser/web_contents/web_contents_impl.cc [modify] https://crrev.com/3f77dff94c7113d430fd06965b0da34a2d626a29/content/browser/web_contents/web_contents_impl.h [modify] https://crrev.com/3f77dff94c7113d430fd06965b0da34a2d626a29/content/public/browser/web_contents.h [modify] https://crrev.com/3f77dff94c7113d430fd06965b0da34a2d626a29/extensions/browser/api/guest_view/web_view/web_view_internal_api.cc [modify] https://crrev.com/3f77dff94c7113d430fd06965b0da34a2d626a29/extensions/browser/guest_view/web_view/web_view_find_helper.cc [modify] https://crrev.com/3f77dff94c7113d430fd06965b0da34a2d626a29/extensions/browser/guest_view/web_view/web_view_find_helper.h [modify] https://crrev.com/3f77dff94c7113d430fd06965b0da34a2d626a29/extensions/browser/guest_view/web_view/web_view_guest.cc [modify] https://crrev.com/3f77dff94c7113d430fd06965b0da34a2d626a29/extensions/browser/guest_view/web_view/web_view_guest.h [modify] https://crrev.com/3f77dff94c7113d430fd06965b0da34a2d626a29/third_party/blink/public/mojom/frame/find_in_page.mojom
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/02a96bb593dc511dd674884fec8fc4bcd9469aa4 commit 02a96bb593dc511dd674884fec8fc4bcd9469aa4 Author: Rakina Zata Amni <rakina@chromium.org> Date: Thu Sep 27 06:42:45 2018 Remove WebFindOptions & StopFindingForTesting This CL removes WebFindOptions in favor of FindOptions defined in find_in_page.mojom. This also removes WebLocalFrame::Find and WebLocalFrame::StopFindingForTesting, combining both into just one function WebLocalFrame::FindForTesting. Bug: 819919 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ie904a02b3e197f1012c6d5b4c9f50fdb6ce8d14f Reviewed-on: https://chromium-review.googlesource.com/1184808 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#594614} [modify] https://crrev.com/02a96bb593dc511dd674884fec8fc4bcd9469aa4/android_webview/browser/DEPS [modify] https://crrev.com/02a96bb593dc511dd674884fec8fc4bcd9469aa4/chrome/browser/DEPS [modify] https://crrev.com/02a96bb593dc511dd674884fec8fc4bcd9469aa4/content/browser/DEPS [modify] https://crrev.com/02a96bb593dc511dd674884fec8fc4bcd9469aa4/content/common/DEPS [modify] https://crrev.com/02a96bb593dc511dd674884fec8fc4bcd9469aa4/content/common/frame_messages.h [modify] https://crrev.com/02a96bb593dc511dd674884fec8fc4bcd9469aa4/content/renderer/render_frame_impl_browsertest.cc [modify] https://crrev.com/02a96bb593dc511dd674884fec8fc4bcd9469aa4/content/shell/test_runner/test_runner.cc [modify] https://crrev.com/02a96bb593dc511dd674884fec8fc4bcd9469aa4/content/shell/test_runner/test_runner_for_specific_view.cc [modify] https://crrev.com/02a96bb593dc511dd674884fec8fc4bcd9469aa4/extensions/browser/api/guest_view/web_view/web_view_internal_api.cc [modify] https://crrev.com/02a96bb593dc511dd674884fec8fc4bcd9469aa4/third_party/blink/public/BUILD.gn [delete] https://crrev.com/cce901d273a01fbcac8e169cc869bb17c96f8de8/third_party/blink/public/web/web_find_options.h [modify] https://crrev.com/02a96bb593dc511dd674884fec8fc4bcd9469aa4/third_party/blink/public/web/web_local_frame.h [modify] https://crrev.com/02a96bb593dc511dd674884fec8fc4bcd9469aa4/third_party/blink/renderer/core/editing/finder/text_finder.cc [modify] https://crrev.com/02a96bb593dc511dd674884fec8fc4bcd9469aa4/third_party/blink/renderer/core/editing/finder/text_finder.h [modify] https://crrev.com/02a96bb593dc511dd674884fec8fc4bcd9469aa4/third_party/blink/renderer/core/editing/finder/text_finder_test.cc [modify] https://crrev.com/02a96bb593dc511dd674884fec8fc4bcd9469aa4/third_party/blink/renderer/core/exported/web_frame_test.cc [modify] https://crrev.com/02a96bb593dc511dd674884fec8fc4bcd9469aa4/third_party/blink/renderer/core/frame/find_in_page.cc [modify] https://crrev.com/02a96bb593dc511dd674884fec8fc4bcd9469aa4/third_party/blink/renderer/core/frame/find_in_page.h [modify] https://crrev.com/02a96bb593dc511dd674884fec8fc4bcd9469aa4/third_party/blink/renderer/core/frame/find_in_page_test.cc [modify] https://crrev.com/02a96bb593dc511dd674884fec8fc4bcd9469aa4/third_party/blink/renderer/core/frame/web_local_frame_impl.h [modify] https://crrev.com/02a96bb593dc511dd674884fec8fc4bcd9469aa4/third_party/blink/renderer/core/page/scrolling/scroll_into_view_test.cc
Comment 1 by bugdroid1@chromium.org
, Mar 16 2018