New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 819916 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug
Proj-Servicification

Blocking:
issue 816684



Sign in to add a comment

Chrome crashes when accessing youtube.com

Project Member Reported by lethalantidote@chromium.org, Mar 8 2018

Issue description

Chrome Version: 67.0.3365.0 (Developer Build) (64-bit)
OS: Linux, Rodete 

What steps will reproduce the problem?
(1) Run Chrome.
(2) Go to youtube.com.

What is the expected result?
Youtube.com shows up on screen.

What happens instead?
Crash: 

[225599:225599:0307/194536.827033:FATAL:optional.h(592)] Check failed: storage_.is_populated_. 
#0 0x7f5ba3f546ad base::debug::StackTrace::StackTrace()
#1 0x7f5ba3f52b9c base::debug::StackTrace::StackTrace()
#2 0x7f5ba3fdabca logging::LogMessage::~LogMessage()
#3 0x5633e56020b0 _ZNR4base8OptionalIN12media_router28HangoutsMediaStatusExtraDataEE5valueEv
#4 0x5633e5abeaa5 _ZNR4base8OptionalIN3gpu7MailboxEEdeEv
#5 0x5633e9c9dec7 safe_browsing::ClientSideDetectionHost::SubresourceResponseStarted()
#6 0x7f5b9eaab32e content::WebContentsImpl::SubresourceResponseStarted()
#7 0x7f5b9e1adf5b content::RenderFrameHostImpl::SubresourceResponseStarted()
#8 0x7f5b9cf46075 content::mojom::FrameHostStubDispatch::Accept()
#9 0x7f5b9e1d94c3 content::mojom::FrameHostStub<>::Accept()
#10 0x7f5ba23e9b98 mojo::InterfaceEndpointClient::HandleValidatedMessage()
#11 0x7f5ba23e8601 mojo::InterfaceEndpointClient::HandleIncomingMessageThunk::Accept()
#12 0x7f5ba23e6ab2 mojo::FilterChain::Accept()
#13 0x7f5ba23ec7a5 mojo::InterfaceEndpointClient::HandleIncomingMessage()
#14 0x7f5ba2268e05 IPC::(anonymous namespace)::ChannelAssociatedGroupController::AcceptOnProxyThread()
#15 0x7f5ba2260030 _ZN4base8internal13FunctorTraitsIMN3IPC12_GLOBAL__N_132ChannelAssociatedGroupControllerEFvN4mojo7MessageEEvE6InvokeIRK13scoped_refptrIS4_EJS6_EEEvS8_OT_DpOT0_
#16 0x7f5ba225feef _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKMN3IPC12_GLOBAL__N_132ChannelAssociatedGroupControllerEFvN4mojo7MessageEEJRK13scoped_refptrIS6_ES8_EEEvOT_DpOT0_
#17 0x7f5ba225fe55 _ZN4base8internal7InvokerINS0_9BindStateIMN3IPC12_GLOBAL__N_132ChannelAssociatedGroupControllerEFvN4mojo7MessageEEJ13scoped_refptrIS5_ENS0_13PassedWrapperIS7_EEEEEFvvEE7RunImplIRKS9_RKNSt3__15tupleIJSB_SD_EEEJLm0ELm1EEEEvOT_OT0_NSK_16integer_sequenceImJXspT1_EEEE
#18 0x7f5ba225fd0c _ZN4base8internal7InvokerINS0_9BindStateIMN3IPC12_GLOBAL__N_132ChannelAssociatedGroupControllerEFvN4mojo7MessageEEJ13scoped_refptrIS5_ENS0_13PassedWrapperIS7_EEEEEFvvEE3RunEPNS0_13BindStateBaseE
#19 0x7f5ba3f031b1 _ZNO4base12OnceCallbackIFvvEE3RunEv
#20 0x7f5ba3f585ef base::debug::TaskAnnotator::RunTask()
#21 0x7f5ba3ff73c9 base::internal::IncomingTaskQueue::RunTask()
#22 0x7f5ba400078b base::MessageLoop::RunTask()
#23 0x7f5ba4000a28 base::MessageLoop::DeferOrRunPendingTask()
#24 0x7f5ba4000d38 base::MessageLoop::DoWork()
#25 0x7f5ba4003a36 base::MessagePumpGlib::Run()
#26 0x7f5ba3ffff4c base::MessageLoop::Run()
#27 0x7f5ba40b666d base::RunLoop::Run()
#28 0x5633e62b7431 ChromeBrowserMainParts::MainMessageLoopRun()
#29 0x7f5b9dd3dde1 content::BrowserMainLoop::RunMainMessageLoopParts()
#30 0x7f5b9dd46ed0 content::BrowserMainRunnerImpl::Run()
#31 0x7f5b9dd31a33 content::BrowserMain()
#32 0x7f5b9fa3f197 content::RunNamedProcessTypeMain()
#33 0x7f5b9fa41a44 content::ContentMainRunnerImpl::Run()
#34 0x7f5b9fa38d35 content::ContentServiceManagerMainDelegate::RunEmbedderProcess()
#35 0x7f5ba4764e3c service_manager::Main()
#36 0x7f5b9fa3df5b content::ContentMain()
#37 0x5633e47e0240 ChromeMain
#38 0x5633e47e0152 main
#39 0x7f5b892562b1 __libc_start_main
#40 0x5633e47e002a _start

Received signal 6
#0 0x7f5ba3f546ad base::debug::StackTrace::StackTrace()
#1 0x7f5ba3f52b9c base::debug::StackTrace::StackTrace()
#2 0x7f5ba3f54075 base::debug::(anonymous namespace)::StackDumpSignalHandler()
#3 0x7f5ba44b30c0 <unknown>
#4 0x7f5b89268fcf gsignal
#5 0x7f5b8926a3fa abort
#6 0x7f5ba3f4fc56 base::debug::(anonymous namespace)::DebugBreak()
#7 0x7f5ba3f4fc38 base::debug::BreakDebugger()
#8 0x7f5ba3fdb9a5 logging::LogMessage::~LogMessage()
#9 0x5633e56020b0 _ZNR4base8OptionalIN12media_router28HangoutsMediaStatusExtraDataEE5valueEv
#10 0x5633e5abeaa5 _ZNR4base8OptionalIN3gpu7MailboxEEdeEv
#11 0x5633e9c9dec7 safe_browsing::ClientSideDetectionHost::SubresourceResponseStarted()
#12 0x7f5b9eaab32e content::WebContentsImpl::SubresourceResponseStarted()
#13 0x7f5b9e1adf5b content::RenderFrameHostImpl::SubresourceResponseStarted()
#14 0x7f5b9cf46075 content::mojom::FrameHostStubDispatch::Accept()
#15 0x7f5b9e1d94c3 content::mojom::FrameHostStub<>::Accept()
#16 0x7f5ba23e9b98 mojo::InterfaceEndpointClient::HandleValidatedMessage()
#17 0x7f5ba23e8601 mojo::InterfaceEndpointClient::HandleIncomingMessageThunk::Accept()
#18 0x7f5ba23e6ab2 mojo::FilterChain::Accept()
#19 0x7f5ba23ec7a5 mojo::InterfaceEndpointClient::HandleIncomingMessage()
#20 0x7f5ba2268e05 IPC::(anonymous namespace)::ChannelAssociatedGroupController::AcceptOnProxyThread()
#21 0x7f5ba2260030 _ZN4base8internal13FunctorTraitsIMN3IPC12_GLOBAL__N_132ChannelAssociatedGroupControllerEFvN4mojo7MessageEEvE6InvokeIRK13scoped_refptrIS4_EJS6_EEEvS8_OT_DpOT0_
#22 0x7f5ba225feef _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKMN3IPC12_GLOBAL__N_132ChannelAssociatedGroupControllerEFvN4mojo7MessageEEJRK13scoped_refptrIS6_ES8_EEEvOT_DpOT0_
#23 0x7f5ba225fe55 _ZN4base8internal7InvokerINS0_9BindStateIMN3IPC12_GLOBAL__N_132ChannelAssociatedGroupControllerEFvN4mojo7MessageEEJ13scoped_refptrIS5_ENS0_13PassedWrapperIS7_EEEEEFvvEE7RunImplIRKS9_RKNSt3__15tupleIJSB_SD_EEEJLm0ELm1EEEEvOT_OT0_NSK_16integer_sequenceImJXspT1_EEEE
#24 0x7f5ba225fd0c _ZN4base8internal7InvokerINS0_9BindStateIMN3IPC12_GLOBAL__N_132ChannelAssociatedGroupControllerEFvN4mojo7MessageEEJ13scoped_refptrIS5_ENS0_13PassedWrapperIS7_EEEEEFvvEE3RunEPNS0_13BindStateBaseE
#25 0x7f5ba3f031b1 _ZNO4base12OnceCallbackIFvvEE3RunEv
#26 0x7f5ba3f585ef base::debug::TaskAnnotator::RunTask()
#27 0x7f5ba3ff73c9 base::internal::IncomingTaskQueue::RunTask()
#28 0x7f5ba400078b base::MessageLoop::RunTask()
#29 0x7f5ba4000a28 base::MessageLoop::DeferOrRunPendingTask()
#30 0x7f5ba4000d38 base::MessageLoop::DoWork()
#31 0x7f5ba4003a36 base::MessagePumpGlib::Run()
#32 0x7f5ba3ffff4c base::MessageLoop::Run()
#33 0x7f5ba40b666d base::RunLoop::Run()
#34 0x5633e62b7431 ChromeBrowserMainParts::MainMessageLoopRun()
#35 0x7f5b9dd3dde1 content::BrowserMainLoop::RunMainMessageLoopParts()
#36 0x7f5b9dd46ed0 content::BrowserMainRunnerImpl::Run()
#37 0x7f5b9dd31a33 content::BrowserMain()
#38 0x7f5b9fa3f197 content::RunNamedProcessTypeMain()
#39 0x7f5b9fa41a44 content::ContentMainRunnerImpl::Run()
#40 0x7f5b9fa38d35 content::ContentServiceManagerMainDelegate::RunEmbedderProcess()
#41 0x7f5ba4764e3c service_manager::Main()
#42 0x7f5b9fa3df5b content::ContentMain()
#43 0x5633e47e0240 ChromeMain
#44 0x5633e47e0152 main
#45 0x7f5b892562b1 __libc_start_main
#46 0x5633e47e002a _start
  r8: 0000000000000000  r9: 00007ffe4bbb8a60 r10: 0000000000000008 r11: 0000000000000246
 r12: 00005633e47e0000 r13: 00007ffe4bbbf920 r14: 0000000000000000 r15: 0000000000000000
  di: 0000000000000002  si: 00007ffe4bbb8a60  bp: 00007ffe4bbb8ca0  bx: 0000000000000006
  dx: 0000000000000000  ax: 0000000000000000  cx: 00007f5b89268fcf  sp: 00007ffe4bbb8ad8
  ip: 00007f5b89268fcf efl: 0000000000000246 cgf: 002b000000000033 erf: 0000000000000000
 trp: 0000000000000000 msk: 0000000000000000 cr2: 0000000000000000
[end of stack trace]
Calling _exit(1). Core file will not be generated.

 
Blocking: 816684
Owner: cco3@chromium.org
Status: Assigned (was: Untriaged)
I am also seeing this on ToT. It crashes constantly on some other media sites too.

I think it's caused by 7a87490bda575dd8b28b7b863e2dbf38057feffe

https://chromium-review.googlesource.com/947582

I reverted the CL locally and the crash disappeared.

I suggest we revert that CL to unblock other developers, and allow more time for cco3@ to investigate and work on the proper fix.
Components: -Internals>Media Internals>Services>Network
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/badc08ce7857dd34f5460da498c98ddde2af986c

commit badc08ce7857dd34f5460da498c98ddde2af986c
Author: Xiaohan Wang <xhwang@chromium.org>
Date: Thu Mar 08 07:14:42 2018

Revert "Add a SubresourceLoadInfo struct to content/"

This reverts commit 7a87490bda575dd8b28b7b863e2dbf38057feffe.

Reason for revert: Crash. See  crbug.com/819916 

Original change's description:
> Add a SubresourceLoadInfo struct to content/
> 
> This data type is useful for sending stats from the renderer to the
> browser, in SubresourceResponseStarted methods.  Currently there are six
> fields that are passed around, but soon there may be more in order to
> get PageLoadMetrics working with the Network Service.
> 
> BUG=816684
> 
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
> Change-Id: I26a62ebb5aa82f225a70fe54098433c5c3342941
> Reviewed-on: https://chromium-review.googlesource.com/947582
> Commit-Queue: Conley Owens <cco3@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Reviewed-by: Jay Civelli <jcivelli@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#541550}

TBR=dcheng@chromium.org,jcivelli@chromium.org,jam@chromium.org,cco3@chromium.org

Change-Id: I48effa0d5a7407dfbbaf41d5d1708a1491f31639
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 816684, 819916 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/954588
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541746}
[modify] https://crrev.com/badc08ce7857dd34f5460da498c98ddde2af986c/chrome/browser/safe_browsing/client_side_detection_host.cc
[modify] https://crrev.com/badc08ce7857dd34f5460da498c98ddde2af986c/chrome/browser/safe_browsing/client_side_detection_host.h
[modify] https://crrev.com/badc08ce7857dd34f5460da498c98ddde2af986c/content/browser/frame_host/render_frame_host_delegate.h
[modify] https://crrev.com/badc08ce7857dd34f5460da498c98ddde2af986c/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/badc08ce7857dd34f5460da498c98ddde2af986c/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/badc08ce7857dd34f5460da498c98ddde2af986c/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/badc08ce7857dd34f5460da498c98ddde2af986c/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/badc08ce7857dd34f5460da498c98ddde2af986c/content/common/frame.mojom
[modify] https://crrev.com/badc08ce7857dd34f5460da498c98ddde2af986c/content/public/browser/web_contents_observer.h
[modify] https://crrev.com/badc08ce7857dd34f5460da498c98ddde2af986c/content/public/common/BUILD.gn
[delete] https://crrev.com/c2b84ad191135be504a0abf4860b97b59f9d8b52/content/public/common/subresource_load_info.mojom
[modify] https://crrev.com/badc08ce7857dd34f5460da498c98ddde2af986c/content/renderer/loader/resource_dispatcher.cc
[modify] https://crrev.com/badc08ce7857dd34f5460da498c98ddde2af986c/content/test/test_render_frame.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a78fab4b64ddcb5efa12d254c9e128e3247ba8a

commit 7a78fab4b64ddcb5efa12d254c9e128e3247ba8a
Author: Conley Owens <cco3@chromium.org>
Date: Sat Mar 10 06:27:49 2018

Add a SubresourceLoadInfo struct to content/

This data type is useful for sending stats from the renderer to the
browser, in SubresourceResponseStarted methods.  Currently there are six
fields that are passed around, but soon there may be more in order to
get PageLoadMetrics working with the Network Service.

This reverts commit badc08ce7857dd34f5460da498c98ddde2af986c.

This fixes the problem with the previous change by ensuring we have an
IP address before attempting to update the ClientSideDetectionHost IP
map.

BUG=816684, 819916 ,820032

Change-Id: I24ebb230c5bd76a5d2a43b39e86aba7541386bec
Reviewed-on: https://chromium-review.googlesource.com/957802
Commit-Queue: Conley Owens <cco3@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542359}
[modify] https://crrev.com/7a78fab4b64ddcb5efa12d254c9e128e3247ba8a/chrome/browser/safe_browsing/client_side_detection_host.cc
[modify] https://crrev.com/7a78fab4b64ddcb5efa12d254c9e128e3247ba8a/chrome/browser/safe_browsing/client_side_detection_host.h
[modify] https://crrev.com/7a78fab4b64ddcb5efa12d254c9e128e3247ba8a/chrome/browser/safe_browsing/client_side_detection_host_unittest.cc
[modify] https://crrev.com/7a78fab4b64ddcb5efa12d254c9e128e3247ba8a/content/browser/frame_host/render_frame_host_delegate.h
[modify] https://crrev.com/7a78fab4b64ddcb5efa12d254c9e128e3247ba8a/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/7a78fab4b64ddcb5efa12d254c9e128e3247ba8a/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/7a78fab4b64ddcb5efa12d254c9e128e3247ba8a/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/7a78fab4b64ddcb5efa12d254c9e128e3247ba8a/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/7a78fab4b64ddcb5efa12d254c9e128e3247ba8a/content/common/frame.mojom
[modify] https://crrev.com/7a78fab4b64ddcb5efa12d254c9e128e3247ba8a/content/public/browser/web_contents_observer.h
[modify] https://crrev.com/7a78fab4b64ddcb5efa12d254c9e128e3247ba8a/content/public/common/BUILD.gn
[add] https://crrev.com/7a78fab4b64ddcb5efa12d254c9e128e3247ba8a/content/public/common/subresource_load_info.mojom
[modify] https://crrev.com/7a78fab4b64ddcb5efa12d254c9e128e3247ba8a/content/renderer/loader/resource_dispatcher.cc
[modify] https://crrev.com/7a78fab4b64ddcb5efa12d254c9e128e3247ba8a/content/test/test_render_frame.cc

Comment 5 by dxie@chromium.org, May 15 2018

Status: Fixed (was: Assigned)

Sign in to add a comment