show "Downloading..." toast in VR browsing
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b94554e623120e55121f8885aaafbbe39bfefbeb commit b94554e623120e55121f8885aaafbbe39bfefbeb Author: Biao She <bshe@chromium.org> Date: Thu Mar 29 00:30:36 2018 Support Android Toast view while in VR This is step 1 for supporting Toast. It currently make Toast.show a noop while in VR. Step 2 will properly show/cancel Toast while in VR. Bug: 819886 Change-Id: I8970690e6653edd76431b7634af7d673100b0125 Reviewed-on: https://chromium-review.googlesource.com/978396 Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Biao She <bshe@chromium.org> Cr-Commit-Position: refs/heads/master@{#546675} [modify] https://crrev.com/b94554e623120e55121f8885aaafbbe39bfefbeb/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java [add] https://crrev.com/b94554e623120e55121f8885aaafbbe39bfefbeb/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrToast.java [modify] https://crrev.com/b94554e623120e55121f8885aaafbbe39bfefbeb/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrUiWidgetFactory.java [modify] https://crrev.com/b94554e623120e55121f8885aaafbbe39bfefbeb/chrome/android/java_sources.gni [modify] https://crrev.com/b94554e623120e55121f8885aaafbbe39bfefbeb/ui/android/java/src/org/chromium/ui/widget/Toast.java [modify] https://crrev.com/b94554e623120e55121f8885aaafbbe39bfefbeb/ui/android/java/src/org/chromium/ui/widget/popups/UiWidgetFactory.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4a304be17b0a06832152231ff9b68ca7cd5b690c commit 4a304be17b0a06832152231ff9b68ca7cd5b690c Author: Biao She <bshe@chromium.org> Date: Thu Mar 29 22:25:41 2018 Support Android Toast view while in VR This CL depends on https://chromium-review.googlesource.com/c/chromium/src/+/978396 It extracts text from an Android Toast and shows the text in vr toast. Bug: 819886 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: If07e91f2f104f12ca44eb22fb661c0df2bc32bdc Reviewed-on: https://chromium-review.googlesource.com/985209 Commit-Queue: Biao She <bshe@chromium.org> Reviewed-by: Amirhossein Simjour <asimjour@chromium.org> Reviewed-by: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#546984} [modify] https://crrev.com/4a304be17b0a06832152231ff9b68ca7cd5b690c/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShell.java [modify] https://crrev.com/4a304be17b0a06832152231ff9b68ca7cd5b690c/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java [modify] https://crrev.com/4a304be17b0a06832152231ff9b68ca7cd5b690c/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java [modify] https://crrev.com/4a304be17b0a06832152231ff9b68ca7cd5b690c/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrToast.java [add] https://crrev.com/4a304be17b0a06832152231ff9b68ca7cd5b690c/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrToastManager.java [modify] https://crrev.com/4a304be17b0a06832152231ff9b68ca7cd5b690c/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrUiWidgetFactory.java [modify] https://crrev.com/4a304be17b0a06832152231ff9b68ca7cd5b690c/chrome/android/java_sources.gni [modify] https://crrev.com/4a304be17b0a06832152231ff9b68ca7cd5b690c/chrome/browser/android/vr/vr_shell.cc [modify] https://crrev.com/4a304be17b0a06832152231ff9b68ca7cd5b690c/chrome/browser/android/vr/vr_shell.h [modify] https://crrev.com/4a304be17b0a06832152231ff9b68ca7cd5b690c/chrome/browser/android/vr/vr_shell_gl.cc [modify] https://crrev.com/4a304be17b0a06832152231ff9b68ca7cd5b690c/chrome/browser/android/vr/vr_shell_gl.h [modify] https://crrev.com/4a304be17b0a06832152231ff9b68ca7cd5b690c/chrome/browser/vr/BUILD.gn [delete] https://crrev.com/18f298a3013cb8447400158faa6104254f680d95/chrome/browser/vr/elements/toast.cc [delete] https://crrev.com/18f298a3013cb8447400158faa6104254f680d95/chrome/browser/vr/elements/toast.h [modify] https://crrev.com/4a304be17b0a06832152231ff9b68ca7cd5b690c/chrome/browser/vr/elements/ui_element.cc [modify] https://crrev.com/4a304be17b0a06832152231ff9b68ca7cd5b690c/chrome/browser/vr/elements/ui_element.h [modify] https://crrev.com/4a304be17b0a06832152231ff9b68ca7cd5b690c/chrome/browser/vr/elements/ui_element_name.cc [modify] https://crrev.com/4a304be17b0a06832152231ff9b68ca7cd5b690c/chrome/browser/vr/elements/ui_element_name.h [modify] https://crrev.com/4a304be17b0a06832152231ff9b68ca7cd5b690c/chrome/browser/vr/model/color_scheme.cc [modify] https://crrev.com/4a304be17b0a06832152231ff9b68ca7cd5b690c/chrome/browser/vr/model/color_scheme.h [rename] https://crrev.com/4a304be17b0a06832152231ff9b68ca7cd5b690c/chrome/browser/vr/model/hosted_platform_ui.h [modify] https://crrev.com/4a304be17b0a06832152231ff9b68ca7cd5b690c/chrome/browser/vr/model/model.cc [modify] https://crrev.com/4a304be17b0a06832152231ff9b68ca7cd5b690c/chrome/browser/vr/model/model.h [add] https://crrev.com/4a304be17b0a06832152231ff9b68ca7cd5b690c/chrome/browser/vr/model/platform_toast.cc [add] https://crrev.com/4a304be17b0a06832152231ff9b68ca7cd5b690c/chrome/browser/vr/model/platform_toast.h [modify] https://crrev.com/4a304be17b0a06832152231ff9b68ca7cd5b690c/chrome/browser/vr/testapp/vr_test_context.cc [modify] https://crrev.com/4a304be17b0a06832152231ff9b68ca7cd5b690c/chrome/browser/vr/ui.cc [modify] https://crrev.com/4a304be17b0a06832152231ff9b68ca7cd5b690c/chrome/browser/vr/ui.h [modify] https://crrev.com/4a304be17b0a06832152231ff9b68ca7cd5b690c/chrome/browser/vr/ui_scene_constants.h [modify] https://crrev.com/4a304be17b0a06832152231ff9b68ca7cd5b690c/chrome/browser/vr/ui_scene_creator.cc [modify] https://crrev.com/4a304be17b0a06832152231ff9b68ca7cd5b690c/chrome/browser/vr/ui_scene_creator.h [modify] https://crrev.com/4a304be17b0a06832152231ff9b68ca7cd5b690c/chrome/browser/vr/ui_unittest.cc
Repro steps: (1) Launch https://permission.site (2) Click on the Auto Download button (3) Confirm the Download request. The new UI should appear above the page where the Permission icons are. "Downloading ..."
Comment 1 by ericde@google.com
, Mar 8 2018