VRB : <select> 2D UI support |
||||||||||||
Issue descriptionadd support for <select> to VR Browsing 2D UI.
,
Mar 23 2018
,
Mar 27 2018
going back and forth on reviews, should land this week.
,
Mar 30 2018
,
Apr 6 2018
this landed, right? if so can we mark Fixed?
,
Apr 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d8f8795eeda38afb930044a211c3d28193fc8709 commit d8f8795eeda38afb930044a211c3d28193fc8709 Author: Amirhossein Simjour <asimjour@chromium.org> Date: Thu Apr 12 03:17:25 2018 Update SelectPopupDialog to use UiWidgetFactory Instead of using AlertDialogs directly, SelectPopupDialog uses UiWidgetFactory to create a new AlertDialog. This change has no effect when UiWidgetFactory is not replaced with VrUiWidgetFactory. Bug: 819876 Change-Id: I362a08a77146eaae962d646124246542f7bfc2c4 Reviewed-on: https://chromium-review.googlesource.com/1008246 Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Cr-Commit-Position: refs/heads/master@{#550003} [modify] https://crrev.com/d8f8795eeda38afb930044a211c3d28193fc8709/content/public/android/java/src/org/chromium/content/browser/input/SelectPopupDialog.java [modify] https://crrev.com/d8f8795eeda38afb930044a211c3d28193fc8709/ui/android/java/src/org/chromium/ui/widget/UiWidgetFactory.java
,
Apr 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/57ce29bfb9f82673cbe1f43bbb199f0e316b1572 commit 57ce29bfb9f82673cbe1f43bbb199f0e316b1572 Author: Amirhossein Simjour <asimjour@chromium.org> Date: Thu Apr 12 22:21:51 2018 VR support for android.app.AlertDialogs This is used to support html <select> element when it uses Android AlertDialogs. Bug:819876 Change-Id: Ibe005b8227d623430e79a563521700258cc34d69 Reviewed-on: https://chromium-review.googlesource.com/1010479 Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Reviewed-by: Biao She <bshe@chromium.org> Cr-Commit-Position: refs/heads/master@{#550387} [add] https://crrev.com/57ce29bfb9f82673cbe1f43bbb199f0e316b1572/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrAlertDialog.java [modify] https://crrev.com/57ce29bfb9f82673cbe1f43bbb199f0e316b1572/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java [modify] https://crrev.com/57ce29bfb9f82673cbe1f43bbb199f0e316b1572/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrUiWidgetFactory.java [modify] https://crrev.com/57ce29bfb9f82673cbe1f43bbb199f0e316b1572/chrome/android/java_sources.gni
,
Apr 12 2018
,
Apr 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3324b05ba6b29425f9eec6c936b0b3658fabdff8 commit 3324b05ba6b29425f9eec6c936b0b3658fabdff8 Author: Amirhossein Simjour <asimjour@chromium.org> Date: Fri Apr 13 01:37:28 2018 VR: Remove suppression of select popup VR supports html select element, so the corresponding page popup doesn't need to be suppressed. Bug: 819876 Change-Id: Iac3cf7fbd7437cce27f3a265e95e3f0eb76c3e2c Reviewed-on: https://chromium-review.googlesource.com/1010782 Reviewed-by: Ian Vollick <vollick@chromium.org> Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Cr-Commit-Position: refs/heads/master@{#550462} [modify] https://crrev.com/3324b05ba6b29425f9eec6c936b0b3658fabdff8/third_party/blink/renderer/core/page/chrome_client_impl.cc [modify] https://crrev.com/3324b05ba6b29425f9eec6c936b0b3658fabdff8/third_party/blink/renderer/core/page/chrome_client_impl_test.cc
,
Apr 13 2018
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/57ce29bfb9f82673cbe1f43bbb199f0e316b1572 commit 57ce29bfb9f82673cbe1f43bbb199f0e316b1572 Author: Amirhossein Simjour <asimjour@chromium.org> Date: Thu Apr 12 22:21:51 2018 VR support for android.app.AlertDialogs This is used to support html <select> element when it uses Android AlertDialogs. Bug:819876 Change-Id: Ibe005b8227d623430e79a563521700258cc34d69 Reviewed-on: https://chromium-review.googlesource.com/1010479 Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Reviewed-by: Biao She <bshe@chromium.org> Cr-Commit-Position: refs/heads/master@{#550387} [add] https://crrev.com/57ce29bfb9f82673cbe1f43bbb199f0e316b1572/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrAlertDialog.java [modify] https://crrev.com/57ce29bfb9f82673cbe1f43bbb199f0e316b1572/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java [modify] https://crrev.com/57ce29bfb9f82673cbe1f43bbb199f0e316b1572/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrUiWidgetFactory.java [modify] https://crrev.com/57ce29bfb9f82673cbe1f43bbb199f0e316b1572/chrome/android/java_sources.gni
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3324b05ba6b29425f9eec6c936b0b3658fabdff8 commit 3324b05ba6b29425f9eec6c936b0b3658fabdff8 Author: Amirhossein Simjour <asimjour@chromium.org> Date: Fri Apr 13 01:37:28 2018 VR: Remove suppression of select popup VR supports html select element, so the corresponding page popup doesn't need to be suppressed. Bug: 819876 Change-Id: Iac3cf7fbd7437cce27f3a265e95e3f0eb76c3e2c Reviewed-on: https://chromium-review.googlesource.com/1010782 Reviewed-by: Ian Vollick <vollick@chromium.org> Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Cr-Commit-Position: refs/heads/master@{#550462} [modify] https://crrev.com/3324b05ba6b29425f9eec6c936b0b3658fabdff8/third_party/blink/renderer/core/page/chrome_client_impl.cc [modify] https://crrev.com/3324b05ba6b29425f9eec6c936b0b3658fabdff8/third_party/blink/renderer/core/page/chrome_client_impl_test.cc
,
Apr 24 2018
In Chrome 68.0.3405.0 Android O, Pixel 2XL, I can't scroll in the <select> list popups. (1) Navigate to https://rsolomakhin.github.io/autofill/ (2) Enter VR Browsing (3) Open the State list. (4) Try to scroll to select one of the states further in the list.
,
Apr 24 2018
,
Apr 25 2018
Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0943e8f58fa1dfe5ccdef330052aeebb794c1852 commit 0943e8f58fa1dfe5ccdef330052aeebb794c1852 Author: Amirhossein Simjour <asimjour@chromium.org> Date: Wed Apr 25 17:06:59 2018 VR: Remove suppression of select popup VR supports html select element, so the corresponding page popup doesn't need to be suppressed. Bug: 819876 Change-Id: Iac3cf7fbd7437cce27f3a265e95e3f0eb76c3e2c Reviewed-on: https://chromium-review.googlesource.com/1010782 Reviewed-by: Ian Vollick <vollick@chromium.org> Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#550462}(cherry picked from commit 3324b05ba6b29425f9eec6c936b0b3658fabdff8) Reviewed-on: https://chromium-review.googlesource.com/1028334 Reviewed-by: Amirhossein Simjour <asimjour@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#298} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/0943e8f58fa1dfe5ccdef330052aeebb794c1852/third_party/blink/renderer/core/page/chrome_client_impl.cc [modify] https://crrev.com/0943e8f58fa1dfe5ccdef330052aeebb794c1852/third_party/blink/renderer/core/page/chrome_client_impl_test.cc
,
Apr 25 2018
,
May 8 2018
Fix Verified in build 67.0.3396.29 beta. Bug 836292 - [VR Browsing] <select> lists are not scroll-able has been fixed and is being merged back to M-67. |
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by ericde@google.com
, Mar 8 2018