New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 819870 link

Starred by 1 user
Status: Fixed
Owner:
█ apaci...@chromium.org
no longer active
Closed: Mar 2018
Cc:
mlamouri@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Fix c/b/ui/views/overlay/OWNERS file.

Project Member Reported by apaci...@chromium.org, Mar 8 2018 
In a patch[1] moving some files to different directories, we accidentally broke some OWNERS file chaining.

This fix will land in two patches:
1. Reinstate the c/b/ui/overlay/OWNERS file. Update the broken c/b/ui/views/overlay/OWNERS file.
2. Delete the c/b/ui/overlay/OWNERS file.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/946255
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a021c86289e46ead98a371939120299311ee450

commit 7a021c86289e46ead98a371939120299311ee450
Author: Jennifer Apacible <apacible@chromium.org>
Date: Thu Mar 08 14:29:54 2018

Update chrome/browser/ui/views/overlay/OWNERS file.

This OWNERS was missed when moving c/b/ui/overlay to c/b/overlay.
With the previous change (see crbug), c/b/ui/views/overlay/OWNERS
now points to an OWNERS file that no longer exists. Rather than
reverting the previous patch, this will be less disruptive while
fixing the OWNERS chain.

Part one of a two part fix for c/b/ui/views/overlay/OWNERS.

BUG:  819870 
Change-Id: I0fb9baf6a65a9e0afbfb2e2e26cfca745b5d984a
Reviewed-on: https://chromium-review.googlesource.com/954325
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541790}
[add] https://crrev.com/7a021c86289e46ead98a371939120299311ee450/chrome/browser/ui/overlay/OWNERS
[modify] https://crrev.com/7a021c86289e46ead98a371939120299311ee450/chrome/browser/ui/views/overlay/OWNERS
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07845935389c2f546c312a8f724f8fb915f9a65b

commit 07845935389c2f546c312a8f724f8fb915f9a65b
Author: Jennifer Apacible <apacible@chromium.org>
Date: Thu Mar 08 14:56:55 2018

Remove chrome/browser/ui/overlay/OWNERS.

This OWNERS file was added temporarily to fix a broken OWNERS
chain. Remove now that we no longer need it.

Part two of a two part fix for c/b/ui/views/overlay/OWNERS.

BUG:  819870 
Change-Id: I5f3c280c2a97e504b96f7dbad7331ae930324fed
Reviewed-on: https://chromium-review.googlesource.com/954341
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541797}
[delete] https://crrev.com/7a45fd917aa4554f28f8e9afb3f85f68d43ddee6/chrome/browser/ui/overlay/OWNERS

Comment 3 by apaci...@chromium.org, Mar 10 2018

Status: Fixed (was: Started)
►

Sign in to add a comment