New issue
Advanced search Search tips

Issue 819863 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 696706



Sign in to add a comment

Bugdroid updates bugs on Gerrit hashtag changes for landed CLs

Project Member Reported by zhangtiff@chromium.org, Mar 8 2018

Issue description

I've been hashtagging some of my old CLs today on Gerrit and noticed it caused a flurry of recent Bugdroid updates to old bugs. ie: 

https://bugs.chromium.org/p/chromium/issues/detail?id=637006#c21
https://bugs.chromium.org/p/chromium/issues/detail?id=669254#c10

This is spammy, and I imagine probably unintentional. 

(Sorry for the spam, Sean and Stephen)
 
0_o wat

The code bugdroid uses to get recently-landed CLs from Gerrit is here:
https://cs.chromium.org/chromium/infra/infra/services/bugdroid/gerrit_poller.py?q=gerrit.GetLogEntries&sq=package:chromium&l=191
https://cs.chromium.org/chromium/infra/infra/services/bugdroid/gob_helper.py?type=cs&q=GetLogEntries&sq=package:chromium&l=587

Which hits the https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html#list-changes API with a query of the form:

q=status:merged+since:XXXX-YY-ZZ

Unfortunately, the 'since' operator isn't documented at https://gerrit-review.googlesource.com/Documentation/user-search.html#_search_operators, and the hashtag feature is rather new, so its behavior may have recently changed (or never worked as expected).
Ok, "since" is documented, it's just alphebetized under "after" so I missed it. Looks like it shows changes *modified* after the given time, not *submitted* after the given time. It makes sense that we basically never see this get confused, since no one goes through and makes substantive changes to their CLs after merging them, but apparently hash-tagging does it.

Comment 3 by aga...@chromium.org, Mar 27 2018

Blockedon: 696706
This would be trivially fixed by addressing 696706; I doubt we'll address it prior to that, so marking blocked.

Sign in to add a comment