New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 819852 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2018
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

ImageSanitizer hangs if the data decoder service crashes

Project Member Reported by jcivelli@chromium.org, Mar 8 2018

Issue description

The ImageSanitizer hangs if the data decoder service crashes and never returns.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/865c49d682a30aa8b88e6b18a2a8359d4a537a17

commit 865c49d682a30aa8b88e6b18a2a8359d4a537a17
Author: Jay Civelli <jcivelli@google.com>
Date: Thu Mar 08 17:55:23 2018

Fix ImageSanitizer hang when the data decoder service crashes

The ImageSanitizer would not call its callback if the data decoder
service crashes. Fixing this and introducing a test data decoder
service that unbinds when a call is made on an interface to simulate a
crasher.
That data decoder test service will be used in a subsequent CL to
simulate JSON parser crashers.

Bug:  819852 
Change-Id: Idda0bef2c97513ff0d833d66af1c5777231bfa09
Reviewed-on: https://chromium-review.googlesource.com/954237
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541833}
[modify] https://crrev.com/865c49d682a30aa8b88e6b18a2a8359d4a537a17/extensions/browser/image_sanitizer.cc
[modify] https://crrev.com/865c49d682a30aa8b88e6b18a2a8359d4a537a17/extensions/browser/image_sanitizer.h
[modify] https://crrev.com/865c49d682a30aa8b88e6b18a2a8359d4a537a17/extensions/browser/image_sanitizer_unittest.cc
[modify] https://crrev.com/865c49d682a30aa8b88e6b18a2a8359d4a537a17/services/data_decoder/public/cpp/test_data_decoder_service.cc
[modify] https://crrev.com/865c49d682a30aa8b88e6b18a2a8359d4a537a17/services/data_decoder/public/cpp/test_data_decoder_service.h

Status: Fixed (was: Untriaged)

Sign in to add a comment