ONC: Incorrectly sets Efective to UserPolicy when only UserSetting exists |
||
Issue description
Repro (requires issue 742666):
1. Log in with a policy configured VPN.
2. Modify OpenVPN.ExtraHosts.
3. In chrome://network select 'Managed ONC' fro 'Property format' and expand the VPN.
Obesrver: The managed property will include an 'ExtraHosts' entry that looks like:
"Extrahosts": {
"Effective": "UserPolicy",
"UserSetting": [ "foo.com", "bar.com" ]
}
The "Effective" value should not be "UserPolicy" when only a "UserSetting" value has been specified.
This is going to be a subtle change that will need to be carefully tested. In the short term, we can work around it in the UI by treating this result as user editable and not policy controlled.
,
Mar 8 2018
,
Mar 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0ee21671257812e50f5d23499788572166f6e77f commit 0ee21671257812e50f5d23499788572166f6e77f Author: Steven Bennetts <stevenjb@chromium.org> Date: Mon Mar 12 20:25:02 2018 Network config: Fix up network-property-list and support string arrays In preparation for supporting OpenVPN.ExtraHosts, we need to support string arrays in network-property-list. Some issues with policy indicators were discovered as well. This CL: * Adds support for an editable StringArray type. * Only shows policy indicators for fields that may be user editable. (Other indicators just provide noise). * Treats properties with no entry in policy controlled configurations as not user editable. Bug: 742666,819837 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I601e4cc0839bd1560bd1dc5af099aba3b19623dc Reviewed-on: https://chromium-review.googlesource.com/955934 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#542582} [modify] https://crrev.com/0ee21671257812e50f5d23499788572166f6e77f/ui/webui/resources/cr_components/chromeos/network/network_property_list.html [modify] https://crrev.com/0ee21671257812e50f5d23499788572166f6e77f/ui/webui/resources/cr_components/chromeos/network/network_property_list.js [modify] https://crrev.com/0ee21671257812e50f5d23499788572166f6e77f/ui/webui/resources/cr_elements/chromeos/network/cr_onc_types.js |
||
►
Sign in to add a comment |
||
Comment 1 by steve...@chromium.org
, Mar 8 2018