Issue 819834 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	sorin@chromium.org
Closed:	Mar 2018
Cc:	waff...@chromium.org
Components:	Internals>Installer>Components
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	3
Type:	Bug

Replace Fake with Mock in the component updater

Project Member Reported by sorin@chromium.org, Mar 7 2018

Issue description

The terminology distinction between mocks and fakes is not that clear cut. 
In the component updater, what we have named fakes (objects with some test implementation, unsuited for production) are actually mocks (objects intended to capture calls and test expectations).

To avoid confusion, just use "Mock" terminology everywhere in the component updater tests.

Project Member

Comment 1 by bugdroid1@chromium.org, Mar 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8926bf2f0c379e977af4dcc7c56f9626796cefd

commit a8926bf2f0c379e977af4dcc7c56f9626796cefd
Author: Sorin Jianu <sorin@chromium.org>
Date: Fri Mar 09 21:02:53 2018

Replace Fake with Mock in the component updater

Bug:  819834 
Change-Id: I624029d327940f86be4852fbebe7f5a525d72a30
Reviewed-on: https://chromium-review.googlesource.com/953976
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542219}
[modify] https://crrev.com/a8926bf2f0c379e977af4dcc7c56f9626796cefd/components/component_updater/component_installer_unittest.cc
[modify] https://crrev.com/a8926bf2f0c379e977af4dcc7c56f9626796cefd/components/component_updater/timer_unittest.cc
[modify] https://crrev.com/a8926bf2f0c379e977af4dcc7c56f9626796cefd/components/update_client/component.h
[modify] https://crrev.com/a8926bf2f0c379e977af4dcc7c56f9626796cefd/components/update_client/ping_manager_unittest.cc
[modify] https://crrev.com/a8926bf2f0c379e977af4dcc7c56f9626796cefd/components/update_client/update_checker_unittest.cc
[modify] https://crrev.com/a8926bf2f0c379e977af4dcc7c56f9626796cefd/components/update_client/update_client_unittest.cc

Comment 2 by sorin@chromium.org, Mar 9 2018

Status: Fixed (was: Untriaged)

►

Issue 819834 link

Issue metadata

Replace Fake with Mock in the component updater

Issue description

Comment 1 by bugdroid1@chromium.org, Mar 9 2018

Comment 1 Deleted

Comment 2 by sorin@chromium.org, Mar 9 2018

Comment 2 Deleted

Sign in to add a comment