New issue
Advanced search Search tips

Issue 819803 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove bind_helpers.h from component updater

Project Member Reported by sorin@chromium.org, Mar 7 2018

Issue description

It seems it is not needed anymore for the definitions of base::Unretained, etc.
These definitions have been moved to bind.h
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4314b87c92fb50d3e42bdd970c8f49f85ae325b7

commit 4314b87c92fb50d3e42bdd970c8f49f85ae325b7
Author: Sorin Jianu <sorin@chromium.org>
Date: Thu Mar 08 02:42:42 2018

Remove bind_helpers.h from component updater

Bug:  819803 
Change-Id: Ie40504523f779c3fcb1063f68445222aef837126
Reviewed-on: https://chromium-review.googlesource.com/953593
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541699}
[modify] https://crrev.com/4314b87c92fb50d3e42bdd970c8f49f85ae325b7/chrome/browser/component_updater/crl_set_component_installer.cc
[modify] https://crrev.com/4314b87c92fb50d3e42bdd970c8f49f85ae325b7/chrome/browser/component_updater/pnacl_component_installer.cc
[modify] https://crrev.com/4314b87c92fb50d3e42bdd970c8f49f85ae325b7/chrome/browser/component_updater/recovery_component_installer.cc
[modify] https://crrev.com/4314b87c92fb50d3e42bdd970c8f49f85ae325b7/chrome/browser/component_updater/sw_reporter_installer_win_unittest.cc
[modify] https://crrev.com/4314b87c92fb50d3e42bdd970c8f49f85ae325b7/components/component_updater/component_installer.cc
[modify] https://crrev.com/4314b87c92fb50d3e42bdd970c8f49f85ae325b7/components/component_updater/component_updater_service.cc
[modify] https://crrev.com/4314b87c92fb50d3e42bdd970c8f49f85ae325b7/components/component_updater/component_updater_service_unittest.cc
[modify] https://crrev.com/4314b87c92fb50d3e42bdd970c8f49f85ae325b7/components/component_updater/crl_set_remover.cc
[modify] https://crrev.com/4314b87c92fb50d3e42bdd970c8f49f85ae325b7/components/component_updater/timer.cc
[modify] https://crrev.com/4314b87c92fb50d3e42bdd970c8f49f85ae325b7/components/update_client/action_runner.cc
[modify] https://crrev.com/4314b87c92fb50d3e42bdd970c8f49f85ae325b7/components/update_client/action_runner_win.cc
[modify] https://crrev.com/4314b87c92fb50d3e42bdd970c8f49f85ae325b7/components/update_client/background_downloader_win.cc
[modify] https://crrev.com/4314b87c92fb50d3e42bdd970c8f49f85ae325b7/components/update_client/component.cc
[modify] https://crrev.com/4314b87c92fb50d3e42bdd970c8f49f85ae325b7/components/update_client/component_patcher.cc
[modify] https://crrev.com/4314b87c92fb50d3e42bdd970c8f49f85ae325b7/components/update_client/component_patcher_unittest.cc
[modify] https://crrev.com/4314b87c92fb50d3e42bdd970c8f49f85ae325b7/components/update_client/component_unpacker_unittest.cc
[modify] https://crrev.com/4314b87c92fb50d3e42bdd970c8f49f85ae325b7/components/update_client/crx_downloader.cc
[modify] https://crrev.com/4314b87c92fb50d3e42bdd970c8f49f85ae325b7/components/update_client/crx_downloader_unittest.cc
[modify] https://crrev.com/4314b87c92fb50d3e42bdd970c8f49f85ae325b7/components/update_client/ping_manager.cc
[modify] https://crrev.com/4314b87c92fb50d3e42bdd970c8f49f85ae325b7/components/update_client/request_sender.cc
[modify] https://crrev.com/4314b87c92fb50d3e42bdd970c8f49f85ae325b7/components/update_client/task_send_uninstall_ping.cc
[modify] https://crrev.com/4314b87c92fb50d3e42bdd970c8f49f85ae325b7/components/update_client/task_update.cc
[modify] https://crrev.com/4314b87c92fb50d3e42bdd970c8f49f85ae325b7/components/update_client/update_checker.cc
[modify] https://crrev.com/4314b87c92fb50d3e42bdd970c8f49f85ae325b7/components/update_client/update_checker_unittest.cc
[modify] https://crrev.com/4314b87c92fb50d3e42bdd970c8f49f85ae325b7/components/update_client/update_client.cc
[modify] https://crrev.com/4314b87c92fb50d3e42bdd970c8f49f85ae325b7/components/update_client/update_client_unittest.cc
[modify] https://crrev.com/4314b87c92fb50d3e42bdd970c8f49f85ae325b7/components/update_client/update_engine.cc
[modify] https://crrev.com/4314b87c92fb50d3e42bdd970c8f49f85ae325b7/components/update_client/url_fetcher_downloader.cc

Comment 2 by sorin@chromium.org, Mar 9 2018

Status: Fixed (was: Untriaged)

Sign in to add a comment