New issue
Advanced search Search tips

Issue 819799 link

Starred by 1 user
Status: Fixed
Owner:
l...@chromium.org
Closed: Jul 24
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

DevTools: console filter should support startOfLine ^ regex

Project Member Reported by l...@chromium.org, Mar 7 2018 
The DevTools Console doesn't support using the startOfLine ^ regex, e.g. `/^abc/` to filter for text `abc` at the start of messageText.

We should either move the anchor to the end when doing filtering, or filter on the messageText and the anchor separately.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/127fe20dcc32dbf567cb88b5b306e1564460703c

commit 127fe20dcc32dbf567cb88b5b306e1564460703c
Author: Erik Luo <luoe@chromium.org>
Date: Tue Jul 24 02:03:09 2018

DevTools: console regex filter should apply to anchors separately

Anchors can precede a console message's content, which makes filters
with start/end of line ('$', '^') fail. This CL evaluates any filter
regexes on the message content separately from the anchor.

Bug:  819799 
Change-Id: I0957fd8fb3dea26f690e859cfabbc432cdda069c
Reviewed-on: https://chromium-review.googlesource.com/1081561
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577405}
[modify] https://crrev.com/127fe20dcc32dbf567cb88b5b306e1564460703c/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-filter-test-expected.txt
[modify] https://crrev.com/127fe20dcc32dbf567cb88b5b306e1564460703c/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-filter-test.js
[modify] https://crrev.com/127fe20dcc32dbf567cb88b5b306e1564460703c/third_party/blink/renderer/devtools/front_end/console/ConsoleViewMessage.js

Comment 2 by l...@chromium.org, Jul 24

Status: Fixed (was: Assigned)
►

Sign in to add a comment