New issue
Advanced search Search tips

Issue 819798 link

Starred by 2 users
Status: Fixed
Owner:
amusbach@google.com
Closed: Jan 15
Cc:
omrilio@chromium.org
x...@chromium.org
sammiequon@chromium.org
mccanny@chromium.org
zork@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

cros splitscreen - Preserve snapped window state when switching from laptop to tablet

Project Member Reported by x...@chromium.org, Mar 7 2018 
Chrome Version: 67.0.3364.0
OS: Chrome

If the current active window is a snapped window when the user switches from laptop mode to tablet mode, we should put the snapped window directly in splitscreen mode to occupy one side of the screen:

1) If the second window in MRU window list is also a snapped window which occupies the other side of the screen, also put it in splitscreen mode. The other windows in MRU list will be maximized (which may include other snapped windows?).

2) If not, maximize all the other windows and open overview window grid in the other side of the screen. 

Ben, Omri, does the behavior sound right to you?

Comment 1 by mccanny@chromium.org, Mar 8 2018 

SGTM. Adding this feature is likely going to create a bunch of edge cases we haven't spent time thinking about, re: user expectations when converting back to laptop mode. 

As a starting point, we should make sure that we convert back to the same window setup we left laptop mode in if nothing was changed about the split or windows in tablet mode.

Comment 2 by x...@chromium.org, Dec 21

Cc: sammiequon@chromium.org x...@chromium.org
Owner: amusbach@google.com
Avery, assign it to you as I think it's a good starter project to work on. 

It's not an urgent task, so take your time to get familiar with the workflow and codebase. If you have other bugs on your plate (from Sammie), you can work on them first. Sammie or Zach should be able to help you if you have any questions.

(Assign to your google account first while you're still waiting for your chromium account approval)
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/388822907cb23fcc09472fb927f2b9d482dc43d9

commit 388822907cb23fcc09472fb927f2b9d482dc43d9
Author: Avery Musbach <amusbach@google.com>
Date: Wed Jan 02 19:57:32 2019

Carry over snapped windows from laptop to tablet.

If the active window is snapped when the user switches from laptop mode
to tablet mode, then split view shall be activated with the active
window on the side to which it was snapped. On the other side shall be
the previous window if it was snapped to that side, and overview
otherwise.

Bug:  819798 
Change-Id: I22830563e0fea71977cd5b6c0b78f9d4f3a66e71
Reviewed-on: https://chromium-review.googlesource.com/c/1391470
Commit-Queue: Avery Musbach <amusbach@google.com>
Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619459}
[modify] https://crrev.com/388822907cb23fcc09472fb927f2b9d482dc43d9/ash/wm/tablet_mode/tablet_mode_window_manager.cc
[modify] https://crrev.com/388822907cb23fcc09472fb927f2b9d482dc43d9/ash/wm/tablet_mode/tablet_mode_window_manager.h
[modify] https://crrev.com/388822907cb23fcc09472fb927f2b9d482dc43d9/ash/wm/tablet_mode/tablet_mode_window_manager_unittest.cc
[modify] https://crrev.com/388822907cb23fcc09472fb927f2b9d482dc43d9/ash/wm/tablet_mode/tablet_mode_window_state.cc
[modify] https://crrev.com/388822907cb23fcc09472fb927f2b9d482dc43d9/ash/wm/tablet_mode/tablet_mode_window_state.h

Comment 4 by amusbach@google.com, Jan 15

Status: Fixed (was: Assigned)
►

Sign in to add a comment