Issue metadata
Sign in to add a comment
|
Toolbar background is lost after switching tabs from incognito |
||||||||||||||||||||||
Issue descriptionApp Version: 66.0.3359.12 beta iOS Version: 10.3.3, 11.2.6, 11.3 beta4 Device: iPhones only URL: na Steps to reproduce: 1. Launch Google Chrome 2. Navigate to any webpage 3. Open Menu → New Incognito tab 4. Enter tab switcher mode and swipe back to regular tab Observed results: Observe that toolbar background is displayed white Expected results: Toolbar background should be displayed correctly. Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: NA Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA Bug reproducible on current stable build (App Version, iOS Version): M65 NO Bug reproducible on the current beta channel build (App Version, iOS Version): M66 YES Link to video/image: Screenshot: https://docs.google.com/drawings/d/1JLDknSpFpQ0-eH9q_T5Iivq_wDlF1t41mOyYKrgPfp4/preview Video: https://drive.google.com/file/d/1_K7vE8JiuAmWeIEiTYzCanlcmbtkL8Lp/view
,
Mar 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c06388a91a8048204e0808f60fc804003b2c4ba2 commit c06388a91a8048204e0808f60fc804003b2c4ba2 Author: Gauthier Ambard <gambard@chromium.org> Date: Fri Mar 09 15:58:23 2018 Create the fake ntp background view invisible This CL changes the creation of the view used to simulate the background of the NTP during stack view animation so it is unvisible at the creation. Bug: 819795 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ia59dea3ff4902b21ad1fa097d0bb3c7210d41b93 Reviewed-on: https://chromium-review.googlesource.com/956071 Reviewed-by: Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#542127} [modify] https://crrev.com/c06388a91a8048204e0808f60fc804003b2c4ba2/ios/chrome/browser/ui/toolbar/clean/toolbar_view.mm
,
Mar 9 2018
,
Mar 10 2018
Your change meets the bar and is auto-approved for M66. Please go ahead and merge the CL to branch 3359 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/997769ebfc4f05be7c2da25708c5713211cde718 commit 997769ebfc4f05be7c2da25708c5713211cde718 Author: Gauthier Ambard <gambard@chromium.org> Date: Tue Mar 13 12:37:08 2018 Create the fake ntp background view invisible This CL changes the creation of the view used to simulate the background of the NTP during stack view animation so it is unvisible at the creation. Bug: 819795 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ia59dea3ff4902b21ad1fa097d0bb3c7210d41b93 Reviewed-on: https://chromium-review.googlesource.com/956071 Reviewed-by: Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#542127}(cherry picked from commit c06388a91a8048204e0808f60fc804003b2c4ba2) Reviewed-on: https://chromium-review.googlesource.com/960381 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#191} Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} [modify] https://crrev.com/997769ebfc4f05be7c2da25708c5713211cde718/ios/chrome/browser/ui/toolbar/clean/toolbar_view.mm
,
Mar 13 2018
Issue verified Version: Chrome Canary 67.0.3369.0 Device: iPhone 6 Plus iOS: 11.2.6 Toolbar background displayed correctly (Grey) https://drive.google.com/open?id=1378brDFSMDM7ZwB_OenQ_xzrI2ynTHYc
,
Mar 14 2018
Verified in: App Version: 66.0.3359.30 beta Devices: iPhone 7 Plus, iPhone 8, iPhone 8 Plus iOS Versions: 10.3.3, 11.2.6, 11.3 beta 5 Toolbar background is displayed correctly. Video: https://drive.google.com/open?id=113Dh04-XJdU-2A1n_j2G5VmhPyWeMuIx |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by huangml@chromium.org
, Mar 8 2018Status: Assigned (was: Untriaged)