[Incompatible Applications] Google modules are not ignored ModuleListFilter |
|||||||||||||||||
Issue descriptionThis leads to a silly situation where the Incompatible Applications settings subpage tells the user that Chrome is not compatible with itself, because a Chrome dll is loaded into the process.
,
Mar 14 2018
Requesting merge to m66 for this bug fix.
,
Mar 15 2018
Your change meets the bar and is auto-approved for M66. Please go ahead and merge the CL to branch 3359 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eed141fdcc10f69f15e0eab3964a17e81f1891b7 commit eed141fdcc10f69f15e0eab3964a17e81f1891b7 Author: Patrick Monette <pmonette@chromium.org> Date: Thu Mar 15 17:16:00 2018 [3p-Conflicts] Now ignore wanted modules in IsBlacklisted() We explicitly allow all modules seemingly signed by the signer of the process's main exe to load into the process. Bug: 819793 Change-Id: I3636b8251cb82cd1d4a5f69f3899ea4516b1b00a Reviewed-on: https://chromium-review.googlesource.com/952074 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by: Greg Thompson <grt@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#543091}(cherry picked from commit 7ceeebafcb1000b3107f9ec91a51f2851569a5d8) Reviewed-on: https://chromium-review.googlesource.com/963851 Reviewed-by: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#271} Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} [modify] https://crrev.com/eed141fdcc10f69f15e0eab3964a17e81f1891b7/chrome/browser/conflicts/module_list_filter_win.cc [modify] https://crrev.com/eed141fdcc10f69f15e0eab3964a17e81f1891b7/chrome/browser/conflicts/module_list_filter_win.h
,
Mar 19 2018
The fix I added is not working as this is still happening.
,
Mar 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fdf8f25c66658ea5a60e7856f9fdfcfaabb1acc1 commit fdf8f25c66658ea5a60e7856f9fdfcfaabb1acc1 Author: Patrick Monette <pmonette@chromium.org> Date: Thu Mar 22 17:29:06 2018 [3p-Conflicts] Fix whitelisting of modules with matching cert's subject A previous CL was meant to whitelist modules whose cert's subject matches the cert's subject of the executable, but the code was added in the wrong file. Move the check from ModuleListFilter where it doesn't belong and move it to the ProblematicProgramsUpdater class. Also added a unit test to make sure the issue is really fixed. Bug: 819793 Change-Id: Ibd6a3c599d6b5ec2bf0a50c5ae0536159bb30fc6 Reviewed-on: https://chromium-review.googlesource.com/969601 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#545128} [modify] https://crrev.com/fdf8f25c66658ea5a60e7856f9fdfcfaabb1acc1/chrome/browser/conflicts/module_list_filter_win.cc [modify] https://crrev.com/fdf8f25c66658ea5a60e7856f9fdfcfaabb1acc1/chrome/browser/conflicts/module_list_filter_win.h [modify] https://crrev.com/fdf8f25c66658ea5a60e7856f9fdfcfaabb1acc1/chrome/browser/conflicts/problematic_programs_updater_win.cc [modify] https://crrev.com/fdf8f25c66658ea5a60e7856f9fdfcfaabb1acc1/chrome/browser/conflicts/problematic_programs_updater_win.h [modify] https://crrev.com/fdf8f25c66658ea5a60e7856f9fdfcfaabb1acc1/chrome/browser/conflicts/problematic_programs_updater_win_unittest.cc [modify] https://crrev.com/fdf8f25c66658ea5a60e7856f9fdfcfaabb1acc1/chrome/browser/conflicts/third_party_conflicts_manager_win.cc [modify] https://crrev.com/fdf8f25c66658ea5a60e7856f9fdfcfaabb1acc1/chrome/browser/conflicts/third_party_conflicts_manager_win.h
,
Mar 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/621d9cf701e7fae224dcea040596037a30133bb1 commit 621d9cf701e7fae224dcea040596037a30133bb1 Author: Thomas Anderson <thomasanderson@chromium.org> Date: Thu Mar 22 17:49:11 2018 Revert "[3p-Conflicts] Fix whitelisting of modules with matching cert's subject" This reverts commit fdf8f25c66658ea5a60e7856f9fdfcfaabb1acc1. Reason for revert: Broke Google Chrome Win: https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20Win/28332 Original change's description: > [3p-Conflicts] Fix whitelisting of modules with matching cert's subject > > A previous CL was meant to whitelist modules whose cert's subject > matches the cert's subject of the executable, but the code was added in > the wrong file. > > Move the check from ModuleListFilter where it doesn't belong and move it > to the ProblematicProgramsUpdater class. > > Also added a unit test to make sure the issue is really fixed. > > Bug: 819793 > Change-Id: Ibd6a3c599d6b5ec2bf0a50c5ae0536159bb30fc6 > Reviewed-on: https://chromium-review.googlesource.com/969601 > Commit-Queue: Patrick Monette <pmonette@chromium.org> > Reviewed-by: Greg Thompson <grt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#545128} TBR=pmonette@chromium.org,grt@chromium.org Change-Id: Id7b2f78ae9caaf950920185551099c40acc36988 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 819793 Reviewed-on: https://chromium-review.googlesource.com/976161 Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#545143} [modify] https://crrev.com/621d9cf701e7fae224dcea040596037a30133bb1/chrome/browser/conflicts/module_list_filter_win.cc [modify] https://crrev.com/621d9cf701e7fae224dcea040596037a30133bb1/chrome/browser/conflicts/module_list_filter_win.h [modify] https://crrev.com/621d9cf701e7fae224dcea040596037a30133bb1/chrome/browser/conflicts/problematic_programs_updater_win.cc [modify] https://crrev.com/621d9cf701e7fae224dcea040596037a30133bb1/chrome/browser/conflicts/problematic_programs_updater_win.h [modify] https://crrev.com/621d9cf701e7fae224dcea040596037a30133bb1/chrome/browser/conflicts/problematic_programs_updater_win_unittest.cc [modify] https://crrev.com/621d9cf701e7fae224dcea040596037a30133bb1/chrome/browser/conflicts/third_party_conflicts_manager_win.cc [modify] https://crrev.com/621d9cf701e7fae224dcea040596037a30133bb1/chrome/browser/conflicts/third_party_conflicts_manager_win.h
,
Mar 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4ffc3b1a16173e7899c6c3716452006f7e73a8a7 commit 4ffc3b1a16173e7899c6c3716452006f7e73a8a7 Author: Patrick Monette <pmonette@chromium.org> Date: Thu Mar 22 18:12:09 2018 Reland "[3p-Conflicts] Fix whitelisting of modules with matching cert's subject" This is a reland of fdf8f25c66658ea5a60e7856f9fdfcfaabb1acc1 Original change's description: > [3p-Conflicts] Fix whitelisting of modules with matching cert's subject > > A previous CL was meant to whitelist modules whose cert's subject > matches the cert's subject of the executable, but the code was added in > the wrong file. > > Move the check from ModuleListFilter where it doesn't belong and move it > to the ProblematicProgramsUpdater class. > > Also added a unit test to make sure the issue is really fixed. > > Bug: 819793 > Change-Id: Ibd6a3c599d6b5ec2bf0a50c5ae0536159bb30fc6 > Reviewed-on: https://chromium-review.googlesource.com/969601 > Commit-Queue: Patrick Monette <pmonette@chromium.org> > Reviewed-by: Greg Thompson <grt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#545128} Tbr: grt@chromium.org Bug: 819793 Change-Id: I67ba5cc75c7d7a0822c79d8e84dfec6cd69b919b Reviewed-on: https://chromium-review.googlesource.com/976181 Reviewed-by: Patrick Monette <pmonette@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#545158} [modify] https://crrev.com/4ffc3b1a16173e7899c6c3716452006f7e73a8a7/chrome/browser/conflicts/module_list_filter_win.cc [modify] https://crrev.com/4ffc3b1a16173e7899c6c3716452006f7e73a8a7/chrome/browser/conflicts/module_list_filter_win.h [modify] https://crrev.com/4ffc3b1a16173e7899c6c3716452006f7e73a8a7/chrome/browser/conflicts/problematic_programs_updater_win.cc [modify] https://crrev.com/4ffc3b1a16173e7899c6c3716452006f7e73a8a7/chrome/browser/conflicts/problematic_programs_updater_win.h [modify] https://crrev.com/4ffc3b1a16173e7899c6c3716452006f7e73a8a7/chrome/browser/conflicts/problematic_programs_updater_win_unittest.cc [modify] https://crrev.com/4ffc3b1a16173e7899c6c3716452006f7e73a8a7/chrome/browser/conflicts/third_party_conflicts_manager_win.cc [modify] https://crrev.com/4ffc3b1a16173e7899c6c3716452006f7e73a8a7/chrome/browser/conflicts/third_party_conflicts_manager_win.h
,
Mar 22 2018
Requesting merge for a bugfix to m66. The request refers to comment #8, commit 4ffc3b1a16173e7899c6c3716452006f7e73a8a7 Author: Patrick Monette <pmonette@chromium.org> Date: Thu Mar 22 18:12:09 2018 Reland "[3p-Conflicts] Fix whitelisting of modules with matching cert's subject"
,
Mar 23 2018
This bug requires manual review: Reverts referenced in bugdroid comments after merge request. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 23 2018
Hi owners, This CL is needed in m66 because we're committed externally to launching the Incompatible Applications feature in m66, and this is an important bug fix for that feature. https://blog.chromium.org/2017/11/reducing-chrome-crashes-caused-by-third.html
,
Mar 26 2018
Approving merge to M66. Branch:3359
,
Mar 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7a84b2554440c4768b1df3cd9f5c0317196c9c0a commit 7a84b2554440c4768b1df3cd9f5c0317196c9c0a Author: Patrick Monette <pmonette@chromium.org> Date: Mon Mar 26 18:32:08 2018 Reland "[3p-Conflicts] Fix whitelisting of modules with matching cert's subject" This is a reland of fdf8f25c66658ea5a60e7856f9fdfcfaabb1acc1 Original change's description: > [3p-Conflicts] Fix whitelisting of modules with matching cert's subject > > A previous CL was meant to whitelist modules whose cert's subject > matches the cert's subject of the executable, but the code was added in > the wrong file. > > Move the check from ModuleListFilter where it doesn't belong and move it > to the ProblematicProgramsUpdater class. > > Also added a unit test to make sure the issue is really fixed. > > Bug: 819793 > Change-Id: Ibd6a3c599d6b5ec2bf0a50c5ae0536159bb30fc6 > Reviewed-on: https://chromium-review.googlesource.com/969601 > Commit-Queue: Patrick Monette <pmonette@chromium.org> > Reviewed-by: Greg Thompson <grt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#545128} Tbr: grt@chromium.org Bug: 819793 Change-Id: I67ba5cc75c7d7a0822c79d8e84dfec6cd69b919b Reviewed-on: https://chromium-review.googlesource.com/976181 Reviewed-by: Patrick Monette <pmonette@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#545158}(cherry picked from commit 4ffc3b1a16173e7899c6c3716452006f7e73a8a7) Reviewed-on: https://chromium-review.googlesource.com/981084 Cr-Commit-Position: refs/branch-heads/3359@{#442} Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} [modify] https://crrev.com/7a84b2554440c4768b1df3cd9f5c0317196c9c0a/chrome/browser/conflicts/module_list_filter_win.cc [modify] https://crrev.com/7a84b2554440c4768b1df3cd9f5c0317196c9c0a/chrome/browser/conflicts/module_list_filter_win.h [modify] https://crrev.com/7a84b2554440c4768b1df3cd9f5c0317196c9c0a/chrome/browser/conflicts/problematic_programs_updater_win.cc [modify] https://crrev.com/7a84b2554440c4768b1df3cd9f5c0317196c9c0a/chrome/browser/conflicts/problematic_programs_updater_win.h [modify] https://crrev.com/7a84b2554440c4768b1df3cd9f5c0317196c9c0a/chrome/browser/conflicts/problematic_programs_updater_win_unittest.cc [modify] https://crrev.com/7a84b2554440c4768b1df3cd9f5c0317196c9c0a/chrome/browser/conflicts/third_party_conflicts_manager_win.cc [modify] https://crrev.com/7a84b2554440c4768b1df3cd9f5c0317196c9c0a/chrome/browser/conflicts/third_party_conflicts_manager_win.h
,
Apr 12 2018
After digging it turns out that sometimes the certificate subject has trailing nulls, and other times not. Doing an exact equality test means that for some signed modules the equality test will fail. We should add logic to trim trailing nulls in the module_info_win.cc:GetSubjectNameInFile: https://cs.chromium.org/chromium/src/chrome/browser/conflicts/module_info_util_win.cc?sq=package:chromium&l=106
,
Apr 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/423da61ebbd8b21015449d9f4547472afd64cfd2 commit 423da61ebbd8b21015449d9f4547472afd64cfd2 Author: Patrick Monette <pmonette@chromium.org> Date: Thu Apr 12 22:36:20 2018 Fix marking Chrome as incompatible with itself This was caused by comparing a normalized subject name to a non- normalized subject. The trailing null character of the non-normalized was causing the comparison to fail for the same subject name. That normalization is now done as part of GetCertificateInfo(), so that it cannot be misused. Bug: 819793 Change-Id: I0f68225ceb513aaef695fd2a673d09598ad8b3c5 Reviewed-on: https://chromium-review.googlesource.com/1010835 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#550391} [modify] https://crrev.com/423da61ebbd8b21015449d9f4547472afd64cfd2/chrome/browser/conflicts/module_info_util_win.cc [modify] https://crrev.com/423da61ebbd8b21015449d9f4547472afd64cfd2/chrome/browser/conflicts/module_info_util_win.h [modify] https://crrev.com/423da61ebbd8b21015449d9f4547472afd64cfd2/chrome/browser/conflicts/module_info_util_win_unittest.cc [modify] https://crrev.com/423da61ebbd8b21015449d9f4547472afd64cfd2/chrome/browser/conflicts/module_info_win.cc [modify] https://crrev.com/423da61ebbd8b21015449d9f4547472afd64cfd2/chrome/browser/conflicts/module_info_win.h [modify] https://crrev.com/423da61ebbd8b21015449d9f4547472afd64cfd2/chrome/browser/conflicts/module_info_win_unittest.cc
,
Apr 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/09b6721be468564b084ce2647de8082c1cc88c26 commit 09b6721be468564b084ce2647de8082c1cc88c26 Author: Patrick Monette <pmonette@chromium.org> Date: Fri Apr 13 17:53:45 2018 Fixed normalization of certificate subject for in-file certificates Bug: 819793 Change-Id: Ic42c128ba5f30208332f17100d24a61ee320c3db Reviewed-on: https://chromium-review.googlesource.com/1012190 Reviewed-by: Chris Hamilton <chrisha@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#550677} [modify] https://crrev.com/09b6721be468564b084ce2647de8082c1cc88c26/chrome/browser/conflicts/module_info_util_win.cc [modify] https://crrev.com/09b6721be468564b084ce2647de8082c1cc88c26/chrome/browser/conflicts/module_info_util_win.h [modify] https://crrev.com/09b6721be468564b084ce2647de8082c1cc88c26/chrome/browser/conflicts/module_info_util_win_unittest.cc
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/423da61ebbd8b21015449d9f4547472afd64cfd2 commit 423da61ebbd8b21015449d9f4547472afd64cfd2 Author: Patrick Monette <pmonette@chromium.org> Date: Thu Apr 12 22:36:20 2018 Fix marking Chrome as incompatible with itself This was caused by comparing a normalized subject name to a non- normalized subject. The trailing null character of the non-normalized was causing the comparison to fail for the same subject name. That normalization is now done as part of GetCertificateInfo(), so that it cannot be misused. Bug: 819793 Change-Id: I0f68225ceb513aaef695fd2a673d09598ad8b3c5 Reviewed-on: https://chromium-review.googlesource.com/1010835 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#550391} [modify] https://crrev.com/423da61ebbd8b21015449d9f4547472afd64cfd2/chrome/browser/conflicts/module_info_util_win.cc [modify] https://crrev.com/423da61ebbd8b21015449d9f4547472afd64cfd2/chrome/browser/conflicts/module_info_util_win.h [modify] https://crrev.com/423da61ebbd8b21015449d9f4547472afd64cfd2/chrome/browser/conflicts/module_info_util_win_unittest.cc [modify] https://crrev.com/423da61ebbd8b21015449d9f4547472afd64cfd2/chrome/browser/conflicts/module_info_win.cc [modify] https://crrev.com/423da61ebbd8b21015449d9f4547472afd64cfd2/chrome/browser/conflicts/module_info_win.h [modify] https://crrev.com/423da61ebbd8b21015449d9f4547472afd64cfd2/chrome/browser/conflicts/module_info_win_unittest.cc
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/09b6721be468564b084ce2647de8082c1cc88c26 commit 09b6721be468564b084ce2647de8082c1cc88c26 Author: Patrick Monette <pmonette@chromium.org> Date: Fri Apr 13 17:53:45 2018 Fixed normalization of certificate subject for in-file certificates Bug: 819793 Change-Id: Ic42c128ba5f30208332f17100d24a61ee320c3db Reviewed-on: https://chromium-review.googlesource.com/1012190 Reviewed-by: Chris Hamilton <chrisha@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#550677} [modify] https://crrev.com/09b6721be468564b084ce2647de8082c1cc88c26/chrome/browser/conflicts/module_info_util_win.cc [modify] https://crrev.com/09b6721be468564b084ce2647de8082c1cc88c26/chrome/browser/conflicts/module_info_util_win.h [modify] https://crrev.com/09b6721be468564b084ce2647de8082c1cc88c26/chrome/browser/conflicts/module_info_util_win_unittest.cc
,
May 4 2018
,
May 17 2018
Requesting merge to m67 beta for CL at #17. It has been on dev for a long time now.
,
May 17 2018
This bug requires manual review: We are only 11 days from stable. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 17 2018
,
May 17 2018
This bug requires manual review: We are only 11 days from stable. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 17 2018
Approving merge to M67 branch 3396 fro CL listed at #17 per comment #21. Additional details - https://bugs.chromium.org/p/chromium/issues/detail?id=717696#c72.
,
May 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d319264c3e3f92a5f3c344426195dfc43430b8a1 commit d319264c3e3f92a5f3c344426195dfc43430b8a1 Author: Patrick Monette <pmonette@chromium.org> Date: Thu May 17 23:29:41 2018 Fixed normalization of certificate subject for in-file certificates Bug: 819793 Change-Id: Ic42c128ba5f30208332f17100d24a61ee320c3db Reviewed-on: https://chromium-review.googlesource.com/1012190 Reviewed-by: Chris Hamilton <chrisha@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#550677}(cherry picked from commit 09b6721be468564b084ce2647de8082c1cc88c26) Reviewed-on: https://chromium-review.googlesource.com/1065150 Reviewed-by: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#628} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/d319264c3e3f92a5f3c344426195dfc43430b8a1/chrome/browser/conflicts/module_info_util_win.cc [modify] https://crrev.com/d319264c3e3f92a5f3c344426195dfc43430b8a1/chrome/browser/conflicts/module_info_util_win.h [modify] https://crrev.com/d319264c3e3f92a5f3c344426195dfc43430b8a1/chrome/browser/conflicts/module_info_util_win_unittest.cc |
|||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||
Comment 1 by bugdroid1@chromium.org
, Mar 14 2018