[Incompatible Applications] IO is done on the UI thread when initializing the ModuleListFilter |
||||
Issue descriptionThe Module List component is read on the UI thread. This should be done on a background thread and the result posted back to the UI thread.
,
Mar 14 2018
Requesting merge to m66 for this bug fix.
,
Mar 15 2018
Your change meets the bar and is auto-approved for M66. Please go ahead and merge the CL to branch 3359 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/32892e778793453306d7087e206b6ccd0bb8ee25 commit 32892e778793453306d7087e206b6ccd0bb8ee25 Author: Patrick Monette <pmonette@chromium.org> Date: Thu Mar 15 17:06:25 2018 [3p-Conflicts] Make ModuleListFilter initialize on a background sequence This is to avoid doing IO access on the UI thread. Bug: 819791 Change-Id: I0f92f316ebc29d0c4270af46b3a6ccc854adfded Reviewed-on: https://chromium-review.googlesource.com/955670 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by: Greg Thompson <grt@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#543085}(cherry picked from commit 391e9004fc49055a9926a2a195081dc1b3d6eb52) Reviewed-on: https://chromium-review.googlesource.com/963850 Reviewed-by: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#270} Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} [modify] https://crrev.com/32892e778793453306d7087e206b6ccd0bb8ee25/chrome/browser/conflicts/installed_programs_win.cc [modify] https://crrev.com/32892e778793453306d7087e206b6ccd0bb8ee25/chrome/browser/conflicts/installed_programs_win.h [modify] https://crrev.com/32892e778793453306d7087e206b6ccd0bb8ee25/chrome/browser/conflicts/installed_programs_win_unittest.cc [modify] https://crrev.com/32892e778793453306d7087e206b6ccd0bb8ee25/chrome/browser/conflicts/module_list_filter_win.cc [modify] https://crrev.com/32892e778793453306d7087e206b6ccd0bb8ee25/chrome/browser/conflicts/module_list_filter_win.h [modify] https://crrev.com/32892e778793453306d7087e206b6ccd0bb8ee25/chrome/browser/conflicts/module_list_filter_win_unittest.cc [modify] https://crrev.com/32892e778793453306d7087e206b6ccd0bb8ee25/chrome/browser/conflicts/third_party_conflicts_manager_win.cc [modify] https://crrev.com/32892e778793453306d7087e206b6ccd0bb8ee25/chrome/browser/conflicts/third_party_conflicts_manager_win.h |
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Mar 14 2018