New issue
Advanced search Search tips

Issue 819790 link

Starred by 1 user
Status: Fixed
Owner:
pmonette@chromium.org
Closed: Mar 2018
Cc:
chrisha@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug

Blocking:
issue 717696



Sign in to add a comment

[Incompatible Applications] LaunchUninstallFlow only work on Windows 10

Project Member Reported by pmonette@chromium.org, Mar 7 2018 
The IncompatibleApplicationsWarning feature runs on all versions of Windows, but the LaunchUninstallFlow() function only works on Windows 10.

Either implement the function for Win7 to Win8.1 or restrict the feature to Windows 10.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 9 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ddf1f420836db3c7d8e975acd2c7afaf12c6142b

commit ddf1f420836db3c7d8e975acd2c7afaf12c6142b
Author: Patrick Monette <pmonette@chromium.org>
Date: Fri Mar 09 18:20:56 2018

[3p-Conflicts] Restrict the incompatible applications warning to Win10

Bug:  819790 
Change-Id: Ib5b1031bf23c211199693abcf614e0b9934214fb
Reviewed-on: https://chromium-review.googlesource.com/952202
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542154}
[modify] https://crrev.com/ddf1f420836db3c7d8e975acd2c7afaf12c6142b/chrome/browser/component_updater/third_party_module_list_component_installer_win.cc
[modify] https://crrev.com/ddf1f420836db3c7d8e975acd2c7afaf12c6142b/chrome/browser/conflicts/module_database_win.cc
[modify] https://crrev.com/ddf1f420836db3c7d8e975acd2c7afaf12c6142b/chrome/browser/conflicts/module_database_win.h

Comment 2 by pmonette@chromium.org, Mar 9 2018

Labels: Merge-Request-66
Requesting merge for a bugfix in M66
Project Member

Comment 3 by sheriffbot@chromium.org, Mar 10 2018

Labels: -Merge-Request-66 Merge-Approved-66 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M66. Please go ahead and merge the CL to branch 3359 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by gov...@chromium.org, Mar 12 2018 

Pls merge your change to M66 branch 3359 ASAP so we can pick it up for this week M66 Beta Promotion release. 

If it is already merged to M66, pls remove "Merge=Approved-66" label. Thank you.
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 12 2018

Labels: -merge-approved-66 merge-merged-3359
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6cb186c22f2f9ba15995a4dad348e690203b254

commit c6cb186c22f2f9ba15995a4dad348e690203b254
Author: Patrick Monette <pmonette@chromium.org>
Date: Mon Mar 12 20:44:42 2018

[3p-Conflicts] Restrict the incompatible applications warning to Win10

Bug:  819790 
Change-Id: Ib5b1031bf23c211199693abcf614e0b9934214fb
Reviewed-on: https://chromium-review.googlesource.com/952202
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#542154}(cherry picked from commit ddf1f420836db3c7d8e975acd2c7afaf12c6142b)
Reviewed-on: https://chromium-review.googlesource.com/959521
Reviewed-by: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/branch-heads/3359@{#177}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[modify] https://crrev.com/c6cb186c22f2f9ba15995a4dad348e690203b254/chrome/browser/component_updater/third_party_module_list_component_installer_win.cc
[modify] https://crrev.com/c6cb186c22f2f9ba15995a4dad348e690203b254/chrome/browser/conflicts/module_database_win.cc
[modify] https://crrev.com/c6cb186c22f2f9ba15995a4dad348e690203b254/chrome/browser/conflicts/module_database_win.h

Comment 6 by pmonette@chromium.org, Mar 13 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment