New issue
Advanced search Search tips

Issue 819789 link

Starred by 1 user
Status: Fixed
Owner:
pmonette@chromium.org
Closed: Mar 2018
Cc:
chrisha@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug

Blocking:
issue 717696



Sign in to add a comment

[Incompatible Applications] Chrome hangs after repeated calls to LaunchUninstallFlow.

Project Member Reported by pmonette@chromium.org, Mar 7 2018 
Join() is called on the automation thread when it is deleted, which happens every call.

This hangs the UI thread temporarely when it is quickly called repeatedly.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 13 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/219be37228cfe750564dee73499501101cb11b09

commit 219be37228cfe750564dee73499501101cb11b09
Author: Patrick Monette <pmonette@chromium.org>
Date: Tue Mar 13 17:24:29 2018

Use a SequencedTaskRunner in AutomationController instead of a thread

This is made possible now that the MTA is initialized on every sequenced
task runner of the Task Scheduler.

It also fixes the possible hangs on the UI thread when the automation
thread was joined on destruction.

Bug:  819789 
Change-Id: I8964275d97c3302eaa7888e9c827d5e954c2b9eb
Reviewed-on: https://chromium-review.googlesource.com/955673
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542838}
[modify] https://crrev.com/219be37228cfe750564dee73499501101cb11b09/chrome/browser/win/automation_controller.cc
[modify] https://crrev.com/219be37228cfe750564dee73499501101cb11b09/chrome/browser/win/automation_controller.h

Comment 2 by pmonette@chromium.org, Mar 13 2018

Labels: Merge-Request-66
Status: Fixed (was: Assigned)
Request merge to m66 for this small bug fix.
Project Member

Comment 3 by sheriffbot@chromium.org, Mar 14 2018

Labels: -Merge-Request-66 Merge-Approved-66 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M66. Please go ahead and merge the CL to branch 3359 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 14 2018

Labels: -merge-approved-66 merge-merged-3359
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7333cbc226b985907ccb00afe87c4a9a8c43ef32

commit 7333cbc226b985907ccb00afe87c4a9a8c43ef32
Author: Patrick Monette <pmonette@chromium.org>
Date: Wed Mar 14 17:51:09 2018

Use a SequencedTaskRunner in AutomationController instead of a thread

This is made possible now that the MTA is initialized on every sequenced
task runner of the Task Scheduler.

It also fixes the possible hangs on the UI thread when the automation
thread was joined on destruction.

Bug:  819789 
Change-Id: I8964275d97c3302eaa7888e9c827d5e954c2b9eb
Reviewed-on: https://chromium-review.googlesource.com/955673
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#542838}(cherry picked from commit 219be37228cfe750564dee73499501101cb11b09)
Reviewed-on: https://chromium-review.googlesource.com/962825
Reviewed-by: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/branch-heads/3359@{#235}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[modify] https://crrev.com/7333cbc226b985907ccb00afe87c4a9a8c43ef32/chrome/browser/win/automation_controller.cc
[modify] https://crrev.com/7333cbc226b985907ccb00afe87c4a9a8c43ef32/chrome/browser/win/automation_controller.h
►

Sign in to add a comment