New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 819782 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit 26 days ago
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Add mojom API for Assistant Settings

Project Member Reported by updowndota@chromium.org, Mar 7 2018

Issue description

Add mojom API for Assistant Settings. This API will be used by settings UI to get/update settings ui information from the server.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/14394bb991fc7a15b8e8ac0139b389941db9c9bf

commit 14394bb991fc7a15b8e8ac0139b389941db9c9bf
Author: Yue Li <updowndota@chromium.org>
Date: Thu Apr 12 21:35:20 2018

Add Assistant Settings mojom API

- Add AssistantSettingsManager mojom API.
- The AssistantSettingsManager will call AssistantManagerService to
  communicates with internal assistant manager that talks to the server.
- The AssistantSettingsManager will use internal utils to construct
  and unwrap internal proto strings.

Bug:  819782 
Change-Id: I420d8e70543d665587bd2dfdc803afae9d21a310
Reviewed-on: https://chromium-review.googlesource.com/953654
Commit-Queue: Yue Li <updowndota@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550369}
[modify] https://crrev.com/14394bb991fc7a15b8e8ac0139b389941db9c9bf/chromeos/services/assistant/BUILD.gn
[modify] https://crrev.com/14394bb991fc7a15b8e8ac0139b389941db9c9bf/chromeos/services/assistant/assistant_manager_service.h
[modify] https://crrev.com/14394bb991fc7a15b8e8ac0139b389941db9c9bf/chromeos/services/assistant/assistant_manager_service_impl.cc
[modify] https://crrev.com/14394bb991fc7a15b8e8ac0139b389941db9c9bf/chromeos/services/assistant/assistant_manager_service_impl.h
[add] https://crrev.com/14394bb991fc7a15b8e8ac0139b389941db9c9bf/chromeos/services/assistant/assistant_settings_manager.h
[add] https://crrev.com/14394bb991fc7a15b8e8ac0139b389941db9c9bf/chromeos/services/assistant/assistant_settings_manager_impl.cc
[add] https://crrev.com/14394bb991fc7a15b8e8ac0139b389941db9c9bf/chromeos/services/assistant/assistant_settings_manager_impl.h
[modify] https://crrev.com/14394bb991fc7a15b8e8ac0139b389941db9c9bf/chromeos/services/assistant/fake_assistant_manager_service_impl.cc
[modify] https://crrev.com/14394bb991fc7a15b8e8ac0139b389941db9c9bf/chromeos/services/assistant/fake_assistant_manager_service_impl.h
[add] https://crrev.com/14394bb991fc7a15b8e8ac0139b389941db9c9bf/chromeos/services/assistant/fake_assistant_settings_manager_impl.cc
[add] https://crrev.com/14394bb991fc7a15b8e8ac0139b389941db9c9bf/chromeos/services/assistant/fake_assistant_settings_manager_impl.h
[modify] https://crrev.com/14394bb991fc7a15b8e8ac0139b389941db9c9bf/chromeos/services/assistant/manifest.json
[modify] https://crrev.com/14394bb991fc7a15b8e8ac0139b389941db9c9bf/chromeos/services/assistant/public/mojom/BUILD.gn
[add] https://crrev.com/14394bb991fc7a15b8e8ac0139b389941db9c9bf/chromeos/services/assistant/public/mojom/settings.mojom
[add] https://crrev.com/14394bb991fc7a15b8e8ac0139b389941db9c9bf/chromeos/services/assistant/public/proto/BUILD.gn
[add] https://crrev.com/14394bb991fc7a15b8e8ac0139b389941db9c9bf/chromeos/services/assistant/public/proto/about_me_settings_ui.proto
[add] https://crrev.com/14394bb991fc7a15b8e8ac0139b389941db9c9bf/chromeos/services/assistant/public/proto/get_settings_ui.proto
[add] https://crrev.com/14394bb991fc7a15b8e8ac0139b389941db9c9bf/chromeos/services/assistant/public/proto/settings_ui.proto
[modify] https://crrev.com/14394bb991fc7a15b8e8ac0139b389941db9c9bf/chromeos/services/assistant/service.cc
[modify] https://crrev.com/14394bb991fc7a15b8e8ac0139b389941db9c9bf/chromeos/services/assistant/service.h

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 12 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/assistant/+/a796437d87efcd7308fb76233f399ae739ed933a

commit a796437d87efcd7308fb76233f399ae739ed933a
Author: Yue Li <updowndota@google.com>
Date: Fri Mar 30 21:39:00 2018

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/14394bb991fc7a15b8e8ac0139b389941db9c9bf

commit 14394bb991fc7a15b8e8ac0139b389941db9c9bf
Author: Yue Li <updowndota@chromium.org>
Date: Thu Apr 12 21:35:20 2018

Add Assistant Settings mojom API

- Add AssistantSettingsManager mojom API.
- The AssistantSettingsManager will call AssistantManagerService to
  communicates with internal assistant manager that talks to the server.
- The AssistantSettingsManager will use internal utils to construct
  and unwrap internal proto strings.

Bug:  819782 
Change-Id: I420d8e70543d665587bd2dfdc803afae9d21a310
Reviewed-on: https://chromium-review.googlesource.com/953654
Commit-Queue: Yue Li <updowndota@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550369}
[modify] https://crrev.com/14394bb991fc7a15b8e8ac0139b389941db9c9bf/chromeos/services/assistant/BUILD.gn
[modify] https://crrev.com/14394bb991fc7a15b8e8ac0139b389941db9c9bf/chromeos/services/assistant/assistant_manager_service.h
[modify] https://crrev.com/14394bb991fc7a15b8e8ac0139b389941db9c9bf/chromeos/services/assistant/assistant_manager_service_impl.cc
[modify] https://crrev.com/14394bb991fc7a15b8e8ac0139b389941db9c9bf/chromeos/services/assistant/assistant_manager_service_impl.h
[add] https://crrev.com/14394bb991fc7a15b8e8ac0139b389941db9c9bf/chromeos/services/assistant/assistant_settings_manager.h
[add] https://crrev.com/14394bb991fc7a15b8e8ac0139b389941db9c9bf/chromeos/services/assistant/assistant_settings_manager_impl.cc
[add] https://crrev.com/14394bb991fc7a15b8e8ac0139b389941db9c9bf/chromeos/services/assistant/assistant_settings_manager_impl.h
[modify] https://crrev.com/14394bb991fc7a15b8e8ac0139b389941db9c9bf/chromeos/services/assistant/fake_assistant_manager_service_impl.cc
[modify] https://crrev.com/14394bb991fc7a15b8e8ac0139b389941db9c9bf/chromeos/services/assistant/fake_assistant_manager_service_impl.h
[add] https://crrev.com/14394bb991fc7a15b8e8ac0139b389941db9c9bf/chromeos/services/assistant/fake_assistant_settings_manager_impl.cc
[add] https://crrev.com/14394bb991fc7a15b8e8ac0139b389941db9c9bf/chromeos/services/assistant/fake_assistant_settings_manager_impl.h
[modify] https://crrev.com/14394bb991fc7a15b8e8ac0139b389941db9c9bf/chromeos/services/assistant/manifest.json
[modify] https://crrev.com/14394bb991fc7a15b8e8ac0139b389941db9c9bf/chromeos/services/assistant/public/mojom/BUILD.gn
[add] https://crrev.com/14394bb991fc7a15b8e8ac0139b389941db9c9bf/chromeos/services/assistant/public/mojom/settings.mojom
[add] https://crrev.com/14394bb991fc7a15b8e8ac0139b389941db9c9bf/chromeos/services/assistant/public/proto/BUILD.gn
[add] https://crrev.com/14394bb991fc7a15b8e8ac0139b389941db9c9bf/chromeos/services/assistant/public/proto/about_me_settings_ui.proto
[add] https://crrev.com/14394bb991fc7a15b8e8ac0139b389941db9c9bf/chromeos/services/assistant/public/proto/get_settings_ui.proto
[add] https://crrev.com/14394bb991fc7a15b8e8ac0139b389941db9c9bf/chromeos/services/assistant/public/proto/settings_ui.proto
[modify] https://crrev.com/14394bb991fc7a15b8e8ac0139b389941db9c9bf/chromeos/services/assistant/service.cc
[modify] https://crrev.com/14394bb991fc7a15b8e8ac0139b389941db9c9bf/chromeos/services/assistant/service.h

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 25 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/assistant/+/0ee8a2e4b6c8b9c302c52d0a825ef6f3980695c8

commit 0ee8a2e4b6c8b9c302c52d0a825ef6f3980695c8
Author: Yue Li <updowndota@google.com>
Date: Wed Apr 25 23:19:00 2018

Project Member

Comment 5 by bugdroid1@chromium.org, Apr 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5896171330662f90a364edfba7da5264b2f8136c

commit 5896171330662f90a364edfba7da5264b2f8136c
Author: Yue Li <updowndota@chromium.org>
Date: Thu Apr 26 01:49:50 2018

Udpate Settings mojom API for UpdateSettings request

Add UpdateSettings API for update settings ui request.

Bug:  819782 
Test: Manual Test
Change-Id: Ibd7c303da98f0bc95b53ac08c365cc4276ac605f
Reviewed-on: https://chromium-review.googlesource.com/1016039
Commit-Queue: Yue Li <updowndota@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553873}
[modify] https://crrev.com/5896171330662f90a364edfba7da5264b2f8136c/chromeos/services/assistant/assistant_manager_service.h
[modify] https://crrev.com/5896171330662f90a364edfba7da5264b2f8136c/chromeos/services/assistant/assistant_manager_service_impl.cc
[modify] https://crrev.com/5896171330662f90a364edfba7da5264b2f8136c/chromeos/services/assistant/assistant_manager_service_impl.h
[modify] https://crrev.com/5896171330662f90a364edfba7da5264b2f8136c/chromeos/services/assistant/assistant_settings_manager_impl.cc
[modify] https://crrev.com/5896171330662f90a364edfba7da5264b2f8136c/chromeos/services/assistant/assistant_settings_manager_impl.h
[modify] https://crrev.com/5896171330662f90a364edfba7da5264b2f8136c/chromeos/services/assistant/fake_assistant_manager_service_impl.cc
[modify] https://crrev.com/5896171330662f90a364edfba7da5264b2f8136c/chromeos/services/assistant/fake_assistant_manager_service_impl.h
[modify] https://crrev.com/5896171330662f90a364edfba7da5264b2f8136c/chromeos/services/assistant/public/mojom/settings.mojom
[modify] https://crrev.com/5896171330662f90a364edfba7da5264b2f8136c/chromeos/services/assistant/public/proto/about_me_settings_ui.proto
[modify] https://crrev.com/5896171330662f90a364edfba7da5264b2f8136c/chromeos/services/assistant/public/proto/settings_ui.proto
[modify] https://crrev.com/5896171330662f90a364edfba7da5264b2f8136c/chromeos/services/assistant/service.cc

Status: Fixed (was: Untriaged)

Sign in to add a comment