New issue
Advanced search Search tips

Issue 819744 link

Starred by 2 users
Status: Fixed
Owner:
bajones@chromium.org
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , Windows
Pri: 3
Type: Bug
Proj-XR



Sign in to add a comment

Update WebXR getViewport method, external attribute to match spec updates

Project Member Reported by bajones@chromium.org, Mar 7 2018 
Relevant GitHub PRs:
https://github.com/immersive-web/webxr/pull/328
https://github.com/immersive-web/webxr/pull/329

The WebXR spec has been updated to move the getViewport function from XRView to XRWebGLLayer, and the external attribute has been removed from the XRDevice. Chrome's implementation should be updated to account for both of these changes.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/300cd0df1125cce946d77bf041da44a3e8082dff

commit 300cd0df1125cce946d77bf041da44a3e8082dff
Author: Brandon Jones <bajones@chromium.org>
Date: Thu Mar 08 06:27:50 2018

Moved XR getViewport, removed XRDevice.external

Brings Chrome's implementation inline with the latest spec changes.

Bug:  819744 
Change-Id: I716bab14bdbcc1c452a4dd447adbe28ffef05f98
Reviewed-on: https://chromium-review.googlesource.com/953259
Commit-Queue: Brandon Jones <bajones@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541739}
[modify] https://crrev.com/300cd0df1125cce946d77bf041da44a3e8082dff/third_party/WebKit/LayoutTests/external/wpt/interfaces/webxr.idl
[modify] https://crrev.com/300cd0df1125cce946d77bf041da44a3e8082dff/third_party/WebKit/LayoutTests/external/wpt/webxr/interfaces.https-expected.txt
[modify] https://crrev.com/300cd0df1125cce946d77bf041da44a3e8082dff/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/300cd0df1125cce946d77bf041da44a3e8082dff/third_party/WebKit/LayoutTests/xr/requestDevice_one_device.html
[modify] https://crrev.com/300cd0df1125cce946d77bf041da44a3e8082dff/third_party/WebKit/LayoutTests/xr/requestDevice_two_devices.html
[modify] https://crrev.com/300cd0df1125cce946d77bf041da44a3e8082dff/third_party/WebKit/LayoutTests/xr/xrViewport_valid.html
[modify] https://crrev.com/300cd0df1125cce946d77bf041da44a3e8082dff/third_party/WebKit/Source/modules/xr/XRDevice.idl
[modify] https://crrev.com/300cd0df1125cce946d77bf041da44a3e8082dff/third_party/WebKit/Source/modules/xr/XRFrameProvider.cpp
[modify] https://crrev.com/300cd0df1125cce946d77bf041da44a3e8082dff/third_party/WebKit/Source/modules/xr/XRLayer.cpp
[modify] https://crrev.com/300cd0df1125cce946d77bf041da44a3e8082dff/third_party/WebKit/Source/modules/xr/XRLayer.h
[modify] https://crrev.com/300cd0df1125cce946d77bf041da44a3e8082dff/third_party/WebKit/Source/modules/xr/XRView.cpp
[modify] https://crrev.com/300cd0df1125cce946d77bf041da44a3e8082dff/third_party/WebKit/Source/modules/xr/XRView.h
[modify] https://crrev.com/300cd0df1125cce946d77bf041da44a3e8082dff/third_party/WebKit/Source/modules/xr/XRView.idl
[modify] https://crrev.com/300cd0df1125cce946d77bf041da44a3e8082dff/third_party/WebKit/Source/modules/xr/XRWebGLLayer.cpp
[modify] https://crrev.com/300cd0df1125cce946d77bf041da44a3e8082dff/third_party/WebKit/Source/modules/xr/XRWebGLLayer.h
[modify] https://crrev.com/300cd0df1125cce946d77bf041da44a3e8082dff/third_party/WebKit/Source/modules/xr/XRWebGLLayer.idl

Comment 2 by bajones@chromium.org, Mar 8 2018

Status: Fixed (was: Started)

Comment 3 by dougman@chromium.org, Mar 12 2018

Labels: Test-Complete

Comment 4 by btebbs@chromium.org, Jul 4

Components: Blink>WebXR
►

Sign in to add a comment