Flaky crash during ContentBrowserTest.HideDownloadFromUnmodifiedNewTab on win7_chromium_rel_ng |
||
Issue descriptionhttps://ci.chromium.org/buildbot/tryserver.chromium.win/win7_chromium_rel_ng/117641 https://ci.chromium.org/buildbot/tryserver.chromium.win/win7_chromium_rel_ng/117586 https://ci.chromium.org/buildbot/tryserver.chromium.win/win7_chromium_rel_ng/117582 https://ci.chromium.org/buildbot/tryserver.chromium.win/win7_chromium_rel_ng/117553 https://ci.chromium.org/buildbot/tryserver.chromium.win/win7_chromium_rel_ng/117544 [ RUN ] ContentBrowserTest.HideDownloadFromUnmodifiedNewTab DevTools listening on ws://127.0.0.1:56321/devtools/browser/26b69b97-8b11-480c-ab05-ef07c40cd9c9 Received fatal exception EXCEPTION_ACCESS_VIOLATION [7632:8184:0307/114243.749:INFO:media_foundation_video_encode_accelerator_win.cc(370)] Windows versions earlier than 8 are not supported. Backtrace: content::ShellDownloadManagerDelegate::ChooseDownloadPath [0x0281A33D+339] content::ShellDownloadManagerDelegate::OnDownloadPathGenerated [0x0281A026+214] base::internal::Invoker<base::internal::BindState<void (__thiscall disk_cache::SimpleBackendImpl::SimpleIterator::*)(disk_cache::Entry * *,base::RepeatingCallback<void __cdecl(int)> const &,int),base::WeakPtr<disk_cache::SimpleBackendImpl::SimpleIterator> [0x0281A52A+58] base::RepeatingCallback<void __cdecl(enum blink::mojom::WebBluetoothResult)>::Run [0x01762138+48] base::internal::FunctorTraits<base::RepeatingCallback<void __cdecl(SkBitmap const &)>,void>::Invoke<base::RepeatingCallback<void __cdecl(SkBitmap const &)>,SkBitmap> [0x049003D6+94] base::internal::Invoker<base::internal::BindState<base::RepeatingCallback<void __cdecl(SkBitmap const &)>,SkBitmap>,void __cdecl(void)>::RunOnce [0x04900373+19] base::debug::TaskAnnotator::RunTask [0x02AED58D+237] base::internal::IncomingTaskQueue::RunTask [0x02B11AA9+105] base::MessageLoop::RunTask [0x02A8F0D7+519] base::MessageLoop::DeferOrRunPendingTask [0x02A8F43D+157] base::MessageLoop::DoWork [0x02A8F66A+506] base::MessagePumpForUI::DoRunLoop [0x02AF74D8+120] base::MessagePumpWin::Run [0x02AF703E+110] base::MessageLoop::Run [0x02A8EA79+169] base::RunLoop::Run [0x02A7CF4F+207] base::RunLoop::RunUntilIdle [0x02A7D453+99] content::Shell::CloseAllWindows [0x02816ECF+103] content::ContentBrowserTest::PostRunTestOnMainThread [0x027D671D+93] content::BrowserTestBase::ProxyRunTestOnMainThreadLoop [0x027F0563+867] content::ShellBrowserMainParts::PreMainMessageLoopRun [0x02823231+161] content::BrowserMainLoop::PreMainMessageLoopRun [0x018A3A34+68] content::StartupTaskRunner::RunAllTasksNow [0x01BD6110+30] content::BrowserMainLoop::CreateStartupTasks [0x018A28B5+731] content::BrowserMainRunnerImpl::Initialize [0x018A6164+100] ShellBrowserMain [0x04A5F687+43] content::ShellMainDelegate::RunProcess [0x04A5ECD0+176] content::RunNamedProcessTypeMain [0x017E811C+132] content::ContentMainRunnerImpl::Run [0x017E8687+279] service_manager::Main [0x039F82E5+677] content::ContentMain [0x017E803F+51] content::BrowserTestBase::SetUp [0x027F0124+1828] content::ContentBrowserTest::SetUp [0x027D659A+106] testing::Test::Run [0x01058857+105] testing::TestInfo::Run [0x01058F7D+203] testing::TestCase::Run [0x01059319+237] testing::internal::UnitTestImpl::RunAllTests [0x0105F115+629] testing::UnitTest::Run [0x0105ED9B+153] base::TestSuite::Run [0x028056DA+102] content::ContentTestLauncherDelegate::RunTestSuite [0x04A59252+50] content::LaunchTests [0x027F14DD+413] main [0x04A591F9+65] __scrt_common_main_seh [0x0528477A+248] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:283) BaseThreadInitThunk [0x75A0336A+18] RtlInitializeExceptionChain [0x772A9882+99] RtlInitializeExceptionChain [0x772A9855+54] [811/2436] ContentBrowserTest.HideDownloadFromUnmodifiedNewTab (CRASHED)
,
Mar 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0ac6d139849603865b07df2f66003a5bab6860fd commit 0ac6d139849603865b07df2f66003a5bab6860fd Author: Jochen Eisinger <jochen@chromium.org> Date: Thu Mar 08 12:52:41 2018 Wait for download to finish before finishing test Otherwise, we might crash flakily on windows, as we might tear down the Shell (WebContentsDelegate) before the callback to select a filename has returned. BUG= 819739 R=battre@chromium.org Change-Id: I09348f556ee10a9efae738b0ee2721c23641590a Reviewed-on: https://chromium-review.googlesource.com/954944 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#541778} [modify] https://crrev.com/0ac6d139849603865b07df2f66003a5bab6860fd/content/browser/frame_host/navigation_controller_impl_browsertest.cc
,
Mar 11 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by jochen@chromium.org
, Mar 8 2018Status: Assigned (was: Untriaged)