SubresourceFilterBrowserTests are slow |
||
Issue descriptionMany browser tests rely on the RulesetServiceDelegate to run tasks after startup. ContentRulesetService (the RulesetServiceDelegate) uses content::BrowserThread::PostAfterStartupTask to schedule this. Startup tasks are delayed by 1-10 seconds[1], which means browser tests may be delayed by 1-10 seconds. Suggest changing SubresourceFilterBrowserTest to manually tell the ruleset_service that we're beyond startup via set_is_after_startup_for_testing. [1] https://www.google.com/url?q=https://cs.chromium.org/chromium/src/chrome/browser/after_startup_task_utils.cc?l%3D75&sa=D&source=hangouts&ust=1520537942629000&usg=AFQjCNG-7qE7ns8uHPPkWofN4mFJbdLfZg
,
Mar 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ba0d17f7b580a3663c8722a6304748eb99e5905a commit ba0d17f7b580a3663c8722a6304748eb99e5905a Author: Charles Harrison <csharrison@chromium.org> Date: Thu Mar 08 20:41:55 2018 [subresource_filter] Fake being after startup in browser tests This should speed up the wall time of these browser tests significantly h/t to jkarlin for discovering this issue. Bug: 819721 Change-Id: I5368234cd3ea729eb262af22233df496e1368c4b Reviewed-on: https://chromium-review.googlesource.com/953803 Reviewed-by: Josh Karlin <jkarlin@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#541882} [modify] https://crrev.com/ba0d17f7b580a3663c8722a6304748eb99e5905a/chrome/browser/subresource_filter/subresource_filter_browser_test_harness.cc
,
Mar 8 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by csharrison@chromium.org
, Mar 7 2018Status: Started (was: Untriaged)