New issue
Advanced search Search tips

Issue 819717 link

Starred by 1 user
Status: Assigned
Owner:
klausw@chromium.org
Cc:
zmo@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac , Fuchsia
Pri: 2
Type: Bug



Sign in to add a comment

ui gl autogen mock headers fail presubmit

Project Member Reported by thakis@chromium.org, Mar 7 2018 
Running presubmit upload checks ...

** Presubmit Warnings **
Missing include guard UI_GL_EGL_BINDINGS_AUTOGEN_MOCK_H_
  ui/gl/egl_bindings_autogen_mock.h

***************
Missing include guard in ui/gl/egl_bindings_autogen_mock.h
Recommended name: UI_GL_EGL_BINDINGS_AUTOGEN_MOCK_H_
This check can be disabled by having the string
no-include-guard-because-multiply-included in the header.
***************

Missing include guard UI_GL_GL_MOCK_AUTOGEN_EGL_H_
  ui/gl/gl_mock_autogen_egl.h

***************
Missing include guard in ui/gl/gl_mock_autogen_egl.h
Recommended name: UI_GL_GL_MOCK_AUTOGEN_EGL_H_
This check can be disabled by having the string
no-include-guard-because-multiply-included in the header.
***************

Presubmit checks took 7.4s to calculate.



Probably easiest to add no-include-guard-because-multiply-included.

Comment 1 by kbr@chromium.org, Mar 7 2018

Cc: zmo@chromium.org
We should add a --check option to generate_bindings.py and change src/ui/gl/PRESUBMIT.py to invoke the script with this argument, similarly to src/testing/buildbot/PRESUBMIT.py . That will prevent the autogenerated files from ever getting out of sync with the generator.
►

Sign in to add a comment