New issue
Advanced search Search tips

Issue 819707 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

[iOS] Needs unit tests for the code to record important consent moments

Project Member Reported by jlebel@chromium.org, Mar 7 2018

Issue description

Needs unit tests for crrev.com/c/924033, related to  crbug.com/819204 

 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/298127f5f7d3a1876bb6b41b7e231fe51f6214bc

commit 298127f5f7d3a1876bb6b41b7e231fe51f6214bc
Author: Jérôme Lebel <jlebel@chromium.org>
Date: Tue Mar 20 19:38:31 2018

[iOS] Adding unit tests for code to record important consent moments

This patch adds unit tests for code from crrev.com/c/924033

Bug:  819707 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I6e3c35289636d9acb25b00f56332d533aa731bc4
Reviewed-on: https://chromium-review.googlesource.com/934291
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544490}
[modify] https://crrev.com/298127f5f7d3a1876bb6b41b7e231fe51f6214bc/ios/chrome/browser/ui/authentication/BUILD.gn
[modify] https://crrev.com/298127f5f7d3a1876bb6b41b7e231fe51f6214bc/ios/chrome/browser/ui/authentication/chrome_signin_view_controller.h
[modify] https://crrev.com/298127f5f7d3a1876bb6b41b7e231fe51f6214bc/ios/chrome/browser/ui/authentication/chrome_signin_view_controller.mm
[add] https://crrev.com/298127f5f7d3a1876bb6b41b7e231fe51f6214bc/ios/chrome/browser/ui/authentication/chrome_signin_view_controller_unittest.mm
[modify] https://crrev.com/298127f5f7d3a1876bb6b41b7e231fe51f6214bc/ios/chrome/browser/ui/first_run/BUILD.gn
[modify] https://crrev.com/298127f5f7d3a1876bb6b41b7e231fe51f6214bc/ios/chrome/browser/ui/promos/BUILD.gn
[modify] https://crrev.com/298127f5f7d3a1876bb6b41b7e231fe51f6214bc/ios/public/provider/chrome/browser/signin/BUILD.gn
[add] https://crrev.com/298127f5f7d3a1876bb6b41b7e231fe51f6214bc/ios/public/provider/chrome/browser/signin/DEPS
[modify] https://crrev.com/298127f5f7d3a1876bb6b41b7e231fe51f6214bc/ios/public/provider/chrome/browser/signin/test_signin_resources_provider.mm

Comment 2 by jlebel@chromium.org, Mar 20 2018

Status: f (was: Started)

Comment 3 by jlebel@chromium.org, Mar 20 2018

Status: Fixed (was: F)

Sign in to add a comment