New issue
Advanced search Search tips

Issue 819706 link

Starred by 1 user
Status: Fixed
Owner:
sorin@chromium.org
Closed: Mar 2018
Cc:
waff...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Make UpdateEngine and UpdateContext refcounted types.

Project Member Reported by sorin@chromium.org, Mar 7 2018 
Instances of these types are stored and may be passed as arguments to callback.
It is desirable to make them ref counted.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8cfa58712d2207ba3926778f5045dab1b95ce1b2

commit 8cfa58712d2207ba3926778f5045dab1b95ce1b2
Author: Sorin Jianu <sorin@chromium.org>
Date: Thu Mar 08 00:59:05 2018

Make UpdateEngine and UpdateContext refcounted types.

Bug:  819706 
Change-Id: I5d9a244871ec06b33babb56eb8bd2453133c3c8b
Reviewed-on: https://chromium-review.googlesource.com/953243
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541660}
[modify] https://crrev.com/8cfa58712d2207ba3926778f5045dab1b95ce1b2/components/update_client/ping_manager_unittest.cc
[modify] https://crrev.com/8cfa58712d2207ba3926778f5045dab1b95ce1b2/components/update_client/task.h
[modify] https://crrev.com/8cfa58712d2207ba3926778f5045dab1b95ce1b2/components/update_client/task_send_uninstall_ping.cc
[modify] https://crrev.com/8cfa58712d2207ba3926778f5045dab1b95ce1b2/components/update_client/task_send_uninstall_ping.h
[modify] https://crrev.com/8cfa58712d2207ba3926778f5045dab1b95ce1b2/components/update_client/task_update.cc
[modify] https://crrev.com/8cfa58712d2207ba3926778f5045dab1b95ce1b2/components/update_client/task_update.h
[modify] https://crrev.com/8cfa58712d2207ba3926778f5045dab1b95ce1b2/components/update_client/update_checker_unittest.cc
[modify] https://crrev.com/8cfa58712d2207ba3926778f5045dab1b95ce1b2/components/update_client/update_client.cc
[modify] https://crrev.com/8cfa58712d2207ba3926778f5045dab1b95ce1b2/components/update_client/update_client_internal.h
[modify] https://crrev.com/8cfa58712d2207ba3926778f5045dab1b95ce1b2/components/update_client/update_engine.cc
[modify] https://crrev.com/8cfa58712d2207ba3926778f5045dab1b95ce1b2/components/update_client/update_engine.h

Comment 2 by sorin@chromium.org, Mar 9 2018

Status: Fixed (was: Untriaged)
►

Sign in to add a comment