New issue
Advanced search Search tips

Issue 819691 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Remove gnutls dependency from cups-filters ebuild after updating cups-filters configure script

Project Member Reported by valleau@chromium.org, Mar 7 2018

Issue description

Due to the fact that cups-filters used to be a part of the larger cups project, it seems that there are still some dependencies listed in the cups-filters configure script which are no longer necessary.

For the time being, in order to be able to update the gnutls library a direct dependency to gnutls has been added to the cups-filters ebuild.

After cleaning up the cups-filters configure script, this dependency should be removed from the ebuild.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/ca82db314ffc76648789d11743862989d2dec695

commit ca82db314ffc76648789d11743862989d2dec695
Author: Brian Norris <briannorris@chromium.org>
Date: Sat Mar 10 01:39:16 2018

cups: patch out excess libraries from `cups-config --libs`

cups-config should only be advertising -lcups.

Sent upstream here:
https://github.com/apple/cups/pull/5261

BUG= chromium:819700 ,  chromium:819691 
TEST=build image; pre-CQ; CUPS autotests

Change-Id: I192336537e4faf0238bea70963760ac6c4748850
Signed-off-by: Brian Norris <briannorris@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/955885
Reviewed-by: Sean Kau <skau@chromium.org>

[modify] https://crrev.com/ca82db314ffc76648789d11743862989d2dec695/net-print/cups/cups-2.1.4.ebuild
[add] https://crrev.com/ca82db314ffc76648789d11743862989d2dec695/net-print/cups/files/cups-2.1.4-cups-config-libs.patch
[rename] https://crrev.com/ca82db314ffc76648789d11743862989d2dec695/net-print/cups/cups-2.1.4-r39.ebuild

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/portage-stable/+/a3a88c26f47fcaa73f0d3a83b088cd3b3cafb311

commit a3a88c26f47fcaa73f0d3a83b088cd3b3cafb311
Author: David Valleau <valleau@chromium.org>
Date: Fri Mar 16 00:58:17 2018

Removing direct gnutls dependency from cups-filters

The outdated dependencies from cups-config have been removed
(https://crrev.com/c/955885) so now it should be safe to remove the direct
dependency on gnutls.

BUG= chromium:819691 
TEST=Able to successfully emerge

Change-Id: Ia31200fc9c4594a6ec47865595d9b8fc1f259849
Reviewed-on: https://chromium-review.googlesource.com/964582
Commit-Ready: David Valleau <valleau@chromium.org>
Tested-by: David Valleau <valleau@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[rename] https://crrev.com/a3a88c26f47fcaa73f0d3a83b088cd3b3cafb311/net-print/cups-filters/cups-filters-1.17.8-r3.ebuild

Status: Fixed (was: Assigned)

Sign in to add a comment