New issue
Advanced search Search tips

Issue 819687 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

The clear button is missing on the File Manager app

Project Member Reported by x...@chromium.org, Mar 7 2018

Issue description

Open Files app, click on the Search icon, and type in any character.

Expected:
The clear button shows up.

Actual:
No button shows up.

See the attached screenshots for actual/expected behaviors. 

It's a regression caused by upgrading paper-input to the 2.* version in M66, see https://chromium.googlesource.com/chromium/src/+/dbf4d6cce495d5797ffde3fdd04006b3e4000e39
 
Screenshot 2018-03-07 at 10.39.44.png
176 KB View Download
Screenshot 2018-03-07 at 10.38.06.png
349 KB View Download

Comment 1 by x...@chromium.org, Mar 7 2018

Cc: fukino@chromium.org
Status: Started (was: Assigned)
https://chromium-review.googlesource.com/c/chromium/src/+/953162
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fdb1d59257a8dbf91dc72844687f9ec0e8f7edbd

commit fdb1d59257a8dbf91dc72844687f9ec0e8f7edbd
Author: Xiaoqian Dai <xdai@chromium.org>
Date: Mon Mar 12 04:32:19 2018

Cros: Fix the missing clear button on Files App.

Bug:  819687 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I522757792789eb4e492ee34a6bf4f17d463018c3
Reviewed-on: https://chromium-review.googlesource.com/953162
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542423}
[modify] https://crrev.com/fdb1d59257a8dbf91dc72844687f9ec0e8f7edbd/ui/file_manager/file_manager/main.html

Comment 3 by x...@chromium.org, Mar 13 2018

Labels: Merge-Request-66
Status: Fixed (was: Started)
Project Member

Comment 4 by sheriffbot@chromium.org, Mar 14 2018

Labels: -Merge-Request-66 Merge-Approved-66 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M66. Please go ahead and merge the CL to branch 3359 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 14 2018

Labels: -merge-approved-66 merge-merged-3359
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aab91ca5ad502523e931a7a89131d37d9a7d914c

commit aab91ca5ad502523e931a7a89131d37d9a7d914c
Author: Xiaoqian Dai <xdai@chromium.org>
Date: Wed Mar 14 19:57:14 2018

[Merge to M66]Cros: Fix the missing clear button on Files App.

Bug:  819687 
TBR=fukino@chromium.org

(cherry picked from commit fdb1d59257a8dbf91dc72844687f9ec0e8f7edbd)

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I522757792789eb4e492ee34a6bf4f17d463018c3
Reviewed-on: https://chromium-review.googlesource.com/953162
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#542423}
Reviewed-on: https://chromium-review.googlesource.com/963290
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/branch-heads/3359@{#240}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[modify] https://crrev.com/aab91ca5ad502523e931a7a89131d37d9a7d914c/ui/file_manager/file_manager/main.html

Sign in to add a comment