paint/invalidation/background/obscured-background-no-repaint.html failed in webkit_layout_tests failing on chromium.webkit/WebKit Linux Trusty ASAN |
||||||||
Issue descriptionFiled by sheriff-o-matic@appspot.gserviceaccount.com on behalf of penghuang@google.com paint/invalidation/background/obscured-background-no-repaint.html failed in webkit_layout_tests failing on chromium.webkit/WebKit Linux Trusty ASAN Builders failed on: - WebKit Linux Trusty ASAN: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20ASAN/builds/9797
,
Mar 7 2018
Hi khushalsagar, Could you please take a look? Thanks.
,
Mar 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3c346ce8dffd4d78f6b8b9008c2d5cb1301046fc commit 3c346ce8dffd4d78f6b8b9008c2d5cb1301046fc Author: Peng Huang <penghuang@chromium.org> Date: Wed Mar 07 20:43:23 2018 Update Layout test expection for paint/invalidation/background/obscured-background-no-repaint.html TBR=stgao@chromium.org Bug: 819683 Change-Id: I48ea37df344775b577d1231286a20f46584b7634 Reviewed-on: https://chromium-review.googlesource.com/953130 Reviewed-by: Peng Huang <penghuang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#541564} [modify] https://crrev.com/3c346ce8dffd4d78f6b8b9008c2d5cb1301046fc/third_party/WebKit/LayoutTests/TestExpectations
,
Mar 7 2018
Huh, the only change I made to that test was to use an animated svg instead of a gif. This looks like a paint bug, its failing in PaintController::CheckUnderInvalidation. pdr@, would you be the correct person for this, because svg?
,
Mar 8 2018
,
Mar 8 2018
,
Mar 8 2018
,
Mar 8 2018
,
Mar 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d2aa77c35380fecb6958d19c3005a768e0b41174 commit d2aa77c35380fecb6958d19c3005a768e0b41174 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Fri Mar 09 20:55:04 2018 [PE] Disable under-invalidation checking for animated images Animated images may change before invalidation. For example, an image with SVG animation gets ImageChanged notification periodically but a paint triggered by some other change may not just follow an invalidation of the animated image. Bug: 819683 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I5acb3eedc0ac714a600ac6df752dc22245bf3d1d Reviewed-on: https://chromium-review.googlesource.com/956303 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#542211} [modify] https://crrev.com/d2aa77c35380fecb6958d19c3005a768e0b41174/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/d2aa77c35380fecb6958d19c3005a768e0b41174/third_party/WebKit/LayoutTests/paint/invalidation/table/animated-row-background.html [modify] https://crrev.com/d2aa77c35380fecb6958d19c3005a768e0b41174/third_party/WebKit/Source/core/paint/BoxPainter.cpp [modify] https://crrev.com/d2aa77c35380fecb6958d19c3005a768e0b41174/third_party/WebKit/Source/core/paint/ImagePainter.cpp [modify] https://crrev.com/d2aa77c35380fecb6958d19c3005a768e0b41174/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp
,
Mar 9 2018
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by penghuang@chromium.org
, Mar 7 2018