New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 819667 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-03-28
OS: iOS
Pri: 2
Type: Task
Q1



Sign in to add a comment

Add dynamic type to tab grid

Project Member Reported by edchin@chromium.org, Mar 7 2018

Issue description

Add dynamic type to tab grid
 
Cc: cma...@chromium.org marq@chromium.org rohitrao@chromium.org
Components: UI>Browser
Labels: -Restrict-View-Google -Type-Bug MS-Tab-Grid small Q1 Type-Task
Labels: -small medium S-See-Open-Tabs
Changing to medium given need to read up and watch videos on this.
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4d1cc682d5776d9c900a53e68c9db090f78588f

commit f4d1cc682d5776d9c900a53e68c9db090f78588f
Author: edchin <edchin@chromium.org>
Date: Thu Mar 15 07:19:17 2018

[ios] Dynamic type in tab grid

Dynamic type is now used in the:
- grid cell title
- toolbar text buttons
- empty state texts

The dynamic type used in the grid cell title
and the empty state text do not adhere to spec
because they are not semi-bolded.

Bug:  819667 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ie8ccccc68ec783ce6277c1cb57a26ba5895de8fd
Reviewed-on: https://chromium-review.googlesource.com/963180
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543323}
[modify] https://crrev.com/f4d1cc682d5776d9c900a53e68c9db090f78588f/ios/chrome/browser/ui/tab_grid/grid_cell.mm
[modify] https://crrev.com/f4d1cc682d5776d9c900a53e68c9db090f78588f/ios/chrome/browser/ui/tab_grid/tab_grid_bottom_toolbar.mm
[modify] https://crrev.com/f4d1cc682d5776d9c900a53e68c9db090f78588f/ios/chrome/browser/ui/tab_grid/tab_grid_top_toolbar.mm
[modify] https://crrev.com/f4d1cc682d5776d9c900a53e68c9db090f78588f/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm

Comment 4 by edchin@chromium.org, Mar 15 2018

Status: Fixed (was: Assigned)
Finalizing the right preferred font styles will be considered part of polishing. If significant work is required to get custom fonts (i.e. semibold) that scale with dynamic type, then we can reopen this task or create a new one. Marking this done.

Comment 5 by edchin@chromium.org, Mar 15 2018

NextAction: 2018-03-28
The NextAction date has arrived: 2018-03-28

Sign in to add a comment