New issue
Advanced search Search tips

Issue 819663 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug
Proj-Servicification



Sign in to add a comment

Network service path needs some way to notify WebContents of LoadInfo updates

Project Member Reported by csharrison@chromium.org, Mar 7 2018

Issue description

See RDHI::UpdateLoadInfo for how this is done in the current system.
 

Comment 1 by mmenke@chromium.org, Mar 23 2018

Cc: mmenke@chromium.org
 Issue 825265  has been merged into this issue.

Comment 2 by dxie@chromium.org, May 15 2018

Labels: -Pri-3 Proj-Servicification-Canary OS-All Pri-1
Status: Available (was: Untriaged)

Comment 3 by dxie@chromium.org, May 18 2018

Labels: -OS-All OS-Windows OS-Linux OS-Mac OS-Chrome OS-Android
Owner: chongz@chromium.org
Status: Started (was: Available)
Taking this one assuming no one is working on it.
Owner: ----
Status: Available (was: Started)
Marking as available since my other bug is taking longer than expected.

Owner: jam@chromium.org
Status: Assigned (was: Available)
I can take a look at this.
Status: Started (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/12bb3f087d041c9c223b0600befc9777f9e74d40

commit 12bb3f087d041c9c223b0600befc9777f9e74d40
Author: John Abd-El-Malek <jam@chromium.org>
Date: Mon Aug 13 04:35:09 2018

Get LoadStatus working with network service.

Bug:  819663 

Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I5a79280401e460954a53de4db529061c3f9bae49
Reviewed-on: https://chromium-review.googlesource.com/1171257
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582502}
[modify] https://crrev.com/12bb3f087d041c9c223b0600befc9777f9e74d40/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/12bb3f087d041c9c223b0600befc9777f9e74d40/content/browser/loader/resource_dispatcher_host_impl.h
[modify] https://crrev.com/12bb3f087d041c9c223b0600befc9777f9e74d40/content/browser/network_service_client.cc
[modify] https://crrev.com/12bb3f087d041c9c223b0600befc9777f9e74d40/content/browser/network_service_client.h
[modify] https://crrev.com/12bb3f087d041c9c223b0600befc9777f9e74d40/content/browser/web_contents/web_contents_impl_browsertest.cc
[modify] https://crrev.com/12bb3f087d041c9c223b0600befc9777f9e74d40/services/network/network_context.cc
[modify] https://crrev.com/12bb3f087d041c9c223b0600befc9777f9e74d40/services/network/network_service.cc
[modify] https://crrev.com/12bb3f087d041c9c223b0600befc9777f9e74d40/services/network/network_service.h
[modify] https://crrev.com/12bb3f087d041c9c223b0600befc9777f9e74d40/services/network/network_service_unittest.cc
[modify] https://crrev.com/12bb3f087d041c9c223b0600befc9777f9e74d40/services/network/public/mojom/network_service.mojom
[modify] https://crrev.com/12bb3f087d041c9c223b0600befc9777f9e74d40/services/network/test/test_network_service_client.cc
[modify] https://crrev.com/12bb3f087d041c9c223b0600befc9777f9e74d40/services/network/test/test_network_service_client.h
[modify] https://crrev.com/12bb3f087d041c9c223b0600befc9777f9e74d40/services/network/url_loader_unittest.cc
[modify] https://crrev.com/12bb3f087d041c9c223b0600befc9777f9e74d40/testing/buildbot/filters/mojo.fyi.network_content_browsertests.filter

Worth noting that with the above CL, we'll still not be able to report when a request is blocked by a web request extension (Not even sure what we'll report then - I suppose the network service will not recognize those blocked before start, and those blocked during redirects or at some other phase will just report that they're blocked by something, which is mapped to "Processing request", which isn't too useful)
Status: Fixed (was: Started)

Sign in to add a comment