Re-Enable TabGridMediator failing unittests |
|||||
Issue descriptionUnit tests failed once they landed, disabling them to unclog the tree. https://logs.chromium.org/v/?s=chrome%2Fbb%2Finternal.bling.main%2Fiphone10-device-x64%2F10443%2F%2B%2Frecipes%2Fsteps%2Fios_chrome_unittests__iPhone_6s_iOS_10.3.3__on_iOS-10.3.3%2F0%2Fstdout Failing tests: TabGridMediatorTest.ConsumerInsertItem TabGridMediatorTest.ConsumerPopulateItems
,
Mar 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8bded5ec5782d7c7cf3fe8db740faa6fe855601b commit 8bded5ec5782d7c7cf3fe8db740faa6fe855601b Author: mrefaat <mrefaat@chromium.org> Date: Wed Mar 07 21:55:26 2018 Disable TabGridMediator failing tests These tests started failing once they were landed. created crbug/819658 to track progress and re-enable them. link for logs: https://uberchromegw.corp.google.com/i/internal.bling.main/builders/iphone10-device-x64/builds/10443/steps/ios_chrome_unittests%20%28iPhone%206s%20iOS%2010.3.3%29%20on%20iOS-10.3.3 Bug: 819658 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I470732c12bffc2e8e105c159c8616d679771381c Reviewed-on: https://chromium-review.googlesource.com/951649 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#541598} [modify] https://crrev.com/8bded5ec5782d7c7cf3fe8db740faa6fe855601b/ios/chrome/browser/ui/tab_grid/tab_grid_mediator_unittest.mm
,
Mar 8 2018
,
Mar 21 2018
CL is in-flight. OCMocks were failing on devices but not on simulator. Decided to use fakes instead of mocks.
,
Mar 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3d42a133d7b42da78618fd04bdeff134dd7d5897 commit 3d42a133d7b42da78618fd04bdeff134dd7d5897 Author: edchin <edchin@chromium.org> Date: Wed Mar 21 15:56:01 2018 [ios] Fix device failing TabGridMediatorTests Using OCMock was failing on devices but passing on simulator. This CL uses a more reliable fake/test object rather than a mock. Bug: 819658 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I101c7b0380a13f9972789b99bb88d4dcc52d7b59 Reviewed-on: https://chromium-review.googlesource.com/972664 Reviewed-by: edchin <edchin@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#544718} [modify] https://crrev.com/3d42a133d7b42da78618fd04bdeff134dd7d5897/ios/chrome/browser/ui/tab_grid/tab_grid_mediator_unittest.mm
,
Mar 22 2018
,
May 9 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by mrefaat@chromium.org
, Mar 7 2018